Paul Rigge
88d643eb36
Add null check when adding variable to dict.
2018-01-02 17:22:33 -08:00
Paul Rigge
1bbe6d0a30
Add null pointer assertions for do_unlet_var.
2018-01-02 17:22:33 -08:00
Paul Rigge
2e630d2611
Refactor profiling check in call_user_func.
...
do_profiling is a global variable, and as such the clang static
analyzer has trouble making arguments about it.
This commit does one comparison against do_profiling and puts the
result in a local variable. This prevents errors from the value of
do_profiling changing between comparisons.
2018-01-02 17:22:33 -08:00
Paul Rigge
65ec4ea629
Add assertions for watchers
...
The clang static analyzer convinced itself lp->ll_newkey could be NULL.
This adds an assertion that checks this doesn't actually happen, as well
as a parallel assertion for di->di_key.
2018-01-02 17:22:33 -08:00
Paul Rigge
dea7a41138
Add another const to tv_copy
...
Clang static analyzer had trouble with filter_map in eval.c because
tv_copy could, in principle, change the v_type of argvars[0]. It
saw a potential null pointer going somewhere it shouldn't as a result.
The from argument in tv_copy should be const, which also cleans up the
static analyzer's complaint.
2018-01-02 17:22:33 -08:00
Paul Rigge
d63c3d9d10
Add assertion in set_var_lval for null pointer.
...
If the lval is a index into a list, li should not be null.
2018-01-02 17:22:33 -08:00
Justin M. Keyes
9ad557fb2d
Merge pull request #7762 from ZyX-I/remove-some-listitems
...
Remove some tv_list_item_…() functions
2017-12-31 01:11:50 +01:00
ZyX
8ac7c23b7d
eval: Fix linter errors
2017-12-31 01:00:13 +03:00
ZyX
c55cf5f4c1
eval,lua/converter: Fix problems spotted in review
2017-12-31 01:00:13 +03:00
Daniel Hahler
46f432074e
tests: termclose_spec: fix flaky SIGTERM test #7787
...
Followup to https://github.com/neovim/neovim/pull/7217 .
Build failure: https://travis-ci.org/neovim/neovim/jobs/322930672#L2958 .
2017-12-30 22:49:50 +01:00
James McCoy
a30242d661
Merge pull request #7791 from jamessan/vim-8.0.0608
...
[RFC] vim-patch:8.0.0608
2017-12-30 10:04:03 -05:00
James McCoy
caf94c72c5
lint
2017-12-30 07:56:12 -05:00
James McCoy
697fb05c58
vim-patch:8.0.0608: cannot manipulate other than the current quickfix list
...
Problem: Cannot manipulate other than the current quickfix list.
Solution: Pass the list index to quickfix functions. (Yegappan Lakshmanan)
a3921f48c6
2017-12-30 01:34:08 -05:00
Daniel Hahler
5dd2ca767f
use snprintf and has_event
2017-12-29 20:52:56 +01:00
Daniel Hahler
e84e1b68c1
Move applying of TabClosed to win_close_othertab
2017-12-29 20:38:17 +01:00
Daniel Hahler
2c436b3362
Fix TabClose autocommand via close_windows
...
Fixes https://github.com/neovim/neovim/issues/7781
2017-12-29 16:56:14 +01:00
Justin M. Keyes
ddcfb49262
Merge #7755
2017-12-28 22:48:49 +01:00
Justin M. Keyes
ac2f90f2e1
version.c: update
2017-12-27 12:30:55 +01:00
Justin M. Keyes
fe60fa9faa
doc
...
vim-patch:8.0.1206: no autocmd for entering or leaving the command line
(commit a4f6cec7a3 )
NA patches:
vim-patch:8.0.0320: warning for unused variable with small build
2017-12-26 03:58:28 +01:00
ZyX
b6ee90a243
eval: Refactor some potentially dangerous list appends
2017-12-25 01:44:44 +03:00
ZyX
6ab5eb347b
eval: Remove magic numbers from find_some_match() type argument
2017-12-25 01:08:58 +03:00
ZyX
bc52ec6110
*: Fix linter errors
2017-12-24 23:09:26 +03:00
ZyX
7997147245
eval: Replace some tv_list_item_remove() calls
...
There is nothing wrong with them, just it is generally better to remove
a range then to remove items individually.
2017-12-24 17:52:24 +03:00
ZyX
67fa9e5237
eval: Rename tv_list_remove_items() to tv_list_drop_items()
...
tv_list_remove_items() may cause confusion with tv_list_item_remove()
2017-12-24 16:38:30 +03:00
ZyX
ac55558c97
eval/typval: Make tv_list_item_remove return pointer to the next item
2017-12-24 14:09:36 +03:00
ZyX
608c3d7baf
eval/typval: Remove tv_list_item_free() as it is unused
2017-12-24 14:09:36 +03:00
ZyX
6bf3dc77c4
eval/typval: Make tv_list_item_alloc static
...
Better write this bit in lua then make reviewers or clint filter out
tv_list_item_alloc().
2017-12-24 14:09:36 +03:00
ZyX
0c533a488f
*: Remove most calls to tv_list_item_alloc
...
Still left calls in eval/typval.c and test/unit/eval/helpers.lua. Latter is the
only reason why function did not receive `static` modifier.
2017-12-24 14:09:35 +03:00
ZyX
6b45dbca04
mark: Make sure that jumplist item will not have zero lnum
...
Fixes #7169
2017-12-24 00:32:43 +03:00
Justin M. Keyes
dee78a4095
Merge #7708 from ZyX-I/hide-container-impl
2017-12-23 18:17:01 +01:00
Björn Linse
308dd53783
channel: check for existance before trying to set key
...
This avoids an error message in async context, where it is not safe.
2017-12-23 14:02:00 +01:00
ZyX
5cb7a709e7
clint: Make linter report line where it found opening brace
2017-12-23 15:47:23 +03:00
ZyX
d2c01d529f
regexp: Fix linter errors
2017-12-23 15:47:04 +03:00
ZyX
c9ab209f9e
Merge branch 'master' into hide-container-impl
2017-12-23 15:27:42 +03:00
ckelsel
eb95b88156
vim-patch:8.0.0315: :help :[range] does not work
...
Problem: ":help :[range]" does not work. (Tony Mechelynck)
Solution: Translate to insert a backslash.
a76f59d817
2017-12-21 18:55:56 +08:00
ckelsel
6c731d33f6
vim-patch:8.0.0314: getcmd*() functions are not tested
...
Problem: getcmdtype(), getcmdpos() and getcmdline() are not tested.
Solution: Add tests. (Yegappan Lakshmanan)
65189a1294
2017-12-21 18:40:10 +08:00
James McCoy
190814bdae
vim-patch:8.0.0606: cannot set the context for a specified quickfix list
...
Problem: Cannot set the context for a specified quickfix list.
Solution: Use the list index instead of the current list. (Yegappan
Lakshmanan)
6e62da3e14
2017-12-19 14:07:24 -05:00
James McCoy
cdd86f42cf
vim-patch:8.0.0597: off-by-one error in size computation
...
Problem: Off-by-one error in buffer size computation.
Solution: Use ">=" instead of ">". (Lemonboy, closes vim/vim#1694 )
253f912877
2017-12-19 14:07:24 -05:00
James McCoy
6fcadab3ce
vim-patch:8.0.0595: Coverity warning for not checking return value
...
Problem: Coverity warning for not checking return value of dict_add().
Solution: Check the return value for FAIL.
beb9cb19c6
2017-12-19 14:07:24 -05:00
James McCoy
20708a07bf
vim-patch:8.0.0590: cannot add a context to locations
...
Problem: Cannot add a context to locations.
Solution: Add the "context" entry in location entries. (Yegappan Lakshmanan,
closes vim/vim#1012 )
8f77c5a4ec
2017-12-19 14:07:24 -05:00
James McCoy
4d2d844c12
vim-patch:8.0.0580: cannot set the valid flag with setqflist()
...
Problem: Cannot set the valid flag with setqflist().
Solution: Add the "valid" argument. (Yegappan Lakshmanan, closes vim/vim#1642 )
f1d21c8cc8
2017-12-18 21:44:42 -05:00
James McCoy
9fb7926a0d
vim-patch:8.0.0579: duplicate test case for quickfix
...
Problem: Duplicate test case for quickfix.
Solution: Remove the function. (Yegappan Lakshmanan)
9b77016545
2017-12-18 21:40:24 -05:00
James McCoy
dd27392861
vim-patch:8.0.0574: get only one quickfix list after :caddbuf
...
Problem: Get only one quickfix list after :caddbuf.
Solution: Reset qf_multiline. (Yegappan Lakshmanan)
99895eac1c
2017-12-18 21:39:51 -05:00
James McCoy
1b2d386a85
vim-patch:8.0.0565: using freed memory in :caddbuf
...
Problem: Using freed memory in :caddbuf after clearing quickfix list.
(Dominique Pelle)
Solution: Set qf_last to NULL.
31bdd13c33
2017-12-18 21:36:44 -05:00
James McCoy
765ff94b5b
vim-patch:8.0.0584: memory leak when executing quickfix tests
...
Problem: Memory leak when executing quickfix tests.
Solution: Free the list reference. (Yegappan Lakshmanan)
d788f6fe89
2017-12-18 14:57:57 -05:00
James McCoy
f0bd2bc39a
vim-patch:8.0.0536: quickfix window not updated when freeing quickfix stack
...
Problem: Quickfix window not updated when freeing quickfix stack.
Solution: Update the quickfix window. (Yegappan Lakshmanan)
69f40be645
2017-12-18 14:56:17 -05:00
James McCoy
fb8592b7ba
vim-patch:8.0.0517: there is no way to remove quickfix lists
...
Problem: There is no way to remove quickfix lists (for testing).
Solution: Add the 'f' action to setqflist(). Add tests. (Yegappan
Lakshmanan)
b6fa30ccc3
2017-12-18 14:35:55 -05:00
James McCoy
8536348813
vim-patch:8.0.0484: :lhelpgrep does not fail after a successful one
...
Problem: Using :lhelpgrep with an argument that should fail does not
produce an error if the previous :helpgrep worked.
Solution: Use another way to detect that autocommands made the quickfix info
invalid. (Yegappan Lakshmanan)
ee85df3763
2017-12-17 21:05:20 -05:00
James McCoy
ccbf14322a
vim-patch:8.0.0404: not enough testing for quickfix
...
Problem: Not enough testing for quickfix.
Solution: Add some more tests. (Yegappan Lakshmanan)
391b1dd040
2017-12-17 20:55:50 -05:00
James McCoy
e6f8b105b0
Merge pull request #7736 from jamessan/vim-8.0.0420
...
[RFC] vim-patch:8.0.0420: text garbled when the system encoding differs from 'encoding'
2017-12-17 20:15:12 -05:00