Problem: Several errors are not tested for.
Solution: Add tests. (Yegappan Lakshmanan, closesvim/vim#5892)
ee4e0c1e9a
Omit Test_range() change: reverted in patch 8.2.0615.
Cherry-pick Test_z_no_space_before_xxx() from patch 8.2.0195.
Cherry-pick Test_reverse_sort_uniq() change from patch 8.2.0183.
Make uniq() error behavior consistent with sort().
Cherry-pick Test_set_ttytype() change from patch 8.1.1826.
Cherry-pick quickfix checks from patch 8.1.2373 to test_preview.vim.
Test_viminfo_error() is applicable.
Cherry-pick E1058 from patch 8.2.0149 and port Test_deep_nest() to Lua.
Problem: Some tests fail on Mac.
Solution: Avoid Mac test failures. Add additional test for wildmenu.
(Yegappan Lakshmanan, closesvim/vim#7341)
4b2ce1297e
Problem: various code is not properly tested.
Solution: Add more tests. (Yegappan Lakshmanan, closesvim/vim#5871)
cde0ff39da
Cherry-pick test_clientserver.vim change from patch 8.1.1826.
Cherry-pick a comment from patch 8.2.0301.
Omit test_viminfo.vim.
Problem: Not enough testing for movement commands.
Solution: Add more tests. (Yegappan Lakshmanan, closesvim/vim#6313)
bdd2c290d3
Cherry-pick test_functions.vim changes from patch 8.2.0183.
Cherry-pick Test_normal18_z_fold() change from patch 8.2.0540.
Problem: When 'buftype' is "nofile" there is no overwrite check.
Solution: Also check for existing file when 'buftype' is set.
(closesvim/vim#5807)
a3a9c8ef69
Nvim doesn't have buftype=popup and doesn't allow buftype=terminal for
non-terminal buffer.
Problem: Some errors were not tested for.
Solution: Add tests. (Dominique Pelle, closesvim/vim#5824)
9b9be007e7
Cherry-pick get_highest_fnum() from patch 8.1.1908 to make tests pass.
Problem: Ex_getln.c code not covered by tests.
Solution: Add a few more tests. (Yegappan Lakshmanan, closesvim/vim#5702)
578fe947e3
Cherry-pick Test_Ex_global() from patch 8.2.0293.
Test_rightleftcmd() fails if incsearch is enabled, so disable it.
Problem: Command line completion not fully tested.
Solution: Add more test cases. Make help sorting stable. (Dominique Pelle,
closesvim/vim#5402)
297610ba4b
Problem: Not all modifiers supported for :options.
Solution: Use all cmdmod.split flags. (closesvim/vim#4401)
7a1637f4c0
Cherry-pick Test_options_command() change from patch 8.2.0540
Problem: Changing 'switchbuf' may have no effect.
Solution: Handle 'switchbuf' in didset_string_options(). (Sean Dewar,
closesvim/vim#10406)
39c46b4378
Guess it doesn't hurt to cherry-pick didset_string_options from v8.1.2045
(but in option.c, for now).
Problem: maparg() may return a string that cannot be reused.
Solution: use msg_outtrans_special() instead of str2special().
(closesvim/vim#10384)
0519ce0039
Problem: Wrong 'statusline' value can cause illegal memory access.
Solution: Properly check the value. (closesvim/vim#10192)
5dc294a7b6
Make two error messages static variables.
Problem: Option context is not copied when splitting a window. (Daniel
Hahler)
Solution: Copy the option context, so that ":verbose set" works.
(closesvim/vim#5066)
cfb381421f
vim-patch:8.2.3804: script context not set when copying 'swf' and 'ts'
Problem: Script context not set when copying 'swf' and 'ts'.
Solution: Use COPY_OPT_SCTX with the right argument. (closesvim/vim#9347)
6206877c51
Problem: Test files still use function!.
Solution: Remove the exclamation mark. Fix overwriting a function.
1e1153600c
Some of the changes were already applied previously.
Problem: ":retab 0" may cause illegal memory access.
Solution: Limit the value of 'tabstop' to 10000.
652dee4486
ex_retab change is N/A (+vartabs always available).
Nvim's set_num_option validation logic was refactored, hence why it looks
different from Vim's.
Also use XFREE_CLEAR in other places.
We should now be equal with Vim in regards to method call support of already ported built-ins.
Enable all relevant commented-out uses of the syntax in tests that I could grep.
Problem: The initial value of 'backupskip' can have duplicate items.
Solution: Remove duplicates, like when it is set later. (Tom Ryder,
closesvim/vim#6940)
b00ef0508b
Problem: "verbose hi Name" reports incorrect info after ":hi clear".
Solution: Store the script context. (Antony Scriven, closesvim/vim#6975)
e8df010498
Also adds src/nvim/testdir/script_util.vim which originates from patch 8.2.1366
(a6296200bd)
because some tests in test_highlight.vim use it for testing :verbose.
Should merge this and older related patches later.
Also, fix collateral damage to test_options.vim
test_options tests for file name completion in the test directory, but
since we've added a new file, the test output is now different. This
test is slightly different from upstream anyway, so for now we just add
the file name. This may change when more upstream patches are added
which alter this test.
Problem: Setting 'winminheight' may cause 'lines' to change.
Solution: Also take minimal height of other tabpages into account. (vim/vim#7899)
9e813b3dea
Problem: 'scroll' option can change when setting the statusline or tabline
but the option context is not updated.
Solution: Update the script context when the scroll option is changed as a
side effect. (Christian Brabandt, closesvim/vim#7533)
746670604a
Problem: Setting 'winminheigt' does not take tabline into account.
Solution: Subtract the tabline from the available height. (closesvim/vim#7899)
39d4cab494
N/A patches for version.c:
vim-patch:8.1.0680: not easy to see what features are unavailable
Problem: Not easy to see what features are unavailable.
Solution: Highlight disabled features in the :version output. (Nazri Ramliy,
closesvim/vim#3756)
c85ffc9dab
vim-patch:8.2.2196: :version output has extra spaces in compile and link command
Problem: :version output has extra spaces in compile and link command.
Solution: Adjust QUOTESED. (closesvim/vim#7505)
abcbb0e9ad
vim-patch:8.2.2551: MS-Windows: colors test file is not installed
Problem: MS-Windows: colors test file is not installed.
Solution: Also copy runtime/colors/tools. (Ken Takata, closesvim/vim#7902)
d0bce504ec
vim-patch:8.2.2559: MS-Windows: guifont test fails on Windows XP
Problem: MS-Windows: guifont test fails on Windows XP.
Solution: Check windowsversion().
3650fd7098
Problem: Setting 'term' empty has different error if compiled with GUI.
Solution: Insert "else". (closesvim/vim#7766)
5daa911626
N/A patches for version.c:
vim-patch:8.2.2437: deprecation warnings with default configuration
Problem: Deprecation warnings with default configuration.
Solution: Add -Wno-deprecated-declarations.
4d8479b335
vim-patch:8.2.2439: not easy to figure out what packages to get
Problem: Not easy to figure out what packages to get when installing Vim on
a new Ubuntu system.
Solution: Mention explicit commands that are easy to follow.
3d2bb8b6f1
vim-patch:8.2.2442: automatic GUI selection does not check for GTK 3
Problem: Automatic GUI selection does not check for GTK 3.
Solution: Make SKIP_GTK3 empty for automatic GUI support. Set SKIP_GTK3 to
YES when checking for GTK2.
f272ae12ac
vim-patch:8.2.2448: compilation error with Ruby 3.0
Problem: Compilation error with Ruby 3.0.
Solution: Adjust #ifdefs and declaration. (Ken Takata, closesvim/vim#7761)
9d20daffc2
Problem: Insufficient tests for setting options.
Solution: Add a few tests. (Dominique Pellé, closesvim/vim#7695)
85773bf32b
Cherry-pick some test cases for Test_set_error()
from patches v8.2.0540, v8.2.0551.
Problem: Number of status line items is limited to 80.
Solution: Dynamically allocate the arrays. (Rom Grk, closesvim/vim#7181)
8133cc6bf4
The members of stl_item_T have not been prefixed with stl_ contrary to
the vim patch because the amount of stl_ prefixes on single lines of
code in that region was hurtful to readability.
Problem: Backslash not removed afer space in option with space in
'isfname'.
Solution: Do remove backslash before space, also when it is in 'isfname'.
(Yasuhiro Matsumoto, closesvim/vim#6651)
994b89d28d
Problem: Setting a boolean option to v:false does not work.
Solution: Do not use the string representation of the value. (Christian
Brabandt, closesvim/vim#5974)
65d032c779
Problem: Error when appending "tagfile" to 'wildoptions'.
Solution: use flags P_ONECOMMA and P_NODUP. (Dmitri Vereshchagin,
closesvim/vim#6105)
2e61e2d083
Problem: Setting 'term' does not store location for termcap options.
Solution: Set the script context for termcap options that are changed when
'term' is set.
35bc7d6c52
Problem: When buffer is hidden "F" in 'shortmess' is not used.
Solution: Check the "F" flag in 'shortmess' when the buffer is already
loaded. (Jason Franklin) Add test_getvalue() to be able to test
this.
eda652215a
test_getvalue() is not implemented.
It is only used for checking "need_fileinfo" internal variable.