Commit Graph
14532 Commits
Author SHA1 Message Date
zeertzjq a9452cf3d5 vim-patch:9.0.0616: spell test fails because error message changed
Problem:    Spell test fails because error message changed.
Solution:   Adjust expected error message.
https://github.com/vim/vim/commit/371951d0c34d4f44b50ad8bc8d30a4ef7effade6
2022-10-15 16:28:36 +08:00
zeertzjq 6bc2d6b66b vim-patch:9.0.0614: SpellFileMissing autocmd may delete buffer
Problem:    SpellFileMissing autocmd may delete buffer.
Solution:   Disallow deleting the current buffer to avoid using freed memory.
https://github.com/vim/vim/commit/ef976323e770315b5fca544efb6b2faa25674d15
2022-10-15 16:28:36 +08:00
zeertzjq 65cbe0cc35 vim-patch:8.1.0342: crash when a callback deletes a window that is being used
Problem:    Crash when a callback deletes a window that is being used.
Solution:   Do not unload a buffer that is being displayed while redrawing the
            screen. Also avoid invoking callbacks while redrawing.
            (closes vim/vim#2107)
https://github.com/vim/vim/commit/94f01956a583223dafe24135489d0ab1100ab0ad

Omit parse_queued_messages(): N/A.
Cherry-pick a break statement from patch 8.1.0425.
2022-10-15 16:28:31 +08:00
Christian Clason e26b48bde6 vim-patch:9.0.0752: Rprofile files are not recognized (#20658)
Problem:    Rprofile files are not recognized.
Solution:   Recognize Rprofile files as "r". (closes vim/vim#11369)
https://github.com/vim/vim/commit/7e120ffccbf81ae8acac28f11fbd5eab79a1630d
2022-10-15 10:12:25 +02:00
zeertzjq 1c478391ca vim-patch:9.0.0750: crash when popup closed in callback (#20659)
Problem:    Crash when popup closed in callback. (Maxim Kim)
Solution:   In syntax_end_parsing() check that syn_block is valid.
https://github.com/vim/vim/commit/0abd6cf62d65180dc2c40d67cd95f13b0691f7ea
2022-10-15 07:24:03 +08:00
Lewis Russell cb7da02701 Merge pull request #20645 from lewis6991/fix/decor_redraw_same_id
fix(decoration): redraw correctly when re-using ids
2022-10-14 20:46:26 +01:00
zeertzjq e6f7e038b8 fix(completion): set pum_size even if ext_popupmenu is used (#20648)
This allows CompleteChanged event to get the correct `v:event.size`.
It should be harmless and more consistent to also set `pum_array`.
2022-10-14 23:08:00 +08:00
Justin M. Keyes e5cb3104d0 docs: fix/remove invalid URLs #20647 2022-10-14 08:01:13 -07:00
Lewis Russell 546b294e74 fix(decoration): redraw correctly when re-using ids
00cfc1d (from #20249) reduced the amount of unnecessary redraws. This
surfaced an issue where if and extmark with a specific ID is
repositioned to a different row, the decorations from the old row were
not redrawn and removed. This change fixes that by redrawing the
old row.
2022-10-14 13:03:03 +01:00
Lewis Russell 9931db2e3f Merge pull request #20545 from lewis6991/remove_cscope 2022-10-14 09:53:15 +01:00
zeertzjq 0578c67767 vim-patch:9.0.0747: too many #ifdefs (#20641)
Problem:    Too many #ifdefs.
Solution:   Gradudate the +cmdline_info feature. (Martin Tournoij,
            closes vim/vim#11330)
https://github.com/vim/vim/commit/ba43e76fcd5b2da57dbaa4d9a555793fe8ac344e
2022-10-14 07:29:58 +08:00
Lewis Russell 7f11dfdef8 refactor(tag): remove return type from do_tag() 2022-10-13 16:37:24 +01:00
Lewis Russell 288208257c feat(cscope)!: remove 2022-10-13 16:37:23 +01:00
dundargocandzeertzjq eb123b565e docs: fix typos (#20509)
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2022-10-13 21:18:48 +08:00
Enan Ajmain 730228f6db feat(windows): show icon in terminal titlebar, taskbar #20607
closes #20071
2022-10-13 05:48:12 -07:00
zeertzjq 06dfedc87a vim-patch:9.0.0738: cannot suppress completion "scanning" messages (#20633)
Problem:    Cannot suppress completion "scanning" messages.
Solution:   Add the "C" flag in 'shortmess'. (Bjorn Linse, closes vim/vim#11354)
https://github.com/vim/vim/commit/91ccbad5ded8bcf2cc93a873ff2c3179b0c548c7
2022-10-13 20:46:23 +08:00
zeertzjq 4fbf41dfb4 vim-patch:8.2.4735: quickfix tests can be a bit hard to read (#20631)
Problem:    Quickfix tests can be a bit hard to read.
Solution:   Use heredoc instead of strings and line continuation. (Yegappan
            Lakshmanan, closes vim/vim#10145)
https://github.com/vim/vim/commit/4a7724a4406f639edd3f93f3542626811cf56719

Cherry-pick a typo fix from patch 8.2.3637.
2022-10-13 14:31:10 +08:00
zeertzjq f72ae4514c vim-patch:9.0.0286: using freed memory when location list changed in autocmd
Problem:    Using freed memory when location list changed in autocmd.
Solution:   Return QF_ABORT and handle it. (Yegappan Lakshmanan,
            closes vim/vim#10993)
https://github.com/vim/vim/commit/6d24a51b94beb1991cddce221f90b455e2d50db7
2022-10-13 11:47:59 +08:00
zeertzjq 5740b3e076 vim-patch:9.0.0260: using freed memory when using 'quickfixtextfunc' recursively
Problem:    Using freed memory when using 'quickfixtextfunc' recursively.
Solution:   Do not allow for recursion.
https://github.com/vim/vim/commit/d6c67629ed05aae436164eec474832daf8ba7420

Cherry-pick Test_qflist_statusmsg() from patch 8.2.4617.
2022-10-13 11:47:59 +08:00
zeertzjq cd1e0bb87d vim-patch:8.2.4462: not enough testing for quickfix code
Problem:    Not enough testing for quickfix code.
Solution:   Add more tests. Fix uncovered problem. (Yegappan Lakshmanan,
            closes vim/vim#9839)
https://github.com/vim/vim/commit/9c9be05b17ececb1515a2f41a4dedbf848d3d8b6

Omit Test_helpgrep_vim9_restore_cpo().
Cherry-pick test_quickfix.vim change from patch 8.2.0644.
2022-10-13 10:20:42 +08:00
zeertzjq 73bdfdd382 vim-patch:8.2.4453: :helpgrep may free an option that was not allocated
Problem:    :helpgrep may free an option that was not allocated. (Yegappan
            Lakshmanan)
Solution:   Check if the value was allocated.
https://github.com/vim/vim/commit/4791fcd82565adcc60b86830e0bb6cd5b6eea0a6
2022-10-13 10:09:09 +08:00
Lewis Russell 0ef6aaa3a7 refactor: clint (#20600) 2022-10-12 14:53:40 +01:00
Lewis Russell 024f6880b5 fix(clint): disable whitespace/newline #20619
This rule is already mostly covered by uncrustify.
2022-10-12 06:31:32 -07:00
Christian Clason 4f305fba14 vim-patch:9.0.0731: clang-tidy configuration files are not recognized (#20620)
Problem:    clang-tidy configuration files are not recognized.
Solution:   Recognize clang-tidy files as yaml. (closes vim/vim#11350)
https://github.com/vim/vim/commit/af40f9af335e0c8b167eac31ceace45b6a2e0565
2022-10-12 15:23:42 +02:00
Lewis Russell eeeb6c80d8 refactor(search.c): clint (#20598) 2022-10-12 10:59:06 +01:00
zeertzjq 3b562535c3 vim-patch:8.2.4523: when gvim is started maximized the 'window' option isn't set
Problem:    When gvim is started maximized the 'window' option isn't set
            properly. (Christian J. Robinson)
Solution:   Check if 'windows' was already set or not. (Ken Takata,
            closes vim/vim#9904)
https://github.com/vim/vim/commit/6ca883dd8a585a85acdf9303b434211ea91872a7
2022-10-12 07:48:25 +08:00
Lewis Russell 6e11db2301 refactor/mark.c (#20596) 2022-10-11 16:15:44 +01:00
Wei Tang 63ab3337e0 refactor: explicitly convert HANDLE to intptr_t for _open_osfhandle()
Problem:
The first parameter of "_open_osfhandle()" is an intptr_t; however, a HANDLE is passed.
The official documentation of [_open_osfhandle](https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/open-osfhandle) suggests to cast the HANDLE to intptr_t.
MSVC/cl is able to perform an implicit type cast.
However, LLVM/clang-cl will generate an compilation error.

Solution:
Explicitly convert HANDLE to intptr_t for _open_osfhandle().
2022-10-11 10:58:11 +08:00
zeertzjq 62a0c9f8c2 vim-patch:partial:9.0.0715: wrong argument for append() gives two error messages
Problem:    Wrong argument for append() gives two error messages.
Solution:   When getting an error for a number argument don't try using it as
            a string. (closes vim/vim#11335)
https://github.com/vim/vim/commit/801cd35e7e3b21e519e12a1610ee1d721e40893e

Skip test as it depends on too many previous patches.
2022-10-10 23:54:51 +08:00
zeertzjq 2cc64dca92 fix: change did_emsg back to int 2022-10-10 23:54:51 +08:00
zeertzjq 249cb8345d vim-patch:9.0.0712: wrong column when calling setcursorcharpos() with zero lnum
Problem:    Wrong column when calling setcursorcharpos() with zero lnum.
Solution:   Set the line number before calling buf_charidx_to_byteidx().
            (closes vim/vim#11329)
https://github.com/vim/vim/commit/79f234499b6692cc16970b7455bc9b002242632f
2022-10-10 23:54:51 +08:00
zeertzjq 5c9f6bdd8c vim-patch:8.2.2671: error for line number in legacy script
Problem:    Error for line number in legacy script.
Solution:   Check for number type.
https://github.com/vim/vim/commit/f6bdd82c7e2076dbacb764a5d288189d61c68451

N/A patches for version.c:

vim-patch:8.2.2670: Vim9: error for append(0, text)

Problem:    Vim9: error for append(0, text).
Solution:   Check for negative number. (closes vim/vim#8022)
https://github.com/vim/vim/commit/b2ac7d0663ef31a335c50c6afca042ed9ace5059
2022-10-10 23:54:51 +08:00
zeertzjq 9c272b75ec vim-patch:8.2.2184: Vim9: no error when using "2" for a line number
Problem:    Vim9: no error when using "2" for a line number.
Solution:   Give an error message if the line number is invalid. (closes vim/vim#7492)
https://github.com/vim/vim/commit/9a963377b4811e4e0419ec8825856ff4b01331ac

N/A patches for version.c:

vim-patch:8.2.1465: Vim9: subscript not handled properly

Problem:    Vim9: subscript not handled properly.
Solution:   Adjust error message.  Remove dead code.  Disallow string to
            number conversion in scripts.
https://github.com/vim/vim/commit/56acb0943ede35cd9d2f6667cde2442819ccbf59
2022-10-10 23:54:51 +08:00
Christian Clason 8781213f00 vim-patch:9.0.0711: SubStation Alpha files are not recognized (#20577)
Problem:    SubStation Alpha files are not recognized.
Solution:   Add patterns for SubStation Alpha files. (closes vim/vim#11332)
https://github.com/vim/vim/commit/084f2620ec7d08d6043de30436197c002fffe3ec
2022-10-10 17:51:31 +02:00
zeertzjq 81058119df vim-patch:9.0.0713: <amatch> of MenuPopup event is expanded like a file name (#20572)
Problem:    <amatch> of MenuPopup event is expanded like a file name.
Solution:   Do not expand <amatch> for MenuPopup. (closes vim/vim#11328)
https://github.com/vim/vim/commit/c601d988b6b1a672f71e3d61f4aaa4f7742a3a21
2022-10-10 21:26:18 +08:00
zeertzjq d4e749f1b2 vim-patch:9.0.0700: there is no real need for a "big" build (#20563)
Problem:    There is no real need for a "big" build.
Solution:   Move common features to "normal" build, less often used features
            to the "huge" build. (Martin Tournoij, closes vim/vim#11283)
https://github.com/vim/vim/commit/25f3a146a0e4c731b8608f4cfbbfdf7a71b2d05e
2022-10-10 11:34:53 +08:00
RZiaandzeertzjq a5597d1fc0 fix(lua): assert failure with vim.regex() error inside :silent! (#20555)
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2022-10-10 08:04:08 +08:00
zeertzjq 3010469562 vim-patch:9.0.0706: :help in a narrow window always opens at the top (#20559)
Problem:    :help in a narrow window always opens at the top.
Solution:   Respect 'splitbelow'. (closes vim/vim#11319)
https://github.com/vim/vim/commit/28f7e701b7857cfc5ab5531ee7ac26e2542ad662
2022-10-10 07:16:15 +08:00
Justin M. KeyesandBen Weedon 09dffb9db7 docs: various #12823
- increase python line-length limit from 88 => 100.
- gen_help_html: fix bug in "tag" case (tbl_count => tbl_contains)

ref #15632
fix #18215
fix #18479
fix #20527
fix #20532

Co-authored-by: Ben Weedon <ben@weedon.email>
2022-10-09 05:21:52 -07:00
zeertzjq 7cdaa74b36 vim-patch:9.0.0702: incomplete testing cursor position with 'linebreak' set
Problem:    Incomplete testing cursor position after change with 'linebreak'
            set.
Solution:   Add a test and move test cases together. (closes vim/vim#11313)
https://github.com/vim/vim/commit/30c0c467d6cc2a7af960ccb9002b50115b0e55cf
2022-10-09 19:09:32 +08:00
zeertzjq c93fd83df2 vim-patch:9.0.0697: cursor in wrong position with Visual substitute
Problem:    Cursor in wrong position with Visual substitute.
Solution:   When restoring 'linebreak' mark the virtual column as invalid.
            (closes vim/vim#11309, closes vim/vim#11311)
https://github.com/vim/vim/commit/16dab41537ae206f4cab676ad53edbae5fd5fb45

N/A patches for version.c:

vim-patch:9.0.0699: tiny build fails

Problem:    Tiny build fails.
Solution:   Add #ifdef.
https://github.com/vim/vim/commit/bf499c0e6f30a94fe062f83ea0190f93178d0d74
2022-10-09 18:58:30 +08:00
dundargoc c422046e43 build: generate compilation database for older cmake versions
Fall back to the older method of setting CMAKE_EXPORT_COMPILE_COMMANDS
for cmake versions less than 3.20. This isn't recommended as it's not
possible to exclude targets from generating a compilation database,
which may cause some tools like clang-tidy to do unnecessary work. But
having an unoptimized compilation database is still useful enough that
it's worth having.
2022-10-09 11:44:47 +02:00
Lewis Russell edc8a1f046 Merge pull request #20544 from lewis6991/exitfreedebug
build: remove EXITFREE for debug builds
2022-10-08 18:06:43 +01:00
ObserverOfTime b05e10ef72 vim-patch:9.0.0692: PoE filter files are not recognized (#20542)
Problem:    PoE filter files are not recognized.
Solution:   Add a pattern to detect PoE filter files. (closes vim/vim#11305)
https://github.com/vim/vim/commit/b7f52f5659c68b61ccc645ef866f8fd82361cd26
2022-10-08 17:46:31 +02:00
Lewis Russell 1d4840a13a build: remove EXITFREE for debug builds
When EXITFREE is defined, uv handles are not closed on exit in order to
better detect memory leaks. However the cost of this is that by not
closing the handles there can be lag when exiting nvim.

This change removes EXITFREE from debug builds in order to avoid this
exit lag for regular debug builders who are not running ASAN.
2022-10-08 16:06:32 +01:00
zeertzjq fad1022caf fix(tui): resume main thread if suspending isn't implemented (#20523)
Not doing anything is better than hanging.
2022-10-08 20:17:53 +08:00
zeertzjq 2a12faaec1 fix(api): dynamically allocate line buffer for nvim_out_write (#20537) 2022-10-08 20:10:00 +08:00
zeertzjq cfdb4cbada fix: find multibyte file name in line (#20519)
And remove unnecessary unsigned casts in fold marker comparison.
2022-10-07 09:43:16 +08:00
zeertzjq d191070913 fix(ui): setting 'cmdheight' with global statusline (#20515) 2022-10-07 08:52:51 +08:00
zeertzjq bcef006da6 vim-patch:9.0.0678: using exclamation marks on :function (#20518)
Problem:    Using exclamation marks on :function.
Solution:   Use :func and :endfunc as usual.
https://github.com/vim/vim/commit/97f0eb169bf805c372b13c6bc9a03da2e75e3354

Add a missing change from patch 8.1.1875.
2022-10-07 07:06:38 +08:00