Justin M. Keyes
ae846b41df
vim-patch:8.0.1496: VIM_CLEAR()
...
Problem: Clearing a pointer takes two lines.
Solution: Add VIM_CLEAR() and replace vim_clear(). (Hirohito Higashi,
closes #2629 )
vim-patch:8.0.1481
2019-05-25 10:07:05 +02:00
Jan Edmund Lazo
49b0d41c3c
vim-patch:8.1.1249: compiler warning for uninitialized variable
...
Problem: Compiler warning for uninitialized variable.
Solution: Initialize it. (Christian Brabandt)
c6b1cc967f
2019-05-03 23:15:06 -04:00
Jan Edmund Lazo
2af1e23278
vim-patch:8.1.0170: invalid memory use with complicated pattern #9724
...
Problem: Invalid memory use with complicated pattern. (Andy Massimino)
Solution: Reallocate the list of listids when needed. (closes vim/vim#3175 )
Remove unnecessary function prototypes.
2338c32b53
2019-03-13 03:16:22 +01:00
Justin M. Keyes
4352d41db0
Merge #9662 'vim-patch:8.0.{0643-0646}'
2019-03-08 13:21:11 +01:00
Billy Su
96e2c3945f
lint: fix coding style
2019-03-08 00:08:16 +08:00
Billy Su
fbd8209286
vim-patch:8.0.0645: no error for illegal back reference in NFA engine
...
Problem: The new regexp engine does not give an error for using a back
reference where it is not allowed. (Dominique Pelle)
Solution: Check the back reference like the old engine. (closes vim/vim#1774 )
1ef9bbe215
2019-03-07 23:48:53 +08:00
Billy Su
241b905b13
vim-patch:8.0.0643: when a pattern search is slow Vim becomes unusable
...
Problem: When 'hlsearch' is set and matching with the last search pattern
is very slow, Vim becomes unusable. Cannot quit search by
pressing CTRL-C.
Solution: When the search times out set a flag and don't try again. Check
for timeout and CTRL-C in NFA loop that adds states.
fbd0b0af68
2019-03-07 23:27:19 +08:00
Justin M. Keyes
e116b0f61f
vim-patch:8.1.0973: pattern with syntax error gives threee error messages
...
Problem: Pattern with syntax error gives threee error messages. (Kuang-che
Wu)
Solution: Remove outdated internal error. Don't fall back to other engine
after an error.
cd62512c55
2019-03-01 01:56:17 +01:00
Justin M. Keyes
b183534c81
vim-patch:8.1.0968: crash when using search pattern \%Ufffffc23
...
Problem: Crash when using search pattern \%Ufffffc23.
Solution: Limit character to INT_MAX. (closes vim/vim#4009 )
527a2d86fb
2019-03-01 01:56:17 +01:00
Jan Edmund Lazo
d8b4fb7838
lint
2019-02-17 19:14:40 -05:00
Jan Edmund Lazo
55821948cf
vim-patch:8.1.0945: internal error when using pattern with NL in the range
...
Problem: Internal error when using pattern with NL in the range.
Solution: Use an actual newline for the range. (closes vim/vim#3989 ) Also fix
error message. (Dominique Pelle)
a5483448cb
2019-02-17 19:11:16 -05:00
Justin M. Keyes
5a752c97d5
vim-patch:8.1.0098: segfault when pattern with \z() is very slow ( #9283 )
...
Problem: Segfault when pattern with \z() is very slow.
Solution: Check for NULL regprog. Add "nfa_fail" to test_override() to be
able to test this. Fix that 'searchhl' resets called_emsg.
bcf9442307
closes #8788
2018-11-29 01:51:26 +01:00
MichaHoffmann
2c84421de2
src/nvim/eval.c
...
src/nvim/eval/typval.c
src/nvim/fileio.c
src/nvim/main.c
src/nvim/regexp_nfa.c
src/nvim/spellfile.c
changed some EMSG[..] Macros to emsgf
2018-10-07 12:24:29 +02:00
MichaHoffmann
8cb04c2230
fixed lint errors
2018-09-24 22:05:01 +02:00
MichaHoffmann
affef0aab8
add func_attr_printf in :
...
log.c
message.c
strings.c
fixed some printf warnings in:
src/nvim/undo.c
src/nvim/eval.c
src/nvim/eval/encode.c
src/nvim/eval/typval.c
src/nvim/ex_getln.c
src/nvim/fileio.c
src/nvim/lua/executor.c
src/nvim/main.c
src/nvim/regexp_nfa.c
src/nvim/shada.c
src/nvim/spellfile.c
src/nvim/tui/terminfo.c
src/nvim/garray.h
2018-09-24 21:28:04 +02:00
Jan Edmund Lazo
01b2fa53f4
lint
2018-09-21 00:05:06 -04:00
Jan Edmund Lazo
300a7a4cf4
replace fallthrough comment with macro
...
Follow-up of vim-patch:8.0.1215
2018-09-21 00:05:06 -04:00
Jan Edmund Lazo
6a329b0548
vim-patch:8.0.1215: newer gcc warns for implicit fallthrough
...
Problem: Newer gcc warns for implicit fallthrough.
Solution: Consistently use a FALLTHROUGH comment. (Christian Brabandt)
2f40d129bf
2018-09-20 06:59:04 -04:00
ZviRackover
ac13e65ae0
Remove has_mbytes local to lines changed in parent commit
2018-09-09 10:45:50 +03:00
ZviRackover
cbdbc4f63d
Refactor: Remove occurences of mb_char2bytes
2018-09-09 10:45:50 +03:00
ZviRackover
d110c6d790
lint: cleanup after parent commits
2018-08-16 07:39:48 +03:00
ZviRackover
30392b6356
Remove has_mbyte from lines near changes in parent commit
2018-08-16 06:03:49 +03:00
ZviRackover
2bddc4ca54
Remove occurences of mb_head_off
2018-08-15 22:02:33 +03:00
Jan Edmund Lazo
a4c957bab7
lint
2018-08-12 18:21:58 -04:00
Jan Edmund Lazo
cfb2383c26
vim-patch:8.0.1397: pattern with \& following nothing gives an error
...
Problem: Pattern with \& following nothing gives an error.
Solution: Emit an empty node when needed.
890dd05492
2018-08-12 18:09:43 -04:00
Jan Edmund Lazo
d624aea454
lint
2018-08-11 14:37:17 -04:00
Jan Edmund Lazo
5f4a231e3f
vim-patch:8.1.0099: exclamation mark in error message not needed
...
Problem: Exclamation mark in error message not needed.
Solution: Remove the exclamation mark.
3c867daaf0
2018-08-11 14:32:59 -04:00
Jan Edmund Lazo
9c4f6307b7
vim-patch:8.1.0097: superfluous space before exclamation mark
...
Problem: Superfluous space before exclamation mark.
Solution: Remove the space. Don't translate debug message.
5efa0102de
2018-08-11 14:32:59 -04:00
Jan Edmund Lazo
96dc8c0d28
vim-patch:8.1.0090: "..." used inconsistently in a message
...
Problem: "..." used inconsistently in a message.
Solution: Define the message with " ..." once. (hint by Ken Takata)
9b0c5c23bd
2018-08-11 14:32:59 -04:00
Jan Edmund Lazo
b3ad509905
vim-patch:8.1.0078: "..." used inconsistently in messages
...
Problem: "..." used inconsistently in messages.
Solution: Drop the space before " ...".
c166927a32
2018-08-11 14:32:59 -04:00
Jan Edmund Lazo
5ed303c22b
vim-patch:8.0.1470: integer overflow when using regexp pattern
...
Problem: Integer overflow when using regexp pattern. (geeknik)
Solution: Use a long instead of int. (Christian Brabandt, closes vim/vim#2251 )
2c7b906afb
2018-08-11 14:32:59 -04:00
Jan Edmund Lazo
f7f65f5a82
vim-patch:8.0.1254: undefined left shift in gethexchrs()
...
Problem: Undefined left shift in gethexchrs(). (geeknik)
Solution: Use unsigned long. (idea by Christian Brabandt, closes vim/vim#2255 )
4c22a91d20
2018-08-11 14:32:59 -04:00
Jan Edmund Lazo
dd6c1a0a8f
vim-patch:8.0.0828: Coverity: may dereference NULL pointer
...
Problem: Coverity: may dereference NULL pointer.
Solution: Bail out if calloc_state() returns NULL.
983b3a5bc4
2018-08-11 14:32:59 -04:00
ZviRackover
5cecd7a93a
style: fixing minor issues noted in code review.
2018-08-06 22:27:10 +03:00
ZviRackover
071aab5148
Remove some occrrences of enc_utf8 and has_mbyte
...
Removing uses and related dead code in the locallity of changes of
the two parent commits.
2018-08-06 20:48:07 +03:00
ZviRackover
10b6afd652
Remove all occurences of the mb_ptr2char macro
...
First step towards implemening issue #7401 .
The same can be done for all deprecated mb_ functions in follow-up
patches.
2018-08-06 20:48:07 +03:00
Jan Edmund Lazo
3c7ea8d619
vim-patch:8.0.0451: some macros are in lower case
...
Problem: Some macros are in lower case.
Solution: Make a few more macros upper case. Avoid lower case macros use an
argument twice.
91acfffc1e
2018-06-12 02:00:50 -04:00
KunMing Xie
7cc9d2b2b2
vim-patch:8.0.0520: using a function pointer while the function is known ( #8513 )
...
Problem: Using a function pointer instead of the actual function, which we
know.
Solution: Change mb_ functions to utf_ functions when already checked for
Unicode. (Dominique Pelle, closes vim/vim#1582 )
ace95989ed
2018-06-10 12:31:51 +02:00
Jan Edmund Lazo
2ab7165214
lint
2018-06-04 17:51:15 -04:00
Jan Edmund Lazo
21aa4bc428
vim-patch:8.0.0623: error for invalid regexp is not very informative
...
Problem: The message "Invalid range" is used for multiple errors.
Solution: Add two more specific error messages. (Itchyny, Ken Hamada)
966e58e413
2018-06-04 08:44:19 -04:00
KunMing Xie
49a497a67c
vim-patch:8.0.0519: character classes not well tested ( #8460 )
...
Problem: Character classes are not well tested. They can differ between
platforms.
Solution: Add tests. In the documentation make clear which classes depend
on what library function. Only use :cntrl: and :graph: for ASCII.
(Kazunobu Kuriyama, Dominique Pelle, closes vim/vim#1560 )
Update the documentation.
0c078fc7db
2018-06-01 19:57:22 +02:00
ZyX
adfc1212b5
regexp_nfa: Silence PVS/V560: current code is more obvious
...
While warning is technically true (cannot enter this case with `state->c`
greater then NFA_Z…9) it makes condition less readable and relies on knownledge
of enum internal structure.
2018-04-22 19:09:20 +03:00
James McCoy
5f5011e8f6
lint
2018-01-02 19:35:29 -05:00
James McCoy
b86e44aa35
vim-patch:8.0.0160: EMSG() is sometimes used where it should be IEMSG()
...
Problem: EMSG() is sometimes used for internal errors.
Solution: Change them to IEMSG(). (Dominique Pelle) And a few more.
de33011ec6
2018-01-02 19:35:22 -05:00
KunMing Xie
b7e84de7d2
vim-patch:8.0.0165 ( #7132 )
...
Problem: Ubsan warns for integer overflow.
Solution: Swap two conditions. (Dominique Pelle)
f446b48ff0
2017-08-10 04:20:55 +02:00
Jurica Bradaric
fe0bcc0800
vim-patch:8.0.0020
...
Problem: The regexp engines are not reentrant.
Solution: Add regexec_T and save/restore the state when needed.
6100d02aab
2017-07-29 16:27:11 -04:00
Shougo Matsushita
b4ccf5c20a
vim-patch:7.4.2354
...
Problem: The example that explains nested backreferences does not work
properly with the new regexp engine. (Harm te Hennepe)
Solution: Also save the end position when adding a state. (closes vim/vim#990 )
d563883a1f
2017-07-12 00:05:29 -04:00
James McCoy
901c8fbcdb
regexp_nfa: Fix invalid fallthrough in character class detection
...
When the end character in a range matches a different standard range
(e.g., [0-z]), the range would be incorrectly detected as the class of
the end character (CLASS_az).
Instead of using a fallthrough, immediately FAIL when the end character
doesn't match the expected range.
2017-05-12 17:07:25 -04:00
James McCoy
0ff959329b
*: Comment intentional fallthroughs
...
Falling through a switch case should be commented so it's clear that
behavior is intentional.
2017-05-12 12:01:25 -04:00
Justin M. Keyes
a9605bb4af
Merge #6460 from ZyX-I/1476-changes
...
Refactor functions which find character in a string
2017-05-08 13:45:14 +02:00