Justin M. Keyes
072448a2c9
Merge #8604 from janlazo/vim-8.0.0286
2019-01-06 12:45:37 +01:00
Jan Edmund Lazo
fba80f5edc
vim-patch:8.1.0685: get_buf_tv() is named inconsistently
...
Problem: get_buf_tv() is named inconsistently.
Solution: Rename it to tv_get_buf(). (Yegappan Lakshmanan, closes vim/vim#3759 )
f2d79fa92d
2019-01-05 23:10:00 -05:00
Jan Edmund Lazo
758955d1b6
vim-patch:8.1.0687: sentence text object in Visual mode is not tested
...
Problem: Sentence text object in Visual mode is not tested.
Solution: Add a test. (Dominique Pelle, closes vim/vim#3758 )
6d3a1940be
2019-01-05 22:45:31 -05:00
Jan Edmund Lazo
772f4ce9f8
vim-patch:8.1.0677: look-behind match may use the wrong line number
...
Problem: Look-behind match may use the wrong line number. (Dominique Pelle)
Solution: Use the line number in regsave instead of the one in behind_pos,
we may be looking at the previous line. (closes vim/vim#3749 )
866f355814
2019-01-05 22:43:46 -05:00
Jan Edmund Lazo
624f5c8be3
vim-patch:8.1.0683: spell highlighting does not always end
...
Problem: Spell highlighting does not always end. (Gary Johnson)
Solution: Also reset char_attr when spell errors are highlighted.
637532b3c0
2019-01-05 17:29:11 -05:00
Jan Edmund Lazo
40f7ce96c3
vim-patch:8.1.0674: leaking memory when updating a single line
...
Problem: Leaking memory when updating a single line.
Solution: Do not call start_search_hl() twice.
6d5b4f566a
2019-01-05 17:29:11 -05:00
Jan Edmund Lazo
fd674c875b
vim-patch:8.0.0286: not always redrawing after screen resize
...
Problem: When concealing is active and the screen is resized in the GUI it
is not immediately redrawn.
Solution: Use update_prepare() and update_finish() from
update_single_line().
c10f0e7cb0
2019-01-05 17:29:11 -05:00
Justin M. Keyes
2d1214ef46
PVS/V501: diff.c: silence warning
...
False positive: vim_fgets has side effects.
ref 8586770e1f
2019-01-05 23:19:23 +01:00
Justin M. Keyes
46fc0437ba
PVS/V547: Expression is always false
2019-01-05 23:19:23 +01:00
Justin M. Keyes
2a325892c2
PVS/V1026: normal.c: signed integer overflow
...
> V1026 The 'curwin->w_curswant' variable is incremented in the loop.
> Undefined behavior will occur in case of signed integer overflow.
2019-01-05 00:52:31 +01:00
Justin M. Keyes
3e558468cf
PVS/V547: indent.c: xmalloc() never returns NULL
2019-01-05 00:33:26 +01:00
Justin M. Keyes
58538d1210
PVS/V547: window.c: Expression is always true
2019-01-04 02:29:43 +01:00
Justin M. Keyes
6abdc0aeec
PVS/V547: viml/parser/expressions.c: Expression is always true
2019-01-04 02:29:38 +01:00
Justin M. Keyes
788ade1d29
PVS/V751: tui.c, Parameter is not used
...
False positive. Documentation for grid_scroll says "`cols` is always
zero, reserved for future use".
2019-01-04 02:29:35 +01:00
Justin M. Keyes
423b6d9907
PVS/V535: shada.c: variable reassigned in inner loop
...
False positive: `i` is intentionally, temporarily reassigned.
See a70fde1b45
#9425
2019-01-04 02:29:31 +01:00
Justin M. Keyes
6a432d4a0d
PVS/V547: diff.c: xmalloc() never returns NULL
...
Normally we consider OOM to be fatal, but the diff module has extra
functionality to handle OOM in case huge files are compared. Use
try_malloc instead of xmalloc in that case.
2019-01-04 02:29:22 +01:00
Justin M. Keyes
a1e97b18f1
PVS/V547: diff.c: Expression is always true
2019-01-04 02:29:17 +01:00
Justin M. Keyes
8586770e1f
PVS/V501: diff.c: silence warning
...
False positive: vim_fgets has side effects.
2019-01-04 02:29:11 +01:00
Justin M. Keyes
37a499148f
Visual: highlight char-at-cursor
...
Decide whether to highlight the visual-selected character under the
cursor, depending on 'guicursor' style:
- Highlight if cursor is blinking or non-block (vertical, horiz).
- Do NOT highlight if cursor is non-blinking block.
Traditionally Vim's visual selection does "reverse mode", which perhaps
conflicts with the non-blinking block cursor. But 'guicursor' defaults
to a vertical bar for selection=exclusive, and this confuses users who
expect to see the text highlighted.
closes #8983
2019-01-04 01:28:44 +01:00
Justin M. Keyes
e2d71d11de
remove check_visual_highlight()
...
This check is meaningless, we assume the terminal supports reverse-mode.
2019-01-04 01:24:49 +01:00
Jan Edmund Lazo
111e46582c
vim-patch:8.1.0653: arglist test fails on MS-windows
...
Problem: Arglist test fails on MS-windows.
Solution: Only use a file name with a double quote on Unix.
3de8c2d1f0
2019-01-03 01:07:21 -05:00
Jan Edmund Lazo
8e408c95fe
vim-patch:8.1.0651: :args \"foo works like :args without argument
...
Problem: :args \"foo works like :args without argument.
Solution: Fix check for empty argument. (closes vim/vim#3728 )
2ac372ccee
2019-01-03 01:04:09 -05:00
Justin M. Keyes
0afb5fa70a
Merge #9425 'build: enable -Wshadow'
2019-01-03 00:44:36 +01:00
Justin M. Keyes
9f19e8d29d
TUI: Do not disable BCE for builtin terminfos ( #9443 )
...
Remove this vestigial hack from #7624 .
Since 5a0d0286ff
we blacklist BCE more surgically. And
patch_terminfo_bugs() is the more appropriate place for that.
ref 5749ecaf22
ref #4210 #4421 #7035 #7337 #7381 #7425 #7618
2019-01-02 22:31:03 +01:00
Justin M. Keyes
7ede14d191
UGRID_FOREACH_CELL: avoid shadowed variables
2019-01-02 21:06:37 +01:00
Justin M. Keyes
a70fde1b45
build: enable -Wshadow
...
Note about shada.c:
- shada_read_next_item_start was intentionally shadowing `unpacked` and
`i` because many of the macros (e.g. ADDITIONAL_KEY) implicitly
depended on those variable names.
- Macros were changed to parameterize `unpacked` (but not `i`). Macros
like CLEAR_GA_AND_ERROR_OUT do control-flow (goto), so any other
approach is messy.
2019-01-02 21:06:37 +01:00
David Jimenez
8f288698e4
vim-patch:8.0.0251: not easy to select Python 2 or 3 ( #9173 )
...
Problem: It is not so easy to write a script that works with both Python 2 and Python 3, even when the Python code works with both.
Solution: Add 'pyxversion', :pyx, etc. (Marc Weber, Ken Takata)
f42dd3c390
2019-01-02 14:51:03 +01:00
Björn Linse
cdfa395ad8
popupmenu: fix positioning with vsplits
2019-01-01 15:20:37 +01:00
Björn Linse
4e5f5e93c2
multigrid: do all adjustment in screen.c
...
Adjustment will get more complex with floats, tabgrid etc,
so make it into a function.
2019-01-01 15:11:51 +01:00
Justin M. Keyes
3340e08bec
TUI: Konsole DECSCUSR fixup ( #9423 )
...
Apparently Konsole's terminfo is still broken.
ref #9364
closes #9420
2018-12-31 22:24:21 +01:00
Björn Linse
c72d9ce0a6
multigrid: rename grid->ScreenLines and other grid arrays
2018-12-31 16:24:07 +01:00
Björn Linse
c778c2e107
multigrid: API version bump
2018-12-31 16:24:07 +01:00
Björn Linse
dc44309336
multigrid: rename to grid.row_offset and grid.requested_rows
2018-12-31 16:24:07 +01:00
Björn Linse
1cec5542a8
multigrid: reorganize types and global varaibles
2018-12-31 16:24:07 +01:00
Björn Linse
820c81e638
multigrid: various cleanup (types, unused parameters)
...
Handle the rare case of full highlight table properly
2018-12-31 16:24:07 +01:00
Utkarsh Maheshwari
47c053cc39
multigrid: Add multigrid documentation
2018-12-31 12:44:22 +01:00
Björn Linse
db14d78e4f
multigrid: rename event to win_pos, make grid first
2018-12-31 12:44:22 +01:00
Björn Linse
f6f8f0ee76
multigrid: add msg_scroll_start and msg_scroll_reset events
2018-12-31 12:44:22 +01:00
Björn Linse
c3e2e40e02
multigrid: send win_hide events when changing tabpage
2018-12-31 12:44:22 +01:00
Björn Linse
f77f09ea6e
multigrid: don't clear window grids on resize
...
Instead define that the shared top-left part of the grid is preserved.
2018-12-31 12:44:22 +01:00
Utkarsh Maheshwari
ba6f9f60ad
multigrid: Fix lint errors
2018-12-31 12:44:22 +01:00
Utkarsh Maheshwari
8b47b56fc6
multigrid: Draw fold for the entire width of window grid
2018-12-31 12:44:22 +01:00
Utkarsh Maheshwari
f241930472
multigrid: Fix rebase errors in screen.c
2018-12-31 12:44:22 +01:00
Utkarsh Maheshwari
62be9f39ef
multigrid: Fix sending window grid handle in ext_newline mode
2018-12-31 12:44:22 +01:00
Björn Linse
16c3337122
multigrid: use grid-based coordinates for ext_popupmenu
2018-12-31 12:44:22 +01:00
Utkarsh Maheshwari
882dd63dc7
multigrid: Fix grid allocation misses
...
- Clear whole grid in one go.
- Fix wrongly sent "copy" flag.
- Add clear function comment.
2018-12-31 12:44:22 +01:00
Björn Linse
1a896bc93f
multigrid: avoid allocation when not ext_multigrid.
...
Move grid specific functions from mbyte.c to screen.c
2018-12-31 12:44:22 +01:00
Utkarsh Maheshwari
4f1dcf7c28
multigrid: Clean whole grid when it was just resized
2018-12-31 12:44:22 +01:00
Utkarsh Maheshwari
0bab611a96
multigrid: Add ScreenGrid as a param to multibyte functions
2018-12-31 12:44:22 +01:00
Utkarsh Maheshwari
911b731378
multigrid: Get rid of global ScreenLines and set_screengrid
2018-12-31 12:44:22 +01:00