Björn Linse
fa4c260100
cursor_shape: use attribute ids instead of syntax ids
...
As attribute ids is the convention in the UI protocol
Also remove non-threadsafe calls in tui.c to syntax module.
2018-08-13 13:35:35 +02:00
ZviRackover
071aab5148
Remove some occrrences of enc_utf8 and has_mbyte
...
Removing uses and related dead code in the locallity of changes of
the two parent commits.
2018-08-06 20:48:07 +03:00
ZviRackover
10b6afd652
Remove all occurences of the mb_ptr2char macro
...
First step towards implemening issue #7401 .
The same can be done for all deprecated mb_ functions in follow-up
patches.
2018-08-06 20:48:07 +03:00
Justin M. Keyes
7a4d167a92
Merge #8742 vim-patch:8.0.0791,0831,1072,1078,1088
2018-08-04 20:12:48 +02:00
Jan Edmund Lazo
c83ecee885
syntax: syn_pattern.sp_syncing is bool
2018-07-30 18:09:34 -04:00
Jan Edmund Lazo
1c5eee3c91
syntax: add const to get_syntax_attr() params
2018-07-30 16:19:38 -04:00
Jan Edmund Lazo
8f647cf03c
syntax: add const to syn_finish_line() params,vars
2018-07-30 15:29:22 -04:00
Jan Edmund Lazo
eafcfb2fb5
syntax: did_header is bool
...
Refactor all affected functions:
- add const
- declare and initialize on same line
- update boolean declarations from int with bool
2018-07-29 20:28:44 -04:00
Jan Edmund Lazo
3feabcacb0
syntax: scl_id is int
2018-07-29 08:20:00 -04:00
Jan Edmund Lazo
3e6d3bf3bd
vim-patch:8.0.1088: occasional memory use after free
...
Problem: Occasional memory use after free.
Solution: Use the highlight table directly, don't keep a pointer.
414168d97f
2018-07-29 07:52:45 -04:00
Jan Edmund Lazo
f0ca2283b0
vim-patch:8.0.1078: using freed memory with ":hi Normal"
...
Problem: Using freed memory with ":hi Normal".
Solution: Get "item" again after updating the table.
b4ea1914b8
2018-07-29 07:52:45 -04:00
Jan Edmund Lazo
6b7b56dabe
vim-patch:8.0.1072: :highlight command causes a redraw even when nothing changed
...
Problem: The :highlight command causes a redraw even when nothing changed.
Solution: Only set "need_highlight_changed" when an attribute changed.
99433291b1
2018-07-29 07:52:45 -04:00
Jan Edmund Lazo
0c0318f8a7
vim-patch:8.0.0831: with 8 colors the bold attribute is not set properly
...
Problem: With 8 colors the bold attribute is not set properly.
Solution: Move setting HL_TABLE() out of lookup_color. (closes vim/vim#1901 )
12d853fae1
Use TriState on lookup_color() to avoid 'NOLINT' comments.
2018-07-29 07:52:45 -04:00
Jan Edmund Lazo
5af90e2ee7
vim-patch:8.0.0791: terminal colors depend on the system
...
Problem: Terminal colors depend on the system.
Solution: Use the highlight color lookup tables.
b41bf8e6b4
2018-07-29 07:52:45 -04:00
Jan Edmund Lazo
51f939e912
syntax: refactor get_id_list()
...
Add const to parameters and variables.
Declare and init variables on same line.
Use `sizeof(*ptr)` to calculate size for malloc().
2018-07-29 07:51:51 -04:00
Jan Edmund Lazo
c18a1b9034
syntax: refactor syn_combine_list()
...
Add const on parameters and variables.
Update declarations to avoid typecasts.
Use `sizeof(*ptr)` for malloc() to reduce effect of type changes.
ie. short to int16_t
Update syn_compare_stub() variable declarations for consistency.
2018-07-29 07:51:51 -04:00
Jan Edmund Lazo
6646502bbb
syntax: syn_cluster_T.scl_list is int16_t*
2018-07-29 07:51:51 -04:00
Jan Edmund Lazo
8888a6ce80
syntax: refactor syn_current_attr()
...
Declare and initialize variables on same line if possible.
Add const to parameters and variables.
Use bool for any parameter,variable using TRUE/FALSE macros.
Replace 'short' type with 'int16_t'.
2018-07-29 07:51:51 -04:00
Jan Edmund Lazo
db4bddb770
syntax: use const on check_keyword_id() variables
...
Declare and initialize variables as close as possible.
Use const pointers without changing semantics if possible.
2018-07-29 07:51:51 -04:00
Jan Edmund Lazo
eb7aa76b13
syntax: current_next_list is int16_t*
2018-07-29 07:51:51 -04:00
Jan Edmund Lazo
095ddcb548
syntax: update types of stateitem_T members
...
Replace 'short' with 'int16_t' to match lint changes from 8.0.1541.
Update ID_LIST_ALL to match type of stateitem_T.si_cont_list.
2018-07-29 07:51:51 -04:00
Jan Edmund Lazo
6f5eadcdac
syntax: use const on syn_list_keywords() variables
2018-07-29 07:51:50 -04:00
Jan Edmund Lazo
e6993f2491
syntax: use const on copy_id_list() params,vars
2018-07-29 07:51:50 -04:00
Jan Edmund Lazo
ef3cbd91cb
syntax: use const on add_keyword() params,vars
2018-07-29 07:51:50 -04:00
Jan Edmund Lazo
a34066963e
syntax: update types of syn_opt_arg_T members
...
Use bool, not int, for booleans.
Use int16_t, not short, to match lint changes from patch 8.0.1541.
2018-07-29 07:51:50 -04:00
Jan Edmund Lazo
9229f7a05d
syntax: use const on put_id_list() variables
2018-07-29 07:51:50 -04:00
Jan Edmund Lazo
b647ba6afb
vim-patch:8.0.1541: synpat_T is taking too much memory
...
Problem: synpat_T is taking too much memory.
Solution: Reorder members to reduce padding. (Dominique Pelle, closes vim/vim#2671 )
36f923014a
2018-07-29 07:51:50 -04:00
Björn Linse
1adb01c120
ui: use line-based rather than char-based updates in screen.c
...
Add ext_newgrid and ext_hlstate extensions. These use predefined
highlights and line-segment based updates, for efficiency and
simplicity.. The ext_hlstate extension in addition allows semantic
identification of builtin and syntax highlights.
Reimplement the old char-based updates in the remote UI layer, for
compatibility. For the moment, this is still the default. The bulitin
TUI uses the new line-based protocol.
cmdline uses curwin cursor position when ext_cmdline is active.
2018-07-21 13:21:58 +02:00
Björn Linse
989b585e10
highlight: refactor to use stateful representation
...
This allows us to keep track of the source higlight groups,
and not only the final combined highlights.
2018-07-21 13:20:37 +02:00
Björn Linse
696e24f311
highlight: extract low-level highlight logic from syntax, ui
2018-07-21 10:37:44 +02:00
Justin M. Keyes
489d32f2b8
startup: fix ":if 0|syntax on|endif" bug ( #8731 )
...
Problem: ":if 0|syntax {on,off}|endif" skips the default of "syntax on"
because the executor was setting the `did_syntax_onoff` flag even though
"syntax {on,off}" is not actually executed.
closes #8728
2018-07-18 14:30:11 +02:00
Jan Edmund Lazo
a8071354e1
vim-patch:8.0.0640: mismatch between help and actual message
...
Problem: Mismatch between help and actual message for ":syn conceal".
Solution: Change the message to match the help. (Ken Takata)
83064068ea
2018-07-03 20:59:12 -04:00
ZyX
eaf2a25f12
*: Replace b_changedtick with new always-inline functions
...
Ref #8474
2018-06-22 00:44:31 +03:00
Jan Edmund Lazo
52ebe34eeb
vim-patch:8.0.0616: not always setting 'background' correctly after :hi Normal ( #8606 )
...
Problem: When setting the cterm background with ":hi Normal" the value of
'background' may be set wrongly.
Solution: Check that the color is less than 16. Don't set 'background' when
it was set explicitly. (Lemonboy, closes vim/vim#1710 )
1615b36b91
Restore reset_option_was_set(), removed in 419da839e0
ref #8595
ref #8597
2018-06-21 11:15:11 +02:00
Jan Edmund Lazo
dd2e1e9445
syntax: refactor syn_finish_line to return bool
2018-06-16 10:22:20 -04:00
Jan Edmund Lazo
2add88eedc
vim-patch:8.0.0481: unnecessary if statement
...
Problem: Unnecessary if statement.
Solution: Remove the statement. Fix "it's" vs "its" mistakes. (Dominique
Pelle, closes vim/vim#1568 )
aab93b12cb
2018-06-16 10:20:18 -04:00
Jan Edmund Lazo
3c7ea8d619
vim-patch:8.0.0451: some macros are in lower case
...
Problem: Some macros are in lower case.
Solution: Make a few more macros upper case. Avoid lower case macros use an
argument twice.
91acfffc1e
2018-06-12 02:00:50 -04:00
Jan Edmund Lazo
bbb88607c9
vim-patch:8.0.0466: still macros that should be all-caps ( #8510 )
...
Problem: There are still a few macros that should be all-caps.
Solution: Make a few more macros all-caps.
8820b48654
2018-06-10 12:24:00 +02:00
ZyX
953d167015
syntax: Fix PVS/V560: condition was already checked
2018-04-22 20:34:32 +03:00
ZyX
4bab9d34e6
*: Fix clint errors
2018-04-22 20:31:40 +03:00
ZyX
9da2e7b021
syntax: Fix PVS/V560: condition was checked in previous if(), breaking
2018-04-22 20:15:42 +03:00
ZyX
3f4ec1aed2
syntax: Fix PVS/V547: condition was checked
...
In surrounding if() `off` was checked for being non-zero and in previous if() it
was checked for being positive.
2018-04-22 20:15:42 +03:00
ZyX
e724667ef4
syntax: Silence PVS/V560: condition is always true at that point
2018-04-22 20:12:23 +03:00
ZyX
2a951d16a4
syntax: Silence PVS/V522: retval is always non-NULL on this round
2018-04-22 20:08:49 +03:00
ZyX
5ba267722c
syntax: Fix PVS/V560: condition checked in previous if()
2018-04-22 20:06:35 +03:00
Björn Linse
98e7112390
msg: do not scroll entire screen ( #8088 )
2018-03-31 11:12:27 +02:00
Justin M. Keyes
998a16c926
refactor/rename: path_is_absolute()
2018-03-24 14:17:40 +01:00
Justin M. Keyes
65b66bc332
build/MSVC: fix "C4005: RGB: macro redefinition"
2018-03-18 14:30:05 +01:00
KunMing Xie
5ec0a6d13f
vim-patch:8.0.0513: fix getting name of cleared highlight group ( #8103 )
...
Problem: Getting name of cleared highlight group is wrong. (Matt Wozniski)
Solution: Only skip over cleared names for completion. (closes vim/vim#1592 )
Also fix that a cleared group causes duplicate completions.
c96272e30e
2018-03-08 19:49:21 +01:00
ckelsel
b615192a37
vim-patch:8.0.0220: highlight completion misses some values #8013
...
Problem: Completion for :match does not show "none" and other missing
highlight names.
Solution: Skip over cleared entries before checking the index to be at the
end.
15eedf1d62
2018-03-04 16:34:59 +01:00