mirror of
				https://github.com/neovim/neovim.git
				synced 2025-10-26 12:27:24 +00:00 
			
		
		
		
	 1248c12666
			
		
	
	1248c12666
	
	
	
		
			
			This is useful to ensure related commits aren't spread out when generating the changelog.
		
			
				
	
	
		
			247 lines
		
	
	
		
			7.1 KiB
		
	
	
	
		
			Lua
		
	
	
	
	
	
			
		
		
	
	
			247 lines
		
	
	
		
			7.1 KiB
		
	
	
	
		
			Lua
		
	
	
	
	
	
| -- Usage:
 | |
| --    # verbose
 | |
| --    nvim -es +"lua require('scripts.lintcommit').main()"
 | |
| --
 | |
| --    # silent
 | |
| --    nvim -es +"lua require('scripts.lintcommit').main({trace=false})"
 | |
| --
 | |
| --    # self-test
 | |
| --    nvim -es +"lua require('scripts.lintcommit')._test()"
 | |
| 
 | |
| local M = {}
 | |
| 
 | |
| local _trace = false
 | |
| 
 | |
| -- Print message
 | |
| local function p(s)
 | |
|   vim.cmd('set verbose=1')
 | |
|   vim.api.nvim_echo({{s, ''}}, false, {})
 | |
|   vim.cmd('set verbose=0')
 | |
| end
 | |
| 
 | |
| local function die()
 | |
|   p('')
 | |
|   vim.cmd("cquit 1")
 | |
| end
 | |
| 
 | |
| -- Executes and returns the output of `cmd`, or nil on failure.
 | |
| --
 | |
| -- Prints `cmd` if `trace` is enabled.
 | |
| local function run(cmd, or_die)
 | |
|   if _trace then
 | |
|     p('run: '..vim.inspect(cmd))
 | |
|   end
 | |
|   local rv = vim.trim(vim.fn.system(cmd)) or ''
 | |
|   if vim.v.shell_error ~= 0 then
 | |
|     if or_die then
 | |
|       p(rv)
 | |
|       die()
 | |
|     end
 | |
|     return nil
 | |
|   end
 | |
|   return rv
 | |
| end
 | |
| 
 | |
| -- Returns nil if the given commit message is valid, or returns a string
 | |
| -- message explaining why it is invalid.
 | |
| local function validate_commit(commit_message)
 | |
|   -- Return nil if the commit message starts with "fixup" as it signifies it's
 | |
|   -- a work in progress and shouldn't be linted yet.
 | |
|   if vim.startswith(commit_message, "fixup") then
 | |
|     return nil
 | |
|   end
 | |
| 
 | |
|   local commit_split = vim.split(commit_message, ":")
 | |
|   -- Return nil if the type is vim-patch since most of the normal rules don't
 | |
|   -- apply.
 | |
|   if commit_split[1] == "vim-patch" then
 | |
|     return nil
 | |
|   end
 | |
| 
 | |
|   -- Check that message isn't too long.
 | |
|   if commit_message:len() > 80 then
 | |
|     return [[Commit message is too long, a maximum of 80 characters is allowed.]]
 | |
|   end
 | |
| 
 | |
| 
 | |
|   if vim.tbl_count(commit_split) < 2 then
 | |
|     return [[Commit message does not include colons.]]
 | |
|   end
 | |
| 
 | |
|   local before_colon = commit_split[1]
 | |
|   local after_colon = commit_split[2]
 | |
| 
 | |
|   -- Check if commit introduces a breaking change.
 | |
|   if vim.endswith(before_colon, "!") then
 | |
|     before_colon = before_colon:sub(1, -2)
 | |
|   end
 | |
| 
 | |
|   -- Check if type is correct
 | |
|   local type = vim.split(before_colon, "%(")[1]
 | |
|   local allowed_types = {'build', 'ci', 'docs', 'feat', 'fix', 'perf', 'refactor', 'revert', 'test', 'dist', 'vim-patch'}
 | |
|   if not vim.tbl_contains(allowed_types, type) then
 | |
|     return string.format(
 | |
|       'Invalid commit type "%s". Allowed types are:\n    %s',
 | |
|       type,
 | |
|       vim.inspect(allowed_types))
 | |
|   end
 | |
| 
 | |
|   -- Check if scope is appropriate
 | |
|   if before_colon:match("%(") then
 | |
|     local scope = vim.trim(before_colon:match("%((.*)%)"))
 | |
| 
 | |
|     if scope == '' then
 | |
|       return [[Scope can't be empty]]
 | |
|     end
 | |
| 
 | |
|     if vim.startswith(scope, "nvim_") then
 | |
|         return [[Scope should be "api" instead of "nvim_..."]]
 | |
|     end
 | |
| 
 | |
|     local alternative_scope = {
 | |
|       ['filetype.vim'] = 'filetype',
 | |
|       ['filetype.lua'] = 'filetype',
 | |
|       ['tree-sitter'] = 'treesitter',
 | |
|       ['ts'] = 'treesitter',
 | |
|       ['hl'] = 'highlight',
 | |
|     }
 | |
| 
 | |
|     if alternative_scope[scope] then
 | |
|       return ('Scope should be "%s" instead of "%s"'):format(alternative_scope[scope], scope)
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   -- Check that description doesn't end with a period
 | |
|   if vim.endswith(after_colon, ".") then
 | |
|     return [[Description ends with a period (".").]]
 | |
|   end
 | |
| 
 | |
|   -- Check that description starts with a whitespace.
 | |
|   if after_colon:sub(1,1) ~= " " then
 | |
|     return [[There should be a whitespace after the colon.]]
 | |
|   end
 | |
| 
 | |
|   -- Check that description doesn't start with multiple whitespaces.
 | |
|   if after_colon:sub(1,2) == "  " then
 | |
|     return [[There should only be one whitespace after the colon.]]
 | |
|   end
 | |
| 
 | |
|   -- Check that first character after space isn't uppercase.
 | |
|   if string.match(after_colon:sub(2,2), '%u') then
 | |
|     return [[First character should not be uppercase.]]
 | |
|    end
 | |
| 
 | |
|   -- Check that description isn't just whitespaces
 | |
|   if vim.trim(after_colon) == "" then
 | |
|     return [[Description shouldn't be empty.]]
 | |
|   end
 | |
| 
 | |
|   return nil
 | |
| end
 | |
| 
 | |
| function M.main(opt)
 | |
|   _trace = not opt or not not opt.trace
 | |
| 
 | |
|   local branch = run({'git', 'rev-parse', '--abbrev-ref', 'HEAD'}, true)
 | |
|   -- TODO(justinmk): check $GITHUB_REF
 | |
|   local ancestor = run({'git', 'merge-base', 'origin/master', branch})
 | |
|   if not ancestor then
 | |
|     ancestor = run({'git', 'merge-base', 'upstream/master', branch})
 | |
|   end
 | |
|   local commits_str = run({'git', 'rev-list', ancestor..'..'..branch}, true)
 | |
| 
 | |
|   local commits = {}
 | |
|   for substring in commits_str:gmatch("%S+") do
 | |
|      table.insert(commits, substring)
 | |
|   end
 | |
| 
 | |
|   local failed = 0
 | |
|   for _, commit_id in ipairs(commits) do
 | |
|     local msg = run({'git', 'show', '-s', '--format=%s' , commit_id})
 | |
|     if vim.v.shell_error ~= 0 then
 | |
|       p('Invalid commit-id: '..commit_id..'"')
 | |
|     else
 | |
|       local invalid_msg = validate_commit(msg)
 | |
|       if invalid_msg then
 | |
|         failed = failed + 1
 | |
|         p(string.format([[
 | |
| Invalid commit message: "%s"
 | |
|     Commit: %s
 | |
|     %s
 | |
|     See also:
 | |
|         https://github.com/neovim/neovim/blob/master/CONTRIBUTING.md#commit-messages
 | |
|         https://www.conventionalcommits.org/en/v1.0.0/
 | |
| ]],
 | |
|           msg,
 | |
|           commit_id,
 | |
|           invalid_msg))
 | |
|       end
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   if failed > 0 then
 | |
|     die()  -- Exit with error.
 | |
|   else
 | |
|     p('')
 | |
|   end
 | |
| end
 | |
| 
 | |
| function M._test()
 | |
|   -- message:expected_result
 | |
|   local test_cases = {
 | |
|     ['ci: normal message'] = true,
 | |
|     ['build: normal message'] = true,
 | |
|     ['docs: normal message'] = true,
 | |
|     ['feat: normal message'] = true,
 | |
|     ['fix: normal message'] = true,
 | |
|     ['perf: normal message'] = true,
 | |
|     ['refactor: normal message'] = true,
 | |
|     ['revert: normal message'] = true,
 | |
|     ['test: normal message'] = true,
 | |
|     ['dist: normal message'] = true,
 | |
|     ['ci(window): message with scope'] = true,
 | |
|     ['ci!: message with breaking change'] = true,
 | |
|     ['ci(tui)!: message with scope and breaking change'] = true,
 | |
|     ['vim-patch:8.2.3374: Pyret files are not recognized (#15642)'] = true,
 | |
|     ['vim-patch:8.1.1195,8.2.{3417,3419}'] = true,
 | |
|     ['revert: "ci: use continue-on-error instead of "|| true""'] = true,
 | |
|     ['fixup'] = true,
 | |
|     ['fixup: commit message'] = true,
 | |
|     ['fixup! commit message'] = true,
 | |
|     [':no type before colon 1'] = false,
 | |
|     [' :no type before colon 2'] = false,
 | |
|     ['  :no type before colon 3'] = false,
 | |
|     ['ci(empty description):'] = false,
 | |
|     ['ci(only whitespace as description): '] = false,
 | |
|     ['docs(multiple whitespaces as description):   '] = false,
 | |
|     ['revert(multiple whitespaces and then characters as description):  description'] = false,
 | |
|     ['ci no colon after type'] = false,
 | |
|     ['test:  extra space after colon'] = false,
 | |
|     ['ci:	tab after colon'] = false,
 | |
|     ['ci:no space after colon'] = false,
 | |
|     ['ci :extra space before colon'] = false,
 | |
|     ['refactor(): empty scope'] = false,
 | |
|     ['ci( ): whitespace as scope'] = false,
 | |
|     ['ci: period at end of sentence.'] = false,
 | |
|     ['ci: Starting sentence capitalized'] = false,
 | |
|     ['unknown: using unknown type'] = false,
 | |
|     ['ci: you\'re saying this commit message just goes on and on and on and on and on and on for way too long?'] = false,
 | |
|   }
 | |
| 
 | |
|   local failed = 0
 | |
|   for message, expected in pairs(test_cases) do
 | |
|     local is_valid = (nil == validate_commit(message))
 | |
|     if is_valid ~= expected then
 | |
|       failed = failed + 1
 | |
|       p(string.format('[ FAIL ]: expected=%s, got=%s\n    input: "%s"', expected, is_valid, message))
 | |
|     end
 | |
|   end
 | |
| 
 | |
|   if failed > 0 then
 | |
|     die()  -- Exit with error.
 | |
|   end
 | |
| 
 | |
| end
 | |
| 
 | |
| return M
 |