mirror of
https://github.com/neovim/neovim.git
synced 2026-08-01 13:19:20 +00:00
6cb9334aa0
fix(path): avoid shell fallback for unknown users
Problem:
Expanding an unknown ~user path falls back to the shell. In a fast event,
this re-enters the event loop and aborts Nvim.
Solution:
Leave unknown users unexpanded when the system account lookup fails.
(cherry picked from commit 9d3edf345f)
Co-authored-by: MAAZIZ Adel Ayoub <adelayoub.maaziz@gmail.com>
198 lines
6.5 KiB
Lua
198 lines
6.5 KiB
Lua
local t = require('test.testutil')
|
|
local n = require('test.functional.testnvim')()
|
|
|
|
local clear = n.clear
|
|
local eq = t.eq
|
|
local exec_lua = n.exec_lua
|
|
local fnamemodify = n.fn.fnamemodify
|
|
local getcwd = n.fn.getcwd
|
|
local command = n.command
|
|
local poke_eventloop = n.poke_eventloop
|
|
local write_file = t.write_file
|
|
local is_os = t.is_os
|
|
local chdir = n.fn.chdir
|
|
|
|
local function eq_slashconvert(expected, got)
|
|
eq(t.fix_slashes(expected), t.fix_slashes(got))
|
|
end
|
|
|
|
describe('fnamemodify()', function()
|
|
setup(function()
|
|
write_file('Xtest-fnamemodify.txt', [[foobar]])
|
|
t.mkdir('foo')
|
|
write_file('foo/bar', [[bar]])
|
|
end)
|
|
|
|
before_each(clear)
|
|
|
|
teardown(function()
|
|
os.remove('Xtest-fnamemodify.txt')
|
|
n.rmdir('foo')
|
|
end)
|
|
|
|
it('handles the root path', function()
|
|
local root = n.pathroot()
|
|
eq(root, fnamemodify([[/]], ':p:h'))
|
|
eq(root, fnamemodify([[/]], ':p'))
|
|
if is_os('win') then
|
|
eq(root, fnamemodify([[\]], ':p:h'))
|
|
eq(root, fnamemodify([[\]], ':p'))
|
|
command('set shellslash')
|
|
root = string.sub(root, 1, -2) .. '/'
|
|
eq(root, fnamemodify([[\]], ':p:h'))
|
|
eq(root, fnamemodify([[\]], ':p'))
|
|
eq(root, fnamemodify([[/]], ':p:h'))
|
|
eq(root, fnamemodify([[/]], ':p'))
|
|
|
|
local letter_colon = root:sub(1, 2)
|
|
local old_dir = getcwd() .. '/'
|
|
local foo_dir = old_dir .. 'foo/'
|
|
eq(old_dir, fnamemodify(letter_colon, ':p'))
|
|
eq(old_dir, fnamemodify(letter_colon .. '.', ':p'))
|
|
eq(old_dir, fnamemodify(letter_colon .. './', ':p'))
|
|
eq(foo_dir, fnamemodify(letter_colon .. './foo', ':p'))
|
|
eq(foo_dir, fnamemodify(letter_colon .. 'foo', ':p'))
|
|
chdir('foo')
|
|
eq(old_dir, fnamemodify(letter_colon .. '..', ':p'))
|
|
eq(old_dir, fnamemodify(letter_colon .. '../', ':p'))
|
|
eq(foo_dir .. 'bar', fnamemodify(letter_colon .. 'bar', ':p'))
|
|
end
|
|
end)
|
|
|
|
it('handles an unknown user in a fast event #40707', function()
|
|
exec_lua([[
|
|
local timer = assert(vim.uv.new_timer())
|
|
timer:start(0, 0, function()
|
|
timer:close()
|
|
assert(vim.in_fast_event())
|
|
_G.result = vim.fn.fnamemodify('~neovim_user_not_found_test/', ':p')
|
|
end)
|
|
]])
|
|
poke_eventloop()
|
|
local expected = '~neovim_user_not_found_test/'
|
|
if is_os('win') then
|
|
-- Windows never expands ~user, ':p' just prefixes the cwd.
|
|
expected = fnamemodify('.', ':p') .. expected
|
|
end
|
|
eq_slashconvert(expected, exec_lua('return _G.result'))
|
|
end)
|
|
|
|
it(':8 works', function()
|
|
eq('Xtest-fnamemodify.txt', fnamemodify([[Xtest-fnamemodify.txt]], ':8'))
|
|
end)
|
|
|
|
it('handles examples from ":help filename-modifiers"', function()
|
|
-- src/ cannot be a symlink in this test.
|
|
n.api.nvim_set_current_dir(t.paths.test_source_path)
|
|
|
|
local filename = 'src/version.c'
|
|
local cwd = getcwd()
|
|
|
|
eq_slashconvert(cwd .. '/src/version.c', fnamemodify(filename, ':p'))
|
|
|
|
eq_slashconvert('src/version.c', fnamemodify(filename, ':p:.'))
|
|
eq_slashconvert(cwd .. '/src', fnamemodify(filename, ':p:h'))
|
|
eq_slashconvert(cwd .. '', fnamemodify(filename, ':p:h:h'))
|
|
eq('version.c', fnamemodify(filename, ':p:t'))
|
|
eq_slashconvert(cwd .. '/src/version', fnamemodify(filename, ':p:r'))
|
|
|
|
eq_slashconvert(cwd .. '/src/main.c', fnamemodify(filename, ':s?version?main?:p'))
|
|
|
|
local converted_cwd = cwd:gsub('/', '\\')
|
|
eq(converted_cwd .. '\\src\\version.c', fnamemodify(filename, ':p:gs?/?\\\\?'))
|
|
|
|
eq('src', fnamemodify(filename, ':h'))
|
|
eq('version.c', fnamemodify(filename, ':t'))
|
|
eq_slashconvert('src/version', fnamemodify(filename, ':r'))
|
|
eq('version', fnamemodify(filename, ':t:r'))
|
|
eq('c', fnamemodify(filename, ':e'))
|
|
|
|
eq_slashconvert('src/main.c', fnamemodify(filename, ':s?version?main?'))
|
|
end)
|
|
|
|
it('handles advanced examples from ":help filename-modifiers"', function()
|
|
local filename = 'src/version.c.gz'
|
|
|
|
eq('gz', fnamemodify(filename, ':e'))
|
|
eq('c.gz', fnamemodify(filename, ':e:e'))
|
|
eq('c.gz', fnamemodify(filename, ':e:e:e'))
|
|
|
|
eq('c', fnamemodify(filename, ':e:e:r'))
|
|
|
|
eq_slashconvert('src/version.c', fnamemodify(filename, ':r'))
|
|
eq('c', fnamemodify(filename, ':r:e'))
|
|
|
|
eq_slashconvert('src/version', fnamemodify(filename, ':r:r'))
|
|
eq_slashconvert('src/version', fnamemodify(filename, ':r:r:r'))
|
|
end)
|
|
|
|
it('handles :h', function()
|
|
eq('.', fnamemodify('hello.txt', ':h'))
|
|
|
|
eq_slashconvert('path/to', fnamemodify('path/to/hello.txt', ':h'))
|
|
end)
|
|
|
|
it('handles :t', function()
|
|
eq('hello.txt', fnamemodify('hello.txt', ':t'))
|
|
eq_slashconvert('hello.txt', fnamemodify('path/to/hello.txt', ':t'))
|
|
end)
|
|
|
|
it('handles :r', function()
|
|
eq('hello', fnamemodify('hello.txt', ':r'))
|
|
eq_slashconvert('path/to/hello', fnamemodify('path/to/hello.txt', ':r'))
|
|
end)
|
|
|
|
it('handles :e', function()
|
|
eq('txt', fnamemodify('hello.txt', ':e'))
|
|
eq_slashconvert('txt', fnamemodify('path/to/hello.txt', ':e'))
|
|
end)
|
|
|
|
it('handles regex replacements', function()
|
|
eq('content-there-here.txt', fnamemodify('content-here-here.txt', ':s/here/there/'))
|
|
eq('content-there-there.txt', fnamemodify('content-here-here.txt', ':gs/here/there/'))
|
|
end)
|
|
|
|
it('handles shell escape', function()
|
|
local expected
|
|
|
|
if is_os('win') then
|
|
-- we expand with double-quotes on Windows
|
|
expected = [["hello there! quote ' newline]] .. '\n' .. [["]]
|
|
else
|
|
expected = [['hello there! quote '\'' newline]] .. '\n' .. [[']]
|
|
end
|
|
|
|
eq(expected, fnamemodify("hello there! quote ' newline\n", ':S'))
|
|
end)
|
|
|
|
it('can combine :e and :r', function()
|
|
-- simple, single extension filename
|
|
eq('c', fnamemodify('a.c', ':e'))
|
|
eq('c', fnamemodify('a.c', ':e:e'))
|
|
eq('c', fnamemodify('a.c', ':e:e:r'))
|
|
eq('c', fnamemodify('a.c', ':e:e:r:r'))
|
|
|
|
-- multi extension filename
|
|
eq('rb', fnamemodify('a.spec.rb', ':e:r'))
|
|
eq('rb', fnamemodify('a.spec.rb', ':e:r:r'))
|
|
|
|
eq('spec', fnamemodify('a.spec.rb', ':e:e:r'))
|
|
eq('spec', fnamemodify('a.spec.rb', ':e:e:r:r'))
|
|
|
|
eq('spec', fnamemodify('a.b.spec.rb', ':e:e:r'))
|
|
eq('b.spec', fnamemodify('a.b.spec.rb', ':e:e:e:r'))
|
|
eq('b', fnamemodify('a.b.spec.rb', ':e:e:e:r:r'))
|
|
|
|
eq('spec', fnamemodify('a.b.spec.rb', ':r:e'))
|
|
eq('b', fnamemodify('a.b.spec.rb', ':r:r:e'))
|
|
|
|
-- extraneous :e expansions
|
|
eq('c', fnamemodify('a.b.c.d.e', ':r:r:e'))
|
|
eq('b.c', fnamemodify('a.b.c.d.e', ':r:r:e:e'))
|
|
|
|
-- :e never includes the whole filename, so "a.b":e:e:e --> "b"
|
|
eq('b.c', fnamemodify('a.b.c.d.e', ':r:r:e:e:e'))
|
|
eq('b.c', fnamemodify('a.b.c.d.e', ':r:r:e:e:e:e'))
|
|
end)
|
|
end)
|