zeertzjq 7a7ed0c8ac vim-patch:9.0.2122: [security]: prevent overflow in indenting ...

Problem:  [security]: prevent overflow in indenting
Solution: use long long and remove cast to (int)

The shiftwidth option values are defined as being long. However, when
calculating the actual amount of indent, we cast down to (int), which
may cause the shiftwidth value to become negative and later it may even
cause Vim to try to allocate a huge amount of memory.

We already use long and long long variable types to calculate the indent
(and detect possible overflows), so the cast to (int) seems superfluous
and can be safely removed. So let's just remove the (int) cast and
calculate the indent using longs.

Additionally, the 'shiftwidth' option value is also used when determining
the actual 'cino' options. There it can again cause another overflow, so
make sure it is safe in parse_cino() as well.

fixes: vim/vim#13554
closes: vim/vim#13555

3770574e4a

Co-authored-by: Christian Brabandt <cb@256bit.org>

2024-12-10 14:29:24 +08:00

..

testdir

vim-patch:9.0.2122: [security]: prevent overflow in indenting

2024-12-10 14:29:24 +08:00

memfile_test.c

build: remove PVS

2023-11-12 21:26:39 +01:00