neovim

mirror of https://github.com/neovim/neovim.git synced 2025-09-07 20:08:17 +00:00

Files

Justin M. Keyes 58318af718 jobwait(): fix race if job exits before waiting on it

Problem:  If a job exits while waiting on another job, the on_exit
          handler is queued but f_jobwait() skips it.
Solution: Always do process_wait(), so that handlers are run during
          f_jobwait().

fix #8302

Test case:
    $ BUSTED_ARGS="--repeat=2000 --no-keep-going" TEST_FILE=test/functional/core/job_spec.lua TEST_FILTER=waiting make functionaltest

Failure example (macOS CI):
    FAILED  test/functional/core/job_spec.lua: jobs jobwait will run callbacks while waiting
    test/functional/core/job_spec.lua:606: Expected objects to be the same.
    Passed in:
    (table: 0x1be77c80) {
      [1] = 'notification'
      [2] = 'wait'
     *[3] = {
       *[1] = 3 } }
    Expected:
    (table: 0x1be77d10) {
      [1] = 'notification'
      [2] = 'wait'
     *[3] = {
       *[1] = 4 } }
    stack traceback:
      test/functional/core/job_spec.lua:606: in function <test/functional/core/job_spec.lua:583

2019-09-03 16:14:29 +02:00

channels_spec.lua

test/uname(): always lowercase

2019-09-01 22:49:33 -07:00

exit_spec.lua

test: lua test for vim-patch:8.0.0184

2018-03-24 23:06:09 +01:00

fileio_spec.lua

os/fs: introduce os_fopen()

2019-07-25 22:32:23 +02:00

job_spec.lua

jobwait(): fix race if job exits before waiting on it