mirror of
https://github.com/neovim/neovim.git
synced 2026-03-28 11:22:03 +00:00
2069be281c
Problem: libmpack encodes boundary values -129 and -32769 with wrong integer sizes: - -129 as int8 instead of int16 - -32769 as int16 instead of int32 because the boundary checks compare against the wrong values (e.g., lo < 0xffffff7f instead of lo < 0xffffff80). This caused data corruption: -129 would decode as 127. Solution: Fix off-by-one errors in the two's complement boundary constants: 0xffffff80 (-128, min int8) and 0xffff8000 (-32768, min int16). Fixes #37202 Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
70 lines
2.5 KiB
Lua
70 lines
2.5 KiB
Lua
-- Test suite for testing interactions with API bindings
|
|
local t = require('test.testutil')
|
|
local n = require('test.functional.testnvim')()
|
|
|
|
local clear = n.clear
|
|
local eq = t.eq
|
|
local exec_lua = n.exec_lua
|
|
|
|
describe('lua vim.mpack', function()
|
|
before_each(clear)
|
|
it('encodes vim.NIL', function()
|
|
eq(
|
|
{ true, true, true, true },
|
|
exec_lua(function()
|
|
local var = vim.mpack.decode(vim.mpack.encode({ 33, vim.NIL, 77 }))
|
|
return { var[1] == 33, var[2] == vim.NIL, var[3] == 77, var[4] == nil }
|
|
end)
|
|
)
|
|
end)
|
|
|
|
it('encodes vim.empty_dict()', function()
|
|
eq(
|
|
{ { {}, 'foo', {} }, true, false },
|
|
exec_lua(function()
|
|
local var = vim.mpack.decode(vim.mpack.encode({ {}, 'foo', vim.empty_dict() }))
|
|
return { var, vim.islist(var[1]), vim.islist(var[3]) }
|
|
end)
|
|
)
|
|
end)
|
|
|
|
it('encodes negative integers at type boundaries correctly #37202', function()
|
|
-- Test boundary values between int8/int16/int32
|
|
-- int8 range: -128 to -33 (fixint handles -32 to -1)
|
|
-- int16 range: -32768 to -129
|
|
-- int32 range: -2147483648 to -32769
|
|
local result = exec_lua(function()
|
|
local tests = {
|
|
{ -128, -128 }, -- int8 boundary (minimum int8)
|
|
{ -129, -129 }, -- int16 boundary (one past int8)
|
|
{ -32768, -32768 }, -- int16 boundary (minimum int16)
|
|
{ -32769, -32769 }, -- int32 boundary (one past int16)
|
|
}
|
|
local results = {}
|
|
for _, test in ipairs(tests) do
|
|
local input, expected = test[1], test[2]
|
|
local decoded = vim.mpack.decode(vim.mpack.encode(input))
|
|
table.insert(results, { input = input, decoded = decoded, ok = decoded == expected })
|
|
end
|
|
return results
|
|
end)
|
|
for _, r in ipairs(result) do
|
|
eq(true, r.ok, string.format('encode/decode %d returned %d', r.input, r.decoded))
|
|
end
|
|
end)
|
|
|
|
it('encodes dict keys of length 20-31 as fixstr #32784', function()
|
|
-- MessagePack fixstr format: 0xa0 | length (for lengths 0-31)
|
|
-- Before #36737, strings 20-31 bytes were incorrectly encoded as str8 (0xd9, len)
|
|
for len = 20, 31 do
|
|
local expected_header = string.char(0xa0 + len) -- fixstr header
|
|
local result = exec_lua(function(keylen)
|
|
local key = string.rep('x', keylen)
|
|
return vim.mpack.encode({ [key] = 1 })
|
|
end, len)
|
|
-- Byte 1 is fixmap header (0x81), byte 2 should be fixstr header for the key
|
|
eq(expected_header, result:sub(2, 2), 'dict key length ' .. len .. ' should use fixstr')
|
|
end
|
|
end)
|
|
end)
|