Files
neovim/test/functional/options/autoread_spec.lua
Justin M. Keyes d34cfe1cb8 fix(autoread): handle autocmd errors
Problem:
Any random ftplugin or other autocmd, can throw an error when
`:checktime` reloads a buffer. This causes a trace which makes it look
like an issue with `autoread.lua`.

    vim.schedule callback: …/runtime/lua/nvim/autoread.lua:146:
    FileType Autocommands for "*"..function <SNR>1_LoadFTPlugin[20] ..script
    …/runtime/ftplugin/help.lua: Vim(runtime):E5113: Lua chunk:
    …/runtime/lua/vim/treesitter.lua:216: Index out of bounds
    stack traceback:
    [C]: in function 'nvim_buf_get_text'
    …/runtime/lua/vim/treesitter.lua:216: in function 'get_node_text'
    …/runtime/lua/vim/treesitter/query.lua:558: in function 'handler'
    …/runtime/lua/vim/treesitter/query.lua:843: in function '_match_predicates'
    …/runtime/lua/vim/treesitter/query.lua:1082: in function '(for generator)'
    …/runtime/ftplugin/help.lua:91: in function 'runnables'
    …/runtime/ftplugin/help.lua:124: in main chunk
    [C]: in function 'checktime'
    …/runtime/lua/nvim/autoread.lua:146: in function <…/runtime/lua/nvim/autoread.lua:138>

Solution:
Use pcall() and surface the error via nvim_echo.
2026-06-14 22:00:38 +02:00

243 lines
7.8 KiB
Lua

local t = require('test.testutil')
local n = require('test.functional.testnvim')()
local clear = n.clear
local command = n.command
local eq = t.eq
local api = n.api
local retry = t.retry
local write_file = t.write_file
local sleep = vim.uv.sleep
--- Returns true if the autoread module is watching the given buffer
--- (defaults to the current buffer).
local function is_watching(bufnr)
return n.exec_lua(function(b)
return require('nvim.autoread')._is_watching(b or vim.api.nvim_get_current_buf())
end, bufnr)
end
--- Shortens the 'autoread' debounce window so each test doesn't pay the 100ms time-cost.
local function shorten_debounce()
n.exec_lua([[require('nvim.autoread')._set_debounce(10)]])
end
--- Edits a fresh tempfile with the given initial content and asserts the watcher attached.
--- Returns the file path.
local function open_watched(content)
local path = t.tmpname()
write_file(path, content)
command('edit ' .. path)
eq(true, is_watching())
return path
end
describe('autoread file watcher', function()
before_each(function()
clear({ args = { '--clean' } })
shorten_debounce()
end)
it('watches file opened on startup (nvim foo.txt)', function()
local path = t.tmpname()
write_file(path, 'startup original\n')
-- Spawn nvim with the file passed on the command line. This exercises the
-- boot order: plugins must load before the initial file is read so that
-- the BufReadPost autocmd is registered in time to attach a watcher.
clear({ args = { '--clean', path } })
shorten_debounce()
eq({ 'startup original' }, api.nvim_buf_get_lines(0, 0, -1, true))
eq(true, is_watching())
write_file(path, 'startup changed\n')
retry(nil, 3000, function()
eq({ 'startup changed' }, api.nvim_buf_get_lines(0, 0, -1, true))
end)
end)
it('reloads on external change; survives hide; undoable; bdelete stops watch', function()
local path = open_watched('original content\n')
local bufnr = api.nvim_get_current_buf()
-- 1. Plain external change reloads the visible buffer.
write_file(path, 'new content\n')
retry(nil, 3000, function()
eq({ 'new content' }, api.nvim_buf_get_lines(0, 0, -1, true))
end)
-- 2. Hide the buffer; watcher stays attached and still reloads.
command('set hidden')
command('enew')
eq(true, is_watching(bufnr))
write_file(path, 'while hidden\n')
retry(nil, 3000, function()
eq({ 'while hidden' }, api.nvim_buf_get_lines(bufnr, 0, -1, true))
end)
-- 3. The reload is undoable. Done last so the resulting modified state
-- (buffer ≠ disk) doesn't block earlier auto-reload assertions.
command('buffer ' .. bufnr)
command('silent undo')
eq({ 'new content' }, api.nvim_buf_get_lines(0, 0, -1, true))
-- 4. bdelete stops the watcher.
command('enew!')
command('bdelete! ' .. bufnr)
eq(false, is_watching(bufnr))
end)
it('does not reload when buffer has unsaved changes (conflict)', function()
local path = open_watched('original\n')
api.nvim_buf_set_lines(0, 0, -1, true, { 'local change' })
eq(true, api.nvim_get_option_value('modified', { buf = 0 }))
write_file(path, 'external change\n')
-- Give the watcher time to fire; the buffer must NOT be reloaded because
-- it has unsaved changes (autoread only reloads unmodified buffers).
sleep(50)
-- Also do a manual :checktime to be sure
command('silent! checktime')
-- Buffer should still have local changes (autoread doesn't override modified buffers)
eq({ 'local change' }, api.nvim_buf_get_lines(0, 0, -1, true))
end)
it('tracks autoread option changes', function()
local path = open_watched('original\n')
command('setlocal noautoread')
eq(false, is_watching())
-- Modify externally while 'noautoread'.
write_file(path, 'while disabled\n')
sleep(50)
eq({ 'original' }, api.nvim_buf_get_lines(0, 0, -1, true))
-- Re-enable autoread
command('setlocal autoread')
eq(true, is_watching())
-- Modify again
write_file(path, 'after reenable\n')
retry(nil, 3000, function()
eq({ 'after reenable' }, api.nvim_buf_get_lines(0, 0, -1, true))
end)
end)
it('handles file deletion gracefully', function()
local path = open_watched('will be deleted\n')
os.remove(path)
retry(nil, 3000, function()
eq(false, is_watching())
end)
-- Buffer content remains unchanged.
eq({ 'will be deleted' }, api.nvim_buf_get_lines(0, 0, -1, true))
end)
it('coalesces rapid changes via debouncing', function()
local path = open_watched('v1\n')
-- Count buffer reloads triggered by the watcher.
n.exec_lua([[
_G.reloads = 0
vim.api.nvim_create_autocmd('FileChangedShellPost', {
callback = function() _G.reloads = _G.reloads + 1 end,
})
]])
-- 4 back-to-back writes well inside one debounce window.
write_file(path, 'v2\n')
write_file(path, 'v3\n')
write_file(path, 'v4\n')
write_file(path, 'final\n')
retry(nil, 3000, function()
eq({ 'final' }, api.nvim_buf_get_lines(0, 0, -1, true))
end)
-- Let any late-arriving event flush, then assert all 4 writes coalesced.
-- Every fs_event restarts the debounce timer, and 4 sub-millisecond
-- write_file calls fit well inside one window, so the timer fires once.
sleep(50)
eq(1, n.exec_lua('return _G.reloads'))
end)
it("bumps 'busy' on each watched buffer while a reload is pending", function()
-- Use a longer debounce so we can sample 'busy' during pending autoreads.
n.exec_lua([[require('nvim.autoread')._set_debounce(100)]])
local path1 = open_watched('a1\n')
local buf1 = api.nvim_get_current_buf()
command('enew')
local path2 = open_watched('a2\n')
local buf2 = api.nvim_get_current_buf()
eq(0, api.nvim_get_option_value('busy', { buf = buf1 }))
eq(0, api.nvim_get_option_value('busy', { buf = buf2 }))
-- Trigger external changes on both watched files concurrently.
write_file(path1, 'b1\n')
write_file(path2, 'b2\n')
-- Confirm busy=1 during the debounce window.
retry(nil, 1000, function()
eq(1, api.nvim_get_option_value('busy', { buf = buf1 }))
eq(1, api.nvim_get_option_value('busy', { buf = buf2 }))
end)
-- Confirm busy=0 after the autoread.
retry(nil, 3000, function()
eq({ 'b1' }, api.nvim_buf_get_lines(buf1, 0, -1, true))
eq({ 'b2' }, api.nvim_buf_get_lines(buf2, 0, -1, true))
eq(0, api.nvim_get_option_value('busy', { buf = buf1 }))
eq(0, api.nvim_get_option_value('busy', { buf = buf2 }))
end)
end)
it('handles autocmd error during reload', function()
local path = open_watched('original\n')
local bufnr = api.nvim_get_current_buf()
-- Define a broken autocmd.
n.exec_lua([[
vim.api.nvim_create_autocmd('FileChangedShellPost', {
callback = function() error('boom from test autocmd') end,
})
]])
write_file(path, 'changed\n')
-- autoread should surface the error, and do its cleanup despite the failed autocmd.
retry(nil, 3000, function()
t.matches('autoread:.*boom from test autocmd', n.eval('v:errmsg'))
eq(0, api.nvim_get_option_value('busy', { buf = bufnr }))
end)
end)
it('detects changes after atomic rename (external editor save)', function()
local path = open_watched('original\n')
-- Atomic save: write to temp file, rename over target.
local tmp = path .. '.tmp'
write_file(tmp, 'after rename\n')
assert(vim.uv.fs_rename(tmp, path))
retry(nil, 3000, function()
eq({ 'after rename' }, api.nvim_buf_get_lines(0, 0, -1, true))
end)
-- Watcher re-established on the new inode.
eq(true, is_watching())
-- Subsequent plain writes still reload.
write_file(path, 'second change\n')
retry(nil, 3000, function()
eq({ 'second change' }, api.nvim_buf_get_lines(0, 0, -1, true))
end)
end)
end)