Files
neovim/runtime
Mathias Fußenegger e7cd811567 fix(lsp): handle negative activeSignature in signatureHelp (#17064)
omnisharp-roslyn can send negative values:

    {
      activeParameter = 0,
      activeSignature = -1,
      signatures = { {
          documentation = "",
          label = "TestEntity.TestEntity()",
          parameters = {}
        } }
    }

In 3.16 of the specification `activeSignature` is defined as `uinteger`
and therefore negative values shouldn't be allowed, but within 3.15 it
was defined as `number` which makes me think we can be a bit lenient in
this case and handle them.

The expected behavior is quite clear:

    The active signature. If omitted or the value lies outside the
    range of `signatures` the value defaults to zero or is ignored if
    the `SignatureHelp` has no signatures.

Fixes an error:

    util.lua:1685: attempt to get length of local 'lines' (a nil value)
    util.lua:1685: in function 'trim_empty_lines'
    handlers.lua:334: in function 'textDocument/signatureHelp'
2022-01-13 01:47:36 -08:00
..
2021-05-01 14:22:52 -04:00
2021-09-13 16:33:41 +02:00
2022-01-11 14:14:17 +01:00
2021-09-13 16:33:41 +02:00
2021-05-01 22:29:03 -04:00
2021-11-17 10:02:59 +01:00
2014-12-19 15:28:49 -05:00
2021-03-09 19:21:26 +01:00
2022-01-11 14:14:17 +01:00
2021-11-27 19:39:42 +01:00
2019-07-29 20:50:07 +02:00
2021-04-27 09:21:32 -04:00
2021-04-28 21:57:50 -04:00
2019-07-29 20:50:07 +02:00
2021-05-01 22:29:03 -04:00
2021-12-25 11:31:54 +08:00
2021-05-01 22:29:02 -04:00