mirrors/raylib
1
0
Fork 0
mirror of https://github.com/raysan5/raylib.git synced 2025-09-22 03:08:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added comment on IsMouseButtonDown() issue

Browse Source 
IsMouseButtonDown() does not process touch state down properly, state is reseted every frame...
This commit is contained in:
Ray
2020-03-02 00:07:06 +01:00
parent 18a9982126
commit 2f5a7ddcc6
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/core.c
View File

@@ -2522,9 +2522,16 @@ bool IsMouseButtonDown(int button)
if (IsGestureDetected(GESTURE_HOLD)) down = true; if (IsGestureDetected(GESTURE_HOLD)) down = true;
#else #else
if (glfwGetMouseButton(CORE.Window.handle, button)) down = true; if (glfwGetMouseButton(CORE.Window.handle, button)) down = true;
// WARNING: currentButtonState is filled by an event callback and
// reseted every frame (moving value to previousButtonState), consequently,
// if button is kept down, it is not properly detected using currentButtonState
// Same issue happens with touch events, they should be stycky an not reseted
//if (CORE.Input.Mouse.currentButtonState[button] == 1) down = true; //if (CORE.Input.Mouse.currentButtonState[button] == 1) down = true;
// Map touches to mouse buttons checking // Map touches to mouse buttons checking
// WARNING: currentTouchState is reseted every frame and only
// refilled on mouse event (not tracking stationary state properly!)
if (CORE.Input.Touch.currentTouchState[button] == 1) down = true; if (CORE.Input.Touch.currentTouchState[button] == 1) down = true;
#endif #endif
@@ -4008,7 +4015,7 @@ static void KeyCallback(GLFWwindow *window, int key, int scancode, int action, i
static void MouseButtonCallback(GLFWwindow *window, int button, int action, int mods) static void MouseButtonCallback(GLFWwindow *window, int button, int action, int mods)
{ {
CORE.Input.Mouse.currentButtonState[button] = action; CORE.Input.Mouse.currentButtonState[button] = action;
#if defined(SUPPORT_GESTURES_SYSTEM) && defined(SUPPORT_MOUSE_GESTURES) #if defined(SUPPORT_GESTURES_SYSTEM) && defined(SUPPORT_MOUSE_GESTURES)
// Process mouse events as touches to be able to use mouse-gestures // Process mouse events as touches to be able to use mouse-gestures
GestureEvent gestureEvent = { 0 }; GestureEvent gestureEvent = { 0 };