diff --git a/server-fn.c b/server-fn.c index 585e4511b..e9db5a887 100644 --- a/server-fn.c +++ b/server-fn.c @@ -1,4 +1,4 @@ -/* $OpenBSD: server-fn.c,v 1.153 2026/09/10 11:02:18 nicm Exp $ */ +/* $OpenBSD: server-fn.c,v 1.154 2026/09/21 12:43:36 nicm Exp $ */ /* * Copyright (c) 2007 Nicholas Marriott @@ -310,8 +310,8 @@ server_link_window(struct session *src, struct winlink *srcwl, } if (killflag) { /* - * Can't use session_detach as it will destroy session - * if this makes it empty. + * Can't use session_detach as it won't detach the only + * window. */ events_fire_winlink("window-unlinked", dstwl); dstwl->flags &= ~WINLINK_ALERTFLAGS; diff --git a/session.c b/session.c index 491f48904..462db7c7f 100644 --- a/session.c +++ b/session.c @@ -1,4 +1,4 @@ -/* $OpenBSD: session.c,v 1.107 2026/08/05 07:35:35 nicm Exp $ */ +/* $OpenBSD: session.c,v 1.108 2026/09/21 12:43:36 nicm Exp $ */ /* * Copyright (c) 2007 Nicholas Marriott @@ -336,10 +336,17 @@ session_attach(struct session *s, struct window *w, int idx, char **cause) return (wl); } -/* Detach a window from a session. */ +/* + * Detach a window from a session. Returns 1 if the window has not been + * detached - the caller must destroy the session. + */ int session_detach(struct session *s, struct winlink *wl) { + if (RB_MIN(winlinks, &s->windows) == wl && + RB_MAX(winlinks, &s->windows) == wl) + return (1); + if (s->curw == wl && session_last(s) != 0 && session_previous(s, 0) != 0) @@ -352,8 +359,6 @@ session_detach(struct session *s, struct winlink *wl) session_group_synchronize_from(s); - if (RB_EMPTY(&s->windows)) - return (1); return (0); } diff --git a/spawn.c b/spawn.c index 361d207e5..801288a99 100644 --- a/spawn.c +++ b/spawn.c @@ -1,4 +1,4 @@ -/* $OpenBSD: spawn.c,v 1.52 2026/08/20 09:19:24 nicm Exp $ */ +/* $OpenBSD: spawn.c,v 1.53 2026/09/21 12:43:36 nicm Exp $ */ /* * Copyright (c) 2019 Nicholas Marriott @@ -166,8 +166,8 @@ spawn_window(struct spawn_context *sc, char **cause) } if (wl != NULL) { /* - * Can't use session_detach as it will destroy session - * if this makes it empty. + * Can't use session_detach as it won't detach the only + * window. */ wl->flags &= ~WINLINK_ALERTFLAGS; events_fire_winlink("window-unlinked", wl);