mirror of
				https://github.com/tmux/tmux.git
				synced 2025-11-04 09:44:18 +00:00 
			
		
		
		
	Move reading termios settings to before tty_open alters them, and expand the
comment.
This commit is contained in:
		@@ -149,6 +149,27 @@ cmd_new_session_exec(struct cmd *self, struct cmd_ctx *ctx)
 | 
			
		||||
	if (ctx->cmdclient == NULL && ctx->curclient == NULL)
 | 
			
		||||
		detached = 1;
 | 
			
		||||
 | 
			
		||||
	/*
 | 
			
		||||
	 * Fill in the termios settings used for new windows in this session;
 | 
			
		||||
	 * if there is a command client, use the control characters from it.
 | 
			
		||||
	 *
 | 
			
		||||
	 * This is read again with tcgetattr() rather than using tty.tio as if
 | 
			
		||||
	 * detached, tty_open won't be called. Because of this, it must be done
 | 
			
		||||
	 * before opening the terminal as that calls tcsetattr() to prepare for
 | 
			
		||||
	 * tmux taking over.
 | 
			
		||||
	 */
 | 
			
		||||
	if (ctx->cmdclient != NULL && ctx->cmdclient->tty.fd != -1) {
 | 
			
		||||
		if (tcgetattr(ctx->cmdclient->tty.fd, &tio) != 0)
 | 
			
		||||
			fatal("tcgetattr failed");
 | 
			
		||||
	} else
 | 
			
		||||
		memcpy(tio.c_cc, ttydefchars, sizeof tio.c_cc);
 | 
			
		||||
	tio.c_iflag = TTYDEF_IFLAG;
 | 
			
		||||
	tio.c_oflag = TTYDEF_OFLAG;
 | 
			
		||||
	tio.c_lflag = TTYDEF_LFLAG;
 | 
			
		||||
	tio.c_cflag = TTYDEF_CFLAG;
 | 
			
		||||
	cfsetispeed(&tio, TTYDEF_SPEED);
 | 
			
		||||
	cfsetospeed(&tio, TTYDEF_SPEED);
 | 
			
		||||
 | 
			
		||||
	/* Open the terminal if necessary. */
 | 
			
		||||
	if (!detached && ctx->cmdclient != NULL) {
 | 
			
		||||
		if (!(ctx->cmdclient->flags & CLIENT_TERMINAL)) {
 | 
			
		||||
@@ -199,22 +220,6 @@ cmd_new_session_exec(struct cmd *self, struct cmd_ctx *ctx)
 | 
			
		||||
	if (ctx->cmdclient != NULL)
 | 
			
		||||
		environ_update(update, &ctx->cmdclient->environ, &env);
 | 
			
		||||
 | 
			
		||||
	/*
 | 
			
		||||
	 * Fill in the termios settings used for new windows in this session;
 | 
			
		||||
	 * if there is a command client, use the control characters from it.
 | 
			
		||||
	 */
 | 
			
		||||
	if (ctx->cmdclient != NULL && ctx->cmdclient->tty.fd != -1) {
 | 
			
		||||
		if (tcgetattr(ctx->cmdclient->tty.fd, &tio) != 0)
 | 
			
		||||
			fatal("tcgetattr failed");
 | 
			
		||||
	} else
 | 
			
		||||
		memcpy(tio.c_cc, ttydefchars, sizeof tio.c_cc);
 | 
			
		||||
	tio.c_iflag = TTYDEF_IFLAG;
 | 
			
		||||
	tio.c_oflag = TTYDEF_OFLAG;
 | 
			
		||||
	tio.c_lflag = TTYDEF_LFLAG;
 | 
			
		||||
	tio.c_cflag = TTYDEF_CFLAG;
 | 
			
		||||
	cfsetispeed(&tio, TTYDEF_SPEED);
 | 
			
		||||
	cfsetospeed(&tio, TTYDEF_SPEED);
 | 
			
		||||
 | 
			
		||||
	/* Create the new session. */
 | 
			
		||||
	idx = -1 - options_get_number(&global_s_options, "base-index");
 | 
			
		||||
	s = session_create(
 | 
			
		||||
 
 | 
			
		||||
		Reference in New Issue
	
	Block a user