fix #19600 No error checking on fclose (#19836)

* fix #19600 No error checking on fclose

* add IOError to open

lib/std/syncio.nim

@@ -324,7 +324,9 @@ const
 proc close*(f: File) {.tags: [], gcsafe.} =
   ## Closes the file.
   if not f.isNil:
-    discard c_fclose(f)
+    let x = c_fclose(f)
+    if x < 0:
+      checkErr(f)
 
 proc readChar*(f: File): char {.tags: [ReadIOEffect].} =
   ## Reads a single character from the stream `f`. Should not be used in
@@ -689,7 +691,7 @@ when defined(posix) and not defined(nimscript):
 
 proc open*(f: var File, filename: string,
           mode: FileMode = fmRead,
-          bufSize: int = -1): bool {.tags: [], raises: [], benign.} =
+          bufSize: int = -1): bool {.tags: [], raises: [IOError], benign.} =
   ## Opens a file named `filename` with given `mode`.
   ##
   ## Default mode is readonly. Returns true if the file could be opened.

tests/misc/t19600.nim

@@ -0,0 +1,9 @@
+discard """
+  targets: "c cpp"
+  disabled: "win"
+  disabled: "osx"
+  exitcode: 1
+  outputsub: "No space left on device"
+"""
+
+writeFile("/dev/full", "hello\n")