mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-06-04 02:44:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update message for checking cast (#20145)

Browse Source 
* Update message for checking `cast`

* Update error messages in tests
This commit is contained in:
konsumlamm
2022-09-28 13:59:27 +02:00
committed by GitHub
parent e33e9e4a32
commit 18cea8e9bd
3 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
compiler/semexprs.nim
View File

@@ -241,7 +241,10 @@ proc isCastable(c: PContext; dst, src: PType, info: TLineInfo): bool =
(skipTypes(dst, abstractInst).kind in IntegralTypes) or
(skipTypes(src, abstractInst-{tyTypeDesc}).kind in IntegralTypes)
if result and (dstSize > srcSize):
message(conf, info, warnCastSizes, "target type is larger than source type")
var warnMsg = "target type is larger than source type"
warnMsg.add("\n target type: '$1' ($2)" % [$dst, if dstSize == 1: "1 byte" else: $dstSize & " bytes"])
warnMsg.add("\n source type: '$1' ($2)" % [$src, if srcSize == 1: "1 byte" else: $srcSize & " bytes"])
message(conf, info, warnCastSizes, warnMsg)
if result and src.kind == tyNil:
return dst.size <= conf.target.ptrSize
@@ -363,10 +366,7 @@ proc semCast(c: PContext, n: PNode): PNode =
if tfHasMeta in targetType.flags:
localError(c.config, n[0].info, "cannot cast to a non concrete type: '$1'" % $targetType)
if not isCastable(c, targetType, castedExpr.typ, n.info):
let tar = $targetType
let alt = typeToString(targetType, preferDesc)
let msg = if tar != alt: tar & "=" & alt else: tar
localError(c.config, n.info, "expression cannot be cast to " & msg)
localError(c.config, n.info, "expression cannot be cast to '$1'" % $targetType)
result = newNodeI(nkCast, n.info)
result.typ = targetType
result.add copyTree(n[0])

2
tests/arc/t16558.nim
View File

@@ -1,6 +1,6 @@
discard """
matrix: "--gc:arc"
errormsg: "expression cannot be cast to int"
errormsg: "expression cannot be cast to 'int'"
"""
block: # bug #16558

2
tests/arc/tref_cast_error.nim
View File

@@ -1,6 +1,6 @@
discard """
cmd: "nim c --gc:arc $file"
errormsg: "expression cannot be cast to ref RootObj"
errormsg: "expression cannot be cast to 'ref RootObj'"
joinable: false
"""