Fix printing and comparing uninitialized strings

This commit is contained in:
recloser
2018-10-21 21:18:10 +02:00
parent ce05a850a5
commit 2b03bed2db
4 changed files with 20 additions and 9 deletions

View File

@@ -228,6 +228,7 @@ proc cstrToNimstr(c: cstring): string {.asmNoStackFrame, compilerproc.} =
proc toJSStr(s: string): cstring {.asmNoStackFrame, compilerproc.} =
asm """
if (`s` === null) return "";
var len = `s`.length;
var asciiPart = new Array(len);
var fcc = String.fromCharCode;
@@ -330,6 +331,8 @@ proc cmp(x, y: string): int =
proc eqStrings(a, b: string): bool {.asmNoStackFrame, compilerProc.} =
asm """
if (`a` == `b`) return true;
if (`a` === null && `b`.length == 0) return true;
if (`b` === null && `a`.length == 0) return true;
if ((!`a`) || (!`b`)) return false;
var alen = `a`.length;
if (alen != `b`.length) return false;

View File

@@ -1,4 +0,0 @@
var x = "foo".cstring
var y: string
add(y, x)
doAssert y == "foo"

17
tests/js/tnilstrs.nim Normal file
View File

@@ -0,0 +1,17 @@
block:
var x: string
var y = "foo"
echo x
doAssert x == ""
doAssert "" == x
add(x, y)
y[0] = 'm'
doAssert y == "moo" and x == "foo"
block:
var x = "foo".cstring
var y: string
add(y, x)
doAssert y == "foo"

View File

@@ -1,5 +0,0 @@
var x: string
var y = "foo"
add(x, y)
y[0] = 'm'
doAssert y == "moo" and x == "foo"