mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2025-12-28 17:04:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes #20397; fixes stylecheck regression (#20398)

Browse Source 
* fixes  #20397; fixes stylecheck

* add testcase

(cherry picked from commit 70c25c45d6)
This commit is contained in:
ringabout
2022-09-22 03:04:33 +08:00
committed by narimiran
parent fbd99c781f
commit 31fe32afd1
4 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
compiler/linter.nim
View File

@@ -93,6 +93,7 @@ proc nep1CheckDefImpl(conf: ConfigRef; info: TLineInfo; s: PSym; k: TSymKind) =
template styleCheckDef*(ctx: PContext; info: TLineInfo; sym: PSym; k: TSymKind) =
## Check symbol definitions adhere to NEP1 style rules.
if optStyleCheck in ctx.config.options and # ignore if styleChecks are off
{optStyleHint, optStyleError} * ctx.config.globalOptions != {} and # check only if hint/error is enabled
hintName in ctx.config.notes and # ignore if name checks are not requested
ctx.config.belongsToProjectPackage(ctx.module) and # ignore foreign packages
optStyleUsages notin ctx.config.globalOptions and # ignore if requested to only check name usage

4
tests/stylecheck/t20397.nim Normal file
View File

@@ -0,0 +1,4 @@
{.hintAsError[Name]:on.}
var a_b = 1
discard a_b
{.hintAsError[Name]:off.}

8
tests/stylecheck/t20397_1.nim Normal file
View File

@@ -0,0 +1,8 @@
discard """
matrix: "--styleCheck:off"
"""
{.hintAsError[Name]:on.}
var a_b = 1
discard a_b
{.hintAsError[Name]:off.}

7
tests/stylecheck/t20397_2.nim Normal file
View File

@@ -0,0 +1,7 @@
discard """
errormsg: "'a_b' should be: 'aB'"
matrix: "--styleCheck:error"
"""
var a_b = 1
discard a_b