mirror of
https://github.com/nim-lang/Nim.git
synced 2026-01-08 14:03:23 +00:00
fix #14698 nkRecWhen caused internalAssert in semConstructFields when generic type not mentioned in fields (#14709)
* fix #14698 nkRecWhen caused internalAssert in semConstructFields when generic type not mentioned in fields * address comment * Update compiler/semtypinst.nim Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
This commit is contained in:
@@ -630,7 +630,10 @@ proc replaceTypeVarsTAux(cl: var TReplTypeVars, t: PType): PType =
|
||||
result = t
|
||||
|
||||
# Slow path, we have some work to do
|
||||
if result.n != nil and t.kind == tyObject:
|
||||
if t.kind == tyRef and t.len > 0 and t[0].kind == tyObject and t[0].n != nil:
|
||||
discard replaceObjBranches(cl, t[0].n)
|
||||
|
||||
elif result.n != nil and t.kind == tyObject:
|
||||
# Invalidate the type size as we may alter its structure
|
||||
result.size = -1
|
||||
result.n = replaceObjBranches(cl, result.n)
|
||||
|
||||
@@ -42,3 +42,23 @@ var b: TMyObj = a
|
||||
type
|
||||
InheritableFoo {.inheritable.} = ref object
|
||||
InheritableBar = ref object of InheritableFoo # ERROR.
|
||||
|
||||
block: # bug #14698
|
||||
const N = 3
|
||||
type Foo[T] = ref object
|
||||
x1: int
|
||||
when N == 2:
|
||||
x2: float
|
||||
when N == 3:
|
||||
x3: seq[int]
|
||||
else:
|
||||
x4: char
|
||||
x4b: array[9, char]
|
||||
|
||||
let t = Foo[float](x1: 1)
|
||||
doAssert $(t[]) == "(x1: 1, x3: @[])"
|
||||
doAssert t.sizeof == int.sizeof
|
||||
type Foo1 = object
|
||||
x1: int
|
||||
x3: seq[int]
|
||||
doAssert t[].sizeof == Foo1.sizeof
|
||||
|
||||
Reference in New Issue
Block a user