mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-04-19 22:10:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes #23936; opcParseFloat accepts the wrong register as the first param [backport] (#23941)

Browse Source 
fixes #23936
follow up https://github.com/nim-lang/Nim/pull/20527

(cherry picked from commit b215ec3735)
This commit is contained in:
ringabout
2024-08-12 20:43:13 +08:00
committed by narimiran
parent 1100f550dc
commit 3f183f6769
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
compiler/vm.nim
View File

@@ -1359,7 +1359,7 @@ proc rawExecute(c: PCtx, start: int, tos: PStackFrame): TFullReg =
else:
internalError(c.config, c.debug[pc], "opcParseFloat: Incorrectly created openarray")
else:
regs[ra].intVal = parseBiggestFloat(regs[ra].node.strVal, rcAddr.floatVal)
regs[ra].intVal = parseBiggestFloat(regs[rb].node.strVal, rcAddr.floatVal)
of opcRangeChck:
let rb = instr.regB

11
tests/stdlib/tparseutils.nim
View File

@@ -99,3 +99,14 @@ block: # With this included, static: test() crashes the compiler (from a
checkParseSize " 12" , 0, 1 # Leading white
# Value Edge cases
checkParseSize "9223372036854775807", 19, int64.high
block: # bug #23936
func parsePyFloat(
a: openArray[char], # here must be openArray instead of string to reproduce this bug
res: var BiggestFloat): int =
result = parseFloat(a, res)
static:
var f = 0.0
doAssert "1.0".parsePyFloat(f) == 3
doAssert f == 1.0