fix nil node in sym ast of exported ref objects [backport:2.2] (#24527)

fixes #24526, follows up #23101

The `shallowCopy` calls do not keep the original node's children, they
just make a new seq with the same length, so the `Ident "*"` node from
the original postfix nodes was not carried over, making it `nil` and
causing the segfault.

(cherry picked from commit b529f69518)
This commit is contained in:
metagn
2024-12-10 15:20:40 +03:00
committed by narimiran
parent 316141162b
commit 4e1bc4216a
2 changed files with 26 additions and 0 deletions

View File

@@ -1698,12 +1698,14 @@ proc typeSectionRightSidePass(c: PContext, n: PNode) =
obj.ast[0] = a[0].shallowCopy
if a[0][0].kind == nkPostfix:
obj.ast[0][0] = a[0][0].shallowCopy
obj.ast[0][0][0] = a[0][0][0] # ident "*"
obj.ast[0][0][1] = symNode
else:
obj.ast[0][0] = symNode
obj.ast[0][1] = a[0][1]
of nkPostfix:
obj.ast[0] = a[0].shallowCopy
obj.ast[0][0] = a[0][0] # ident "*"
obj.ast[0][1] = symNode
else: assert(false)
obj.ast[1] = a[1]

View File

@@ -0,0 +1,24 @@
# issue #24526
import std/macros
template prag {.pragma.}
type
Foo1* = ref object of RootObj
name*: string
Foo2* {.used.} = ref object of RootObj
name*: string
Foo3* {.prag.} = ref object of RootObj
name*: string
Foo4* {.used, prag.} = ref object of RootObj
name*: string
# needs to have `typedesc` type
proc foo(T: typedesc): bool =
T.hasCustomPragma(prag)
doAssert not foo(typeof(Foo1()[]))
doAssert not foo(typeof(Foo2()[]))
doAssert foo(typeof(Foo3()[]))
doAssert foo(typeof(Foo4()[]))