mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-02-12 22:33:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

[backport] remove 'CountTable.mget' (#13355)

Browse Source 
It didn't work, and it was an oversight to be included in v1.0.
This commit is contained in:
Miran
2020-02-07 20:50:44 +01:00
committed by GitHub
parent 36d1ad39d0
commit 78b15de304
2 changed files with 9 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
changelog.md
View File

@@ -19,6 +19,9 @@
- Global variable `lc` has been removed from sugar.nim.
- `distinctBase` has been moved from sugar.nim to typetraits and now implemented as
compiler type trait instead of macro. `distinctBase` in sugar module is now deprecated.
- `CountTable.mget` has been removed from `tables.nim`. It didn't work, and it
was an oversight to be included in v1.0.
### Breaking changes in the compiler
@@ -50,11 +53,12 @@
- Added `times.fromUnixFloat,toUnixFloat`, subsecond resolution versions of `fromUnix`,`toUnixFloat`.
- Added `wrapnils` module for chains of field-access and indexing where the LHS can be nil.
This simplifies code by reducing need for if-else branches around intermediate maybe nil values.
Eg: `echo ?.n.typ.kind`
E.g. `echo ?.n.typ.kind`
- Added `minIndex` and `maxIndex` to the `sequtils` module
- Added `os.isRelativeTo` to tell whether a path is relative to another
- Added `resetOutputFormatters` to `unittest`
## Library changes
- `asynchttpserver` now the request body is a FutureStream.
@@ -71,9 +75,10 @@
- `htmlgen.html` allows `lang` on the `<html>` tag and common valid attributes.
- `macros.basename` and `basename=` got support for `PragmaExpr`,
so that an expression like `MyEnum {.pure.}` is handled correctly.
- `httpclient.maxredirects` changed from `int` to `Natural`, because negative values serve no purpose whatsoever.
- `httpclient.newHttpClient` and `httpclient.newAsyncHttpClient` added `headers` argument to set initial HTTP Headers,
instead of a hardcoded empty `newHttpHeader()`.
- `httpclient.maxredirects` changed from `int` to `Natural`, because negative values
serve no purpose whatsoever.
- `httpclient.newHttpClient` and `httpclient.newAsyncHttpClient` added `headers`
argument to set initial HTTP Headers, instead of a hardcoded empty `newHttpHeader()`.
## Language additions

13
lib/pure/collections/tables.nim
View File

@@ -2304,13 +2304,6 @@ proc `[]`*[A](t: CountTable[A], key: A): int =
assert(not t.isSorted, "CountTable must not be used after sorting")
ctget(t, key, 0)
proc mget*[A](t: var CountTable[A], key: A): var int =
## Retrieves the value at ``t[key]``. The value can be modified.
##
## If ``key`` is not in ``t``, the ``KeyError`` exception is raised.
assert(not t.isSorted, "CountTable must not be used after sorting")
get(t, key)
proc `[]=`*[A](t: var CountTable[A], key: A, val: int) =
## Inserts a ``(key, value)`` pair into ``t``.
##
@@ -2674,12 +2667,6 @@ proc `[]`*[A](t: CountTableRef[A], key: A): int =
## is in the table
result = t[][key]
proc mget*[A](t: CountTableRef[A], key: A): var int =
## Retrieves the value at ``t[key]``. The value can be modified.
##
## If ``key`` is not in ``t``, the ``KeyError`` exception is raised.
mget(t[], key)
proc `[]=`*[A](t: CountTableRef[A], key: A, val: int) =
## Inserts a ``(key, value)`` pair into ``t``.
##