mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2025-12-29 01:14:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes #21278; deques.shrink off by one bug (#21284)

Browse Source 
fixes #21278; deques.shrink off ny one bug

(cherry picked from commit b82b5d44af)
This commit is contained in:
ringabout
2023-01-20 18:43:45 +08:00
committed by narimiran
parent 0cdbf5e04e
commit 7a43d00a64
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/pure/collections/deques.nim
View File

@@ -441,7 +441,7 @@ proc shrink*[T](deq: var Deque[T], fromFirst = 0, fromLast = 0) =
deq.head = (deq.head + 1) and deq.mask
for i in 0 ..< fromLast:
destroy(deq.data[deq.tail])
destroy(deq.data[(deq.tail - 1) and deq.mask])
deq.tail = (deq.tail - 1) and deq.mask
dec deq.count, fromFirst + fromLast

6
tests/stdlib/tdeques.nim
View File

@@ -183,6 +183,12 @@ proc main() =
clear(a)
doAssert len(a) == 0
block: # bug #21278
var a = [10, 20, 30, 40].toDeque
a.shrink(fromFirst = 0, fromLast = 1)
doAssert $a == "[10, 20, 30]"
static: main()
main()