mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-01-18 02:27:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Assigning template to var/let/const gives a proper error (#12851)

Browse Source 
* Assigning template to var/let/const gives a proper error

* Fix style
This commit is contained in:
Neelesh Chandola
2019-12-09 13:49:40 +05:30
committed by cooldome
parent a3d45d0c1b
commit 7ebb2baa6c
4 changed files with 24 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
compiler/semstmts.nim
View File

@@ -36,7 +36,7 @@ const
errRecursiveDependencyX = "recursive dependency: '$1'"
errRecursiveDependencyIteratorX = "recursion is not supported in iterators: '$1'"
errPragmaOnlyInHeaderOfProcX = "pragmas are only allowed in the header of a proc; redefinition of $1"
errCannotAssignMacroSymbol = "cannot assign macro symbol to $1 here. Forgot to invoke the macro with '()'?"
errCannotAssignMacroSymbol = "cannot assign $1 '$2' to '$3'. Did you mean to call the $1 with '()'?"
errInvalidTypeDescAssign = "'typedesc' metatype is not valid here; typed '=' instead of ':'?"
proc semDiscard(c: PContext, n: PNode): PNode =
@@ -449,8 +449,10 @@ proc semVarOrLet(c: PContext, n: PNode, symkind: TSymKind): PNode =
if a[^1].kind != nkEmpty:
def = semExprWithType(c, a[^1], {efAllowDestructor})
if def.typ.kind == tyProc and def.kind == nkSym:
if def.sym.kind == skMacro:
localError(c.config, def.info, errCannotAssignMacroSymbol % "variable")
if def.sym.kind in {skMacro, skTemplate}:
localError(c.config, def.info, errCannotAssignMacroSymbol % [
if def.sym.kind == skMacro: "macro" else: "template",
def.sym.name.s, a[0].ident.s])
def.typ = errorType(c)
elif def.typ.kind == tyTypeDesc and c.p.owner.kind != skMacro:
# prevent the all too common 'var x = int' bug:
@@ -590,8 +592,10 @@ proc semConst(c: PContext, n: PNode): PNode =
# don't evaluate here since the type compatibility check below may add a converter
var def = semExprWithType(c, a[^1])
if def.typ.kind == tyProc and def.kind == nkSym:
if def.sym.kind == skMacro:
localError(c.config, def.info, errCannotAssignMacroSymbol % "constant")
if def.sym.kind in {skMacro, skTemplate}:
localError(c.config, def.info, errCannotAssignMacroSymbol % [
if def.sym.kind == skMacro: "macro" else: "template",
def.sym.name.s, a[0].ident.s])
def.typ = errorType(c)
elif def.typ.kind == tyTypeDesc and c.p.owner.kind != skMacro:
# prevent the all too common 'const x = int' bug:

2
tests/errmsgs/t10489_a.nim
View File

@@ -1,5 +1,5 @@
discard """
errormsg: "cannot assign macro symbol to variable here"
errormsg: "cannot assign macro 'm' to 'x1'. Did you mean to call the macro with '()'?"
line: 9
"""

2
tests/errmsgs/t10489_b.nim
View File

@@ -1,5 +1,5 @@
discard """
errormsg: "cannot assign macro symbol to constant here"
errormsg: "cannot assign macro 'm' to 'x2'. Did you mean to call the macro with '()'?"
line: 9
"""

13
tests/errmsgs/t12844.nim Normal file
View File

@@ -0,0 +1,13 @@
discard """
cmd: "nim check $file"
errormsg: "cannot assign template 'z' to 'y'. Did you mean to call the template with '()'?"
nimout: '''
t12844.nim(11, 11) Error: cannot assign template 'z' to 'x'. Did you mean to call the template with '()'?
t12844.nim(12, 9) Error: cannot assign template 'z' to 'y'. Did you mean to call the template with '()'?'''
"""
template z*(args: varargs[string, `$`]) =
discard
const x = z
var y = z