mirror of
https://github.com/nim-lang/Nim.git
synced 2026-07-19 07:21:19 +00:00
Don't provide suggestions for enum fields (#22959)
Currently the suggestions create a lot of noise when creating enum fields. I don't see any way of a macro creating fields (when called inside an enum) so it should be safe to not show suggestions --------- Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
This commit is contained in:
@@ -732,6 +732,9 @@ proc suggestDecl*(c: PContext, n: PNode; s: PSym) =
|
||||
if attached: inc(c.inTypeContext)
|
||||
defer:
|
||||
if attached: dec(c.inTypeContext)
|
||||
# If user is typing out an enum field, then don't provide suggestions
|
||||
if s.kind == skEnumField and c.config.cmd == cmdIdeTools and exactEquals(c.config.m.trackPos, n.info):
|
||||
suggestQuit()
|
||||
suggestExpr(c, n)
|
||||
|
||||
proc suggestStmt*(c: PContext, n: PNode) =
|
||||
|
||||
17
nimsuggest/tests/tenum_field.nim
Normal file
17
nimsuggest/tests/tenum_field.nim
Normal file
@@ -0,0 +1,17 @@
|
||||
discard """
|
||||
$nimsuggest --tester $file
|
||||
>sug $1
|
||||
>sug $2
|
||||
sug;;skConst;;tenum_field.BarFoo;;int literal(1);;$file;;10;;6;;"";;100;;Prefix
|
||||
"""
|
||||
|
||||
proc something() = discard
|
||||
|
||||
const BarFoo = 1
|
||||
|
||||
type
|
||||
Foo = enum
|
||||
# Test that typing the name doesn't give suggestions
|
||||
somethi#[!]#
|
||||
# Test that the right hand side still gets suggestions
|
||||
another = BarFo#[!]#
|
||||
Reference in New Issue
Block a user