Don't provide suggestions for enum fields (#22959)

Currently the suggestions create a lot of noise when creating enum
fields. I don't see any way of a macro creating fields (when called
inside an enum) so it should be safe to not show suggestions

---------

Co-authored-by: Andreas Rumpf <rumpf_a@web.de>
This commit is contained in:
Jake Leahy
2023-11-21 07:12:54 +11:00
committed by GitHub
parent 02be027e9b
commit 81c0513644
2 changed files with 20 additions and 0 deletions

View File

@@ -732,6 +732,9 @@ proc suggestDecl*(c: PContext, n: PNode; s: PSym) =
if attached: inc(c.inTypeContext)
defer:
if attached: dec(c.inTypeContext)
# If user is typing out an enum field, then don't provide suggestions
if s.kind == skEnumField and c.config.cmd == cmdIdeTools and exactEquals(c.config.m.trackPos, n.info):
suggestQuit()
suggestExpr(c, n)
proc suggestStmt*(c: PContext, n: PNode) =

View File

@@ -0,0 +1,17 @@
discard """
$nimsuggest --tester $file
>sug $1
>sug $2
sug;;skConst;;tenum_field.BarFoo;;int literal(1);;$file;;10;;6;;"";;100;;Prefix
"""
proc something() = discard
const BarFoo = 1
type
Foo = enum
# Test that typing the name doesn't give suggestions
somethi#[!]#
# Test that the right hand side still gets suggestions
another = BarFo#[!]#