mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-08-20 22:00:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

IC: Do not serialize nfHasComment to nif (#26127)

Browse Source 
It causes non-deterministic behavior because it's process-local.
This commit is contained in:
SirOlaf
2026-08-20 18:11:31 +02:00
committed by GitHub
parent 81325d0745
commit 901ca7905a
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
compiler/ast2nif.nim
View File

@@ -800,7 +800,11 @@ proc writeSymNode(w: var Writer; dest: var IcBuilder; n: PNode; sym: PSym) =
dest.addSymUse pool.syms.getOrIncl(w.toNifSymName(sym)), info
proc writeNodeFlags(dest: var IcBuilder; flags: set[TNodeFlag]) {.inline.} =
writeFlags(dest, flags)
# Comment text is not stored in NIF; `nfHasComment` is process-local
# (see `comment` in ast.nim). Emitting it made IC non-deterministic:
# `copyTree` from a parsed generic kept the comment (`"sh"`) while
# `copyTree` from a cache-loaded generic did not (`"s"`).
writeFlags(dest, flags - {nfHasComment})
template withNode(w: var Writer; dest: var IcBuilder; n: PNode; body: untyped) =
dest.addParLe pool.tags.getOrIncl(toNifTag(n.kind)), trLineInfo(w, n.info)