mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-08-05 15:08:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

nimsuggest tester: only force a cold NIF cache for order-sensitive tests

Browse Source 
The previous commit gave every test run a freshly-wiped --nimcache to make
sug/con result ordering deterministic under IC. But that forced both the
stdio and EPC variant of all 68 tests to start cold, paying IC's NIF-write
cost ~136 times with zero reuse. The suite went from ~6 min to ~12 min wall
clock and blew the 90-minute Azure job timeout (the job was cancelled
mid-nimsuggest-suite — not a hang; the tests pass).

Only two tests actually rank results by per-symbol usage counts (which aren't
serialized into NIF, so cold and warm orderings differ): tsug_typedecl and
ttype_decl. Force the cold cache for just those; every other test reuses the
warm cache. Suite is back to ~6:15 and green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
araq
2026-06-23 17:13:34 +02:00
parent 5438ea5e93
commit 93dc5e7ccd
1 changed files with 16 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
nimsuggest/tester.nim
View File

@@ -74,18 +74,22 @@ proc parseTest(filename: string; epcMode=false): Test =
# else: ignore empty lines for better readability of the specs
inc i
tmp.close()
# Give every run a private, freshly-wiped NIF cache. Under IC nimsuggest reuses
# the on-disk NIFs of a previous session, but per-symbol usage counts are not
# serialized, so a warm start ranks `sug`/`con` results differently than a cold
# one (e.g. `string` outranks `int` because `system` was loaded, not re-walked).
# The tester runs the stdio and EPC variants of a test as two processes sharing
# the same temp project name — without isolation the second inherits the first's
# NIFs and the result order flips. A dedicated, cleared cache keeps both cold and
# deterministic.
let nimcache = getTempDir() / ("nimsuggest_cache_" &
extractFilename(result.dest).changeFileExt("") & (if epcMode: "_epc" else: "_stdin"))
removeDir(nimcache)
result.cmd.add " --nimcache:" & nimcache
# A few `sug` tests rank results by per-symbol usage counts. Under IC those counts
# are not serialized into the NIF files, so a cold start (which re-walks `system`
# and saturates the counts of common types) and a warm start (which loads `system`
# from NIF without re-walking it) order the results differently — e.g. `string`
# outranks `int`, or `seq` drops below `Slice`. The tester runs each test's stdio
# variant cold and its EPC variant warm against the shared on-disk NIFs, so for
# these order-sensitive tests the two disagree. Give only those a private, freshly
# wiped cache so both variants start cold and deterministic. Every other test keeps
# reusing the warm cache, which roughly halves the suite's wall-clock time (and
# keeps it under CI's job timeout).
const coldCacheTests = ["tsug_typedecl.nim", "ttype_decl.nim"]
if extractFilename(filename) in coldCacheTests:
let nimcache = getTempDir() / ("nimsuggest_cache_" &
extractFilename(result.dest).changeFileExt("") & (if epcMode: "_epc" else: "_stdin"))
removeDir(nimcache)
result.cmd.add " --nimcache:" & nimcache
# now that we know the markers, substitute them:
for a in mitems(result.script):
a[0] = a[0] % markers