mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-02-12 22:33:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixes #22696; func strutils.join for non-strings uses proc $ which can have side effects (#22770)

Browse Source 
fixes #22696
partially revert https://github.com/nim-lang/Nim/pull/16281

`join` calls `$` interally, which might introduce a sideeffect call.

(cherry picked from commit 5eeafbf550)
This commit is contained in:
ringabout
2023-09-30 12:27:27 +08:00
committed by narimiran
parent 567900be76
commit bb82d46ef1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/pure/strutils.nim
View File

@@ -1852,7 +1852,7 @@ func join*(a: openArray[string], sep: string = ""): string {.rtl,
else:
result = ""
func join*[T: not string](a: openArray[T], sep: string = ""): string =
proc join*[T: not string](a: openArray[T], sep: string = ""): string =
## Converts all elements in the container `a` to strings using `$`,
## and concatenates them with `sep`.
runnableExamples: