mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-04-19 22:10:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

DELETE requests should always have a content-length header (#16618)

Browse Source 
* DELETE requests should always have a content-length header

Not having DELETE in this list is causing hanging when trying to close webdriver sessions in [halonium](https://github.com/halonium/halonium/issues/10) and likely any other implementation of the webdriver protocol. Both at least chromedriver and geckodriver are affected by this issue.

* Change the content length calculation to match the http spec

For reference:
https://www.w3.org/Protocols/HTTP/1.0/draft-ietf-http-spec.html#Entity-Body
This commit is contained in:
Joey
2021-01-08 11:48:23 -07:00
committed by GitHub
parent 38b8d080f2
commit bfcb7c1621
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lib/pure/httpclient.nim
View File

@@ -980,8 +980,11 @@ proc requestAux(client: HttpClient | AsyncHttpClient, url, httpMethod: string,
var data: seq[string]
if multipart != nil and multipart.content.len > 0:
data = await client.format(multipart)
elif httpMethod in ["POST", "PATCH", "PUT"] or body.len != 0:
client.headers["Content-Length"] = $body.len
else:
if body.len != 0:
client.headers["Content-Length"] = $body.len
elif httpMethod notin ["GET", "HEAD"] and not client.headers.hasKey("Content-Length"):
client.headers["Content-Length"] = "0"
when client is AsyncHttpClient:
if not client.parseBodyFut.isNil: