mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-01-03 03:32:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix buffer-overrun bug in net (#17728) [backport:1.0]

Browse Source 
(cherry picked from commit fdd4391534)
This commit is contained in:
shirleyquirk
2021-04-16 13:22:51 +01:00
committed by narimiran
parent 286b94e7de
commit e5a3f30519
2 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelog.md
View File

@@ -17,6 +17,9 @@
## Library additions
- Fixed buffer overflow bugs in `net`
- Added `sections` iterator in `parsecfg`.
- Added `browsers.osOpen` const alias for the operating system specific *"open"* command.

7
lib/pure/net.nim
View File

@@ -598,12 +598,11 @@ when defineSsl:
let ctx = SslContext(context: ssl.SSL_get_SSL_CTX)
let hintString = if hint == nil: "" else: $hint
let (identityString, pskString) = (ctx.clientGetPskFunc)(hintString)
if psk.len.cuint > max_psk_len:
if pskString.len.cuint > max_psk_len:
return 0
if identityString.len.cuint >= max_identity_len:
return 0
copyMem(identity, identityString.cstring, pskString.len + 1) # with the last zero byte
copyMem(identity, identityString.cstring, identityString.len + 1) # with the last zero byte
copyMem(psk, pskString.cstring, pskString.len)
return pskString.len.cuint
@@ -624,7 +623,7 @@ when defineSsl:
max_psk_len: cint): cuint {.cdecl.} =
let ctx = SslContext(context: ssl.SSL_get_SSL_CTX)
let pskString = (ctx.serverGetPskFunc)($identity)
if psk.len.cint > max_psk_len:
if pskString.len.cint > max_psk_len:
return 0
copyMem(psk, pskString.cstring, pskString.len)