mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-06-14 23:53:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

system: remove unused exception raising code (#25894)

Browse Source 
...that otherwise causes an unnecessary raise effect on writeWindows /
echoBinSafe
This commit is contained in:
Jacek Sieka
2026-06-11 10:33:51 +02:00
committed by GitHub
parent 0448557bfe
commit eaa4b342be
1 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lib/system.nim
View File

@@ -3131,10 +3131,7 @@ when notJSnotNims:
not defined(nuttx) and
hostOS != "any"
proc raiseEIO(msg: string) {.noinline, noreturn.} =
raise newException(IOError, msg)
proc echoBinSafe(args: openArray[string]) {.compilerproc.} =
proc echoBinSafe(args: openArray[string]) {.compilerproc, raises: [].} =
when defined(androidNDK):
# When running nim in android app, stdout goes nowhere, so echo gets ignored
# To redirect echo to the android logcat, use -d:androidNDK
@@ -3156,7 +3153,7 @@ when notJSnotNims:
for s in args:
when defined(windows):
# equivalent to syncio.writeWindows
proc writeWindows(f: CFilePtr; s: string; doRaise = false) =
proc writeWindows(f: CFilePtr; s: string) =
# Don't ask why but the 'printf' family of function is the only thing
# that writes utf-8 strings reliably on Windows. At least on my Win 10
# machine. We also enable `setConsoleOutputCP(65001)` now by default.
@@ -3167,13 +3164,11 @@ when notJSnotNims:
if s[i] == '\0':
let w = c_fputc('\0', f)
if w != 0:
if doRaise: raiseEIO("cannot write string to file")
break
inc i
else:
let w = c_fprintf(f, "%s", unsafeAddr s[i])
if w <= 0:
if doRaise: raiseEIO("cannot write string to file")
break
inc i, w
writeWindows(cstdout, s)