mirrors/Nim
1
0
Fork 0
mirror of https://github.com/nim-lang/Nim.git synced 2026-01-10 23:15:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

memfiles.nim resizeFile fallback logic bug (#25408)

Browse Source 
`e` is not cleared when falling back to `ftruncate`

(cherry picked from commit 4b615aca46)
This commit is contained in:
Ryan McConnell
2026-01-03 12:08:12 -05:00
committed by narimiran
parent d1016a3bc9
commit f04fe4e4a3
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
lib/pure/memfiles.nim
View File

@@ -57,8 +57,12 @@ proc setFileSize(fh: FileHandle, newFileSize = -1, oldSize = -1): OSErrorCode =
when declared(posix_fallocate):
while (e = posix_fallocate(fh, 0, newFileSize); e == EINTR):
discard
if (e == EINVAL or e == EOPNOTSUPP) and ftruncate(fh, newFileSize) == -1:
result = osLastError() # fallback arguable; Most portable BUT allows SEGV
if e == EINVAL or e == EOPNOTSUPP or e == ENOSYS:
# fallback arguable; Most portable BUT allows SEGV
if ftruncate(fh, newFileSize) == -1:
result = osLastError()
else:
discard
elif e != 0:
result = osLastError()
else: # shrink the file