mark-summerfield
974b4d59b4
Nicer English ( #5511 )
2017-03-12 17:55:30 +01:00
mark-summerfield
c1ce20594e
Nicer English ( #5514 )
2017-03-12 17:49:48 +01:00
mark-summerfield
639f786e5d
Update tut1.rst ( #5510 )
...
In general: s/have to/must/g - but you can't do this mechanically because sometimes the must has to go back a word (e.g., line 519).
This looks really odd to me:
if thisIsaLongCondition() and
thisIsAnotherLongCondition(1,
2, 3, 4):
x = true
I would have expected:
if thisIsaLongCondition() and
thisIsAnotherLongCondition(
1, 2, 3, 4):
x = true
If the second form is valid and good Nim style then I suggest using it rather than the original. However, if the original is the preferred style then this should be mentioned in the text since it is unusual.
Since Nim is case-sensitive I think it is bad to write wrongly cased names, e.g., ``Bool`` is a built-in type on line 589. This isn't true since Bool isn't anything, but bool is. So in these cases I'd always reword to avoid this problem (and that's what I've done -- and it also avoids "bool. Bool" which was ugly).
2017-03-12 17:44:33 +01:00
mark-summerfield
3ab884a9e3
Suggested small change to code ( #5509 )
...
In a code example I think it best to either use full names (index, item) or abbreviated names where that's common (i, item) but not non-standard abbreviations (indx, itm). So I've changed it to index, item since it is a tutorial, although i, item would be just as good.
2017-03-12 17:40:14 +01:00
zah
1be0022e7c
Fixes #5167 and related problems ( #5475 )
...
This commit returns to a bit less strict checking of the number
of macro arguments, because some old immediate macros rely on a
behavior where even the arity of the macro is not being checked.
It may be better if such macros are just declared to use varargs[expr],
but this remains for another day.
2017-03-12 09:33:49 +01:00
zah
6e358e3187
don't allow casting to non-concrete types; fixes #5428 ( #5502 )
2017-03-12 09:27:05 +01:00
Anatoly Galiulin
cb9d554ac9
Fix typo ( #5501 )
2017-03-10 16:18:56 +01:00
Zahary Karadjov
62ef5dfec8
new debugging helper to replace and friends
2017-03-10 12:02:55 +02:00
konqoro
d1119c120d
Fix links to manual ( #5500 )
2017-03-09 22:37:44 +01:00
Dominik Picheta
42e54e5527
Merge pull request #5497 from ehmry/smtp
...
SMTP sync/async deduplication
2017-03-08 14:45:32 +00:00
Araq
0f63c101e4
fixes nimsuggest bug #45
2017-03-08 13:21:40 +01:00
Araq
0596c11775
todo updates
2017-03-08 13:04:40 +01:00
Araq
1887390b0f
nimsuggest: fixes nimsuggest bug #45 ; do not show suggestions in string literals or comments
2017-03-08 12:53:21 +01:00
Araq
23a303c536
nimsuggest: update documentation
2017-03-08 12:44:57 +01:00
Andreas Rumpf
507feb3ce5
Merge branch 'devel' into faster-nimsuggest
2017-03-08 00:39:13 +01:00
Andreas Rumpf
91a4b448fd
nimsuggest: chk checks the full project lazily; much better suggestions orderings
2017-03-08 00:38:48 +01:00
Emery Hemingway
fecad72e02
SMTP sync/async deduplication
...
Deduplicate synchronous and asynchronous code with the multisync pragma.
Pass address and port at connect rather than ``new(Async)Smtp``.
2017-03-07 12:10:18 -06:00
David Krause
7dc8dcb581
fixes #5487 ( #5494 )
2017-03-07 16:58:38 +01:00
Andreas Rumpf
538c6c9898
make some tests green
2017-03-07 12:34:45 +01:00
Dominik Picheta
b46f23d7cc
Merge pull request #5496 from Calinou/readme_typo_fix
...
Fix typo in readme.md (there is no "build-essentials" package in Debian)
2017-03-07 11:33:36 +00:00
Hugo Locurcio
9e170f1159
Fix typo in readme.md (there is no "build-essentials" package in Debian)
2017-03-07 12:20:17 +01:00
Andreas Rumpf
9ed322323e
nimsuggest: better ordering of symbols (part 1)
2017-03-07 10:58:43 +01:00
Andreas Rumpf
d9ad6465af
nimsuggest: bugfix: don't intertwine errors and suggestions
2017-03-07 10:42:46 +01:00
Andrea Griffini
c2630b338d
Typo ( #5495 )
2017-03-07 10:01:07 +01:00
Ruslan Mustakov
9608acf200
Check if __STDC_VERSION__ is defined ( #5488 )
2017-03-07 09:56:46 +01:00
Anatoly Galiulin
24ec36f097
Fix iconv import on freebsd and netbsd ( #5490 )
2017-03-07 09:56:16 +01:00
Araq
3fa428c88b
fixes #5467
2017-03-07 00:27:47 +01:00
Araq
4a77b66b19
fixes #5478
2017-03-06 18:38:15 +01:00
Araq
8c0e27e8d9
fixes #5481
2017-03-06 18:25:27 +01:00
David Krause
643b7f8650
Fix for #5482 , let OrderedTable accept multiple keys ( #5485 )
2017-03-05 20:17:43 +01:00
Fabian Keller
d1d32f657a
tiny docstring fix; fixes #5483 ( #5484 )
2017-03-05 10:44:25 +01:00
Florent
93305443aa
close #5472 nre tests should be run ( #5474 )
...
nre tests were just being compiled - changed so that a failure causes exit code to defer causing `tester` to report it as a failure
2017-03-04 11:13:08 +01:00
Dominik Picheta
52462f031e
Merge pull request #5473 from raydf/devel
...
Only remove scheme when there's a TLS request ("https")
2017-03-03 19:52:47 +00:00
Rayner De Los Santos F
d5d975ceef
Only remove scheme when there's a TLS request ("https")
...
If condition, for not removing the scheme when proxied connection isn't a TLS request ("http://...").
2017-03-03 08:47:13 -04:00
Andreas Rumpf
5d125ca716
Merge branch 'devel' into faster-nimsuggest
2017-03-03 13:00:09 +01:00
Andreas Rumpf
3b0430bec6
nimsuggest: minor doc addition
2017-03-03 12:59:32 +01:00
Andreas Rumpf
6c0304f7f5
nimsuggest chk works for EPC
2017-03-03 11:59:00 +01:00
Andreas Rumpf
50835257d6
code cleanup and debugging stuff
2017-03-03 10:19:49 +01:00
Andreas Rumpf
a9c1afd5fd
nimsuggest: structured error reporting; EPC mode still fails
2017-03-03 02:13:16 +01:00
Simon Krauter
a42801d100
Make countLines() the same as len(splitLines(s)) ( #5470 )
...
The result of countLines() is now increased by 1 compared to the old
version.
Fixes #5460 .
2017-03-03 01:31:17 +01:00
Florent
f7af16a1c9
More robust tests for #5453 ( #5469 )
2017-03-03 01:30:49 +01:00
Ruslan Mustakov
a81247dcbe
Add compute proc for SharedTable ( #5385 )
2017-03-02 15:31:30 +01:00
Fabian Keller
e2567e2e03
Fix sigsegv in getTypeImpl for unnamed tuple ( #5440 )
...
avoid sigsegv in getTypeImpl for unnamed tuple; fixes #4862
2017-03-02 15:30:19 +01:00
Yuriy Glukhov
73387e89a0
Fixed compilation error ( #5462 )
2017-03-02 14:58:26 +01:00
Rokas Kupstys
cd2721242a
Fix waiting on coroutines ( #5463 )
...
Public coroutine API returns a safe reference to specific running coroutine. Fixes bug where multiple coroutines executing same procedure would identify as same coroutine.
Greatly optimizes `alive()` (and as a result of that `wait()`) calls.
Coroutine struct is allocated together with stack as memory unmanaged by GC.
2017-03-02 14:53:50 +01:00
Andreas Rumpf
3e7b04683c
make tests green again
2017-03-02 12:23:35 +01:00
Florent
34a3d40d18
fixes #5444 - nre.findIter keeps searching when no match is possible ( #5453 )
2017-03-02 11:48:41 +01:00
Ruslan Mustakov
32159ee827
Ignore pointer-bool-conversion warning ( #5468 )
2017-03-02 08:55:17 +01:00
Florent
9965123098
Fixes #5457 - StdLib base64 encodeInternal crashes with out of bound exception ( #5464 )
2017-03-02 08:54:45 +01:00
Dominik Picheta
37abcf18f8
Merge pull request #5466 from yglukhov/asynchttpserver-bad-content-length
...
Dont assert on malformed requests
2017-03-01 19:14:02 +00:00