ee7 3b1a601fe1
sequtils: fix errors from strictFuncs use ( #18998 ) ...
Nim 1.4.x compiled the below code without error when using
`--experimental:strictFuncs`
import std/sequtils
type Foo = ref object
let foo1 = Foo()
let foo2 = Foo()
let foos = @[foo1, foo2]
let fooTuples = @[(foo1, 1), (foo2, 2)]
discard repeat(foo1, 3)
discard zip(foos, foos)
discard unzip(fooTuples)
However, since 2020-12-09, devel Nim produced errors like
/tmp/bar.nim(11, 15) template/generic instantiation of `repeat` from here
/foo/nim/pure/collections/sequtils.nim(172, 6) Error: 'repeat' can have side effects
an object reachable from 'x' is potentially mutated
/foo/nim/pure/collections/sequtils.nim(183, 15) the mutation is here
/foo/nim/pure/collections/sequtils.nim(183, 15) is the statement that connected the mutation to the parameter
This commit reverts some `proc` to `func` changes so that code that:
- calls `repeat`, `zip`, or `unzip`
- and instantiates them with types containing `ref`
can once again be compiled with `strictFuncs`. Otherwise, a user might
be forced to drop or alter their `strictFuncs` use when upgrading from
Nim 1.4.x, or when writing new code that uses these procedures (at least
for now, with the current `strictFuncs` implementation).
This commit also adds tests to assert that the remaining funcs in this
module can be compiled with `strictFuncs` when used with types
containing `ref`.
The original batch of `proc` to `func` changes in `sequtils.nim` was in
commit 6f57ebae3438eb021f81https://github.com/nim-lang/Nim/issues/16305
2021-10-16 11:25:05 +02:00
2021-09-20 09:50:20 +02:00
2020-12-27 14:45:57 +01:00
2019-04-05 15:27:04 +02:00
2021-04-02 13:11:03 +02:00
2021-06-19 11:24:46 -07:00
2020-11-20 08:07:51 +01:00
2017-09-16 19:09:44 +01:00
2020-03-30 13:45:32 +02:00
2018-11-26 10:28:44 +01:00
2018-10-28 13:34:57 +01:00
2020-10-29 18:12:14 +01:00
2018-12-11 21:23:21 +01:00
2020-11-13 16:15:13 +08:00
2020-12-14 10:58:29 +01:00
2020-12-28 14:13:21 +01:00
2020-11-05 14:00:49 +01:00
2021-03-23 10:49:02 +01:00
2021-04-21 19:47:01 +02:00
2021-05-29 12:44:39 -07:00
2020-04-05 21:16:13 +02:00
2021-05-07 17:40:16 -07:00
2021-02-15 21:17:45 +01:00
2021-01-07 19:16:26 +01:00
2020-12-27 19:46:21 +01:00
2021-02-18 08:26:50 +01:00
2021-01-05 17:50:15 +01:00
2021-02-24 10:14:19 +01:00
2020-12-28 14:13:21 +01:00
2021-04-04 13:47:28 -07:00
2021-01-05 17:52:26 +01:00
2021-08-11 12:17:17 +02:00
2020-12-17 13:41:05 +01:00
2021-04-07 14:17:48 +02:00
2020-11-28 11:59:08 -08:00
2020-12-28 14:13:21 +01:00
2021-04-29 09:51:54 +02:00
2020-12-28 14:13:21 +01:00
2021-03-10 08:08:24 -08:00
2020-06-16 11:43:48 +02:00
2020-06-15 13:27:33 +02:00
2020-06-15 13:27:33 +02:00
2021-01-05 20:51:51 +01:00
2021-02-17 19:27:48 +01:00
2021-04-02 13:11:03 +02:00
2020-04-24 09:18:44 +02:00
2021-07-27 09:36:19 +02:00
2021-05-31 13:39:19 +02:00
2021-07-17 07:54:47 +02:00
2021-10-04 21:28:13 +02:00
2021-02-15 13:57:15 +01:00
2021-05-06 10:58:01 +02:00
2020-12-28 14:13:21 +01:00
2020-03-20 17:11:39 +01:00
2020-03-20 17:11:39 +01:00
2021-02-08 13:54:03 +01:00
2021-06-30 10:22:38 -07:00
2021-01-22 15:04:52 +01:00
2020-12-28 14:13:21 +01:00
2021-06-19 11:24:46 -07:00
2020-11-20 08:07:51 +01:00
2021-02-22 20:13:08 +01:00
2021-03-26 13:05:51 +01:00
2021-04-13 09:33:28 +02:00
2021-07-20 22:13:52 +02:00
2018-11-23 11:58:28 +01:00
2018-12-11 21:23:21 +01:00
2021-01-25 18:35:08 -08:00
2018-11-23 11:58:28 +01:00
2021-07-20 22:13:52 +02:00
2021-03-03 11:58:50 +01:00
2021-04-06 16:21:58 +02:00
2020-09-14 08:57:49 +02:00
2021-06-05 06:58:26 +02:00
2021-02-24 22:17:16 +00:00
2021-08-19 11:35:40 +02:00
2020-12-28 14:13:21 +01:00
2018-12-11 21:23:21 +01:00
2018-07-06 17:27:02 +02:00
2018-11-23 11:58:28 +01:00
2021-04-24 07:54:31 +02:00
2018-12-11 21:23:21 +01:00
2020-12-29 13:27:08 +01:00
2018-11-23 11:58:28 +01:00
2021-07-05 10:12:58 -07:00
2020-03-25 19:15:34 +01:00
2021-06-07 13:57:42 +02:00
2020-11-23 19:53:57 +01:00
2021-02-22 11:09:25 +01:00
2021-05-31 13:39:19 +02:00
2020-11-28 09:09:31 +01:00
2021-08-08 19:11:07 +01:00
2020-06-15 13:27:33 +02:00
2021-03-27 10:22:42 +01:00
2021-04-24 07:54:31 +02:00
2020-12-27 14:45:57 +01:00
2021-01-07 09:38:31 +01:00
2021-07-16 15:50:02 +02:00
2021-02-24 22:17:16 +00:00
2019-05-16 21:06:04 +02:00
2021-08-12 16:50:08 +02:00
2021-09-29 09:32:39 +02:00
2021-05-02 00:26:41 +02:00
2021-03-07 12:08:41 +01:00
2020-11-13 14:12:51 +01:00
2021-03-28 09:57:40 -07:00
2020-11-24 19:06:41 +01:00
2021-08-08 19:11:07 +01:00
2020-04-28 19:44:52 +02:00
2020-12-27 14:45:57 +01:00
2021-08-16 15:14:35 +02:00
2020-12-28 14:13:21 +01:00
2021-10-04 21:27:13 +02:00
2018-11-23 11:58:28 +01:00
2021-02-20 18:08:13 +01:00
2020-12-28 14:13:21 +01:00
2021-01-22 19:51:11 +01:00
2021-09-02 14:12:14 +02:00
2021-02-06 17:33:11 +01:00
2021-06-10 18:26:58 +02:00
2018-12-11 21:23:21 +01:00
2021-03-29 10:50:58 +02:00
2021-07-27 19:50:59 +02:00
2020-10-18 12:57:13 -04:00
2021-02-22 19:58:37 +01:00
2021-10-06 13:53:01 +02:00
2021-07-20 08:32:22 +02:00
2021-10-16 11:25:05 +02:00
2021-03-08 10:39:39 +01:00
2021-07-15 22:13:01 +02:00
2021-06-16 11:31:20 +02:00
2020-12-28 14:13:21 +01:00
2021-08-11 12:17:17 +02:00
2021-01-07 16:09:57 +01:00
2018-11-23 11:58:28 +01:00
2021-08-12 09:21:01 -07:00
2018-12-11 21:23:21 +01:00
2020-10-26 03:10:38 +02:00
2020-10-05 12:00:06 +02:00
2020-05-19 09:41:31 +02:00
2021-08-23 00:13:39 +02:00
2020-04-28 19:56:01 +02:00
2021-09-02 12:10:14 +02:00
2021-03-02 12:53:05 +01:00
2020-12-18 16:45:51 +01:00
2021-04-12 07:32:37 +02:00
2021-02-24 13:47:36 +01:00
2020-11-24 19:06:41 +01:00
2020-12-12 23:29:20 +01:00
2017-09-30 21:35:30 +02:00
2021-07-19 12:43:31 +02:00
2020-12-28 14:13:21 +01:00
2020-08-09 14:12:53 +02:00
2020-06-10 14:10:57 +02:00
2021-07-18 11:10:08 +02:00
2021-02-09 13:04:36 +01:00
2020-12-28 14:13:21 +01:00
2021-03-15 10:21:25 +01:00
2021-07-18 15:16:26 +02:00
2020-12-28 14:13:21 +01:00
2021-04-09 11:51:51 +02:00
2021-07-18 11:04:19 +02:00
2020-07-12 03:31:03 -04:00
2020-11-10 09:23:58 +08:00
2020-10-13 17:39:32 +01:00
2021-05-08 17:13:47 +02:00
2021-03-08 14:37:52 +01:00
2021-03-11 16:32:50 +01:00
2020-12-28 14:13:21 +01:00
2021-03-29 14:22:29 +02:00
2021-06-21 12:50:47 +02:00
2020-11-27 12:41:22 +08:00
2020-07-14 13:14:32 +02:00
2021-02-24 21:02:33 +01:00
2018-05-28 05:24:04 +03:00
2020-12-27 09:16:53 +01:00
2020-02-11 21:33:06 +01:00
2021-05-09 23:33:31 +02:00
2021-04-17 11:48:22 +02:00
2021-02-24 13:44:10 +01:00
2021-05-31 13:39:19 +02:00
2021-06-24 11:55:31 +02:00
2018-04-30 11:16:56 +02:00
2020-11-27 20:47:49 +01:00
2020-11-27 20:47:49 +01:00
2021-07-08 10:21:30 +08:00
2020-12-28 14:13:21 +01:00
2021-09-02 07:41:14 +02:00
2021-05-15 06:50:39 +02:00
3b1a601fe1