ringabout 2b2872928b fixes #25469; Conversion from distinct in for forces a copy of underlying instance (#25746) ...

fixes #25469

This pull request introduces an important fix to argument handling in
the compiler's transformation logic and adds a new test to verify
correct behavior with distinct types and ARC memory management.

### Compiler transformation improvements

* Updated `putArgInto` in `compiler/transf.nim` to handle
`nkHiddenStdConv`, `nkHiddenSubConv`, and `nkConv` nodes more
accurately. Now, if the types match (ignoring distinctness and shallow
range differences), the argument is recursively processed; otherwise, it
falls back to a fast assignment. This prevents incorrect assignments
when dealing with type conversions and distinct types.

### Testing for distinct types and ARC

* Added a new test `tdistinct_for_nodup.nim` to ensure correct iteration
and memory management for distinct sequences of large arrays under ARC.
The test checks that the sequence length remains unchanged during
iteration, helping catch regressions related to ARC and distinct types.

2026-04-17 09:59:22 +02:00

..

amodule.nim

Add a test-case for #12990 (#15072)

2020-07-25 20:35:20 +02:00

bmodule.nim

Add testcase for #14864 (#14928)

2020-07-07 22:43:36 +02:00

cmodule.nim

Add testcase for #14864 (#14928)

2020-07-07 22:43:36 +02:00

dmodule.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

m24764.nim

fixes #24764; cross-module sink analysis broken (#24862)

2025-04-12 06:47:57 +02:00

nim.cfg

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

t9650.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

t14383.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

t14472.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

t14864.nim

Add testcase for #14864 (#14928)

2020-07-07 22:43:36 +02:00

t15909.nim

Fix #15909 (#15914)

2020-11-12 09:28:32 +01:00

t16033.nim

fix #16033 nim js --gc:arc works and ignores --gc:arc (#16036)

2020-11-18 23:28:52 +01:00

t16458.nim

fix #16458; make useNimRtl compile for --gc:orc (#19512)

2022-02-11 11:16:27 +01:00

t16558.nim

Update message for checking cast (#20145)

2022-09-28 13:59:27 +02:00

t17025.nim

ARC Analysis in one pass v3 (#17068)

2021-02-17 14:17:35 +01:00

t17173.nim

deprecate newruntime (#17245)

2021-03-04 19:33:16 +01:00

t17812.nim

fixes #22175 (#22229)

2023-07-06 15:15:50 +02:00

t18645.nim

[ARC] fixes #18645; C Compiler error when initializing {.global.} with a block (#19953)

2022-10-03 16:12:23 +02:00

t18971.nim

fix #18971 (#19070) [backport:1.6]

2021-10-29 19:55:48 +02:00

t18977.nim

fix #18977; disallow change branch of an object variant in ORC (#21526)

2023-03-16 16:06:26 +01:00

t19231.nim

fixes #19231; newFinalize doesn't work with ORC (#20291)

2022-10-05 10:35:40 +02:00

t19364.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

t19401.nim

fixes #19401; fixes #19402; rework Forward declaration and finalizer for ORC (#20295)

2022-09-27 20:07:26 +02:00

t19402.nim

fixes #19401; fixes #19402; rework Forward declaration and finalizer for ORC (#20295)

2022-09-27 20:07:26 +02:00

t19435.nim

fix #19435; don't create TypeBoundOps for tyOpenArray, tyVarargs [backport: 1.6] (#19723)

2022-04-25 11:07:55 +02:00

t19457.nim

fixes #24879; Data getting wiped on copy with iterators and =copy on refc (#24880)

2025-04-16 22:51:12 +02:00

t19862.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

t20456.nim

fixes nim check with orc (#20456)

2022-10-02 06:44:10 +02:00

t20588.nim

fixes #14255; Crash in compiler when using system.any by accident. (#21562)

2023-03-23 16:10:14 +01:00

t21184.nim

fixes #21171; dynamic acyclic refs need to use dyn decRef (#21184)

2022-12-28 16:23:37 +01:00

t22218.nim

fixes #22218; avoids cursor when copy is disabled (#23209)

2024-01-18 21:47:13 +01:00

t22237.nim

fixes #22237; fixes #21160; wrong cursor on unowned parameters in the for loop in ORC (#22240)

2023-07-10 10:31:13 +02:00

t22478.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

t22787.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

t23247.nim

closes #24992; adds a test case (#24993)

2025-06-12 21:47:41 +08:00

t24402.nim

fixes #24402; Memory leak under Arc/Orc on inline iterators with nested seq (#24419)

2024-11-12 22:57:31 +01:00

t24760.nim

fixes #24760; Noncopyable base type ignored (#24777)

2025-09-22 10:50:57 +02:00

t24764.nim

fixes #24764; cross-module sink analysis broken (#24862)

2025-04-12 06:47:57 +02:00

t24806.nim

fixes #24806; don't elide wasMoved when syms are used in blocks (#24831)

2025-04-03 12:54:00 +02:00

taliased_reassign.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tamemfiles.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tamodule.nim

Add a test-case for #12990 (#15072)

2020-07-25 20:35:20 +02:00

tarc_macro.nim

fixes regression #22909; don't optimize result init if statements can raise which corrupts the compiler (#23271)

2024-02-01 16:51:07 +01:00

tarc_orc.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tarcmisc.nim

fixes #25236; broken assignment hooks of union inside variant object in orc (#25238)

2025-10-21 16:59:22 +02:00

tasyncawait.nim

make proc names consistent (#18626)

2021-08-01 12:52:24 +01:00

tasyncleak2.nim

use typeof instead type (#16962)

2021-02-08 09:46:07 +01:00

tasyncleak3.nim

harden the ORC asyncleak3 test case (#15580)

2020-10-15 09:42:43 +02:00

tasyncleak4.nim

fixes #15076 (#16143)

2020-11-26 10:24:52 +01:00

tasyncleak.nim

fixes #23212; Asyncdispatch leaks under --mm:arc (#24556)

2024-12-22 07:56:22 +01:00

tasyncorc.nim

fix #15631 (#15632)

2020-10-19 22:25:43 +02:00

tcaseobj.nim

fix compiler crash with uncheckedAssign and range/distinct discrims [backport] (#25585)

2026-03-07 07:39:57 +01:00

tcaseobjcopy.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tclosureiter.nim

fixes a closure iterator memory leaks, progress on #15076

2020-07-27 13:07:09 +02:00

tcomputedgoto.nim

fixes #22866; fixes #19998; ensure destruction for Object construction with custom destructors (#22901)

2023-11-02 11:14:50 +01:00

tcomputedgotocopy.nim

fixes #22866; fixes #19998; ensure destruction for Object construction with custom destructors (#22901)

2023-11-02 11:14:50 +01:00

tconst_to_sink.nim

fix #18410 (Errors initializing an object of RootObj with the C++ backend) [backport] (#18836)

2021-10-31 06:22:00 +01:00

tcontrolflow.nim

fix controlflow test (#22194)

2023-06-30 14:54:46 +02:00

tcursor_field_obj_constr.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tcursor_on_localvar.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tcursorloop.nim

dec inLoop after exiting the while scope in computeLiveRanges [backport] (#19918)

2022-06-29 22:37:24 +08:00

tcustomtrace.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tdeepcopy.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tdestroy_in_loopcond.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tdestructor_order.nim

fixes #24719; improves order of destruction (#25060)

2025-07-18 23:02:16 +08:00

tdistinct_for_nodup.nim

fixes #25469; Conversion from distinct in for forces a copy of underlying instance (#25746)

2026-04-17 09:59:22 +02:00

tdup.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

testfile.txt

fixes #13596 (#13612)

2020-03-09 15:32:38 +01:00

texceptions.nim

close #13071 by adding test: nim cpp -r --gc:arc` segfaults on caught AssertionError (#14323)

2020-05-12 19:19:31 +02:00

texplicit_sink.nim

fixes #20572 (#20585)

2022-10-17 23:48:51 +02:00

tfuncobj.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tgenerics.nim

closes #23394; adds a test case (#25416)

2026-01-07 09:32:25 +01:00

thamming_orc.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

thamming_thinout.nim

cycle collector (#14071)

2020-04-22 17:34:35 +02:00

thard_alignment.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

thavlak_orc_stress.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

theavy_recursion.nim

fixes #15122 (#15301)

2020-09-11 01:50:42 +02:00

timportedobj.nim

new feature: --staticBoundChecks:on to enforce static array index checking (#10965)

2020-03-18 14:25:10 +01:00

tinvalidenumtostr.nim

account for invalid data in enum $ on arc/orc (#24886)

2025-04-18 05:32:49 +02:00

titeration_doesnt_copy.nim

fixes #23982; codegen regression passing pointer expressions to inline iterators (#23986)

2024-08-20 19:09:06 +08:00

tkeys_lent.nim

fixes #18565 (#18593)

2021-07-27 09:36:19 +02:00

tmalloc.nim

fixes #22058; invalid free with {.noSideEffect.} in template (#22088)

2023-06-13 12:03:20 +02:00

tmarshal.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tmove_regression.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tmovebug.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tmovebugcopy.nim

style usages part one (openarray => openArray) (#19321)

2022-01-04 13:29:50 +01:00

tnewseq_legacy.nim

ARC: fixes memory leaks with newSeq used in a loop [backport:1.4] (#18040)

2021-05-18 21:45:37 +02:00

tnodestroyexplicithook2.nim

make explicit copy and hook calls keep their symbol (#25731)

2026-04-12 07:05:48 +02:00

tnodestroyexplicithook.nim

always mangle local variables (#24681)

2025-02-19 23:03:58 +01:00

top_no_cursor2.nim

fixes #15361 (#15401)

2020-09-24 15:41:45 +02:00

topenarray.nim

fixes #20865; fixes #20987; Missing bounds check in array slicing (#23814)

2024-07-10 17:25:34 +02:00

topt_cursor2.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

topt_cursor.nim

fixes #24850; macro-generated if/else and when/else statements have m… (#24852)

2025-04-08 23:54:31 +08:00

topt_no_cursor.nim

fixes #24850; macro-generated if/else and when/else statements have m… (#24852)

2025-04-08 23:54:31 +08:00

topt_refcursors.nim

fixes #19291; implements wasMoved hook (#21303)

2023-03-02 05:29:40 +01:00

topt_wasmoved_destroy_pairs.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

torc_basic_test.nim

added a basic ORC test I still had lying around (#15376)

2020-09-20 22:47:48 +02:00

torc_selfcycles.nim

fixes #15753 [backport:1.4] (#15971)

2020-11-15 15:47:42 +01:00

torcbench.nim

yrc progress (#25534)

2026-02-23 13:39:55 +01:00

torcmisc.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tpartialtupleunpacking1.nim

generate let _ = to fully unpack partial tuple unpacking assignment for arc (#24948)

2025-05-15 09:32:10 +02:00

tpartialtupleunpacking2.nim

generate let _ = to fully unpack partial tuple unpacking assignment for arc (#24948)

2025-05-15 09:32:10 +02:00

tphantomgeneric1.nim

always reinstantiate nominal values of generic instantiations (#24425)

2024-11-16 10:48:01 +01:00

tphantomgeneric2.nim

always reinstantiate nominal values of generic instantiations (#24425)

2024-11-16 10:48:01 +01:00

tref_cast_error.nim

Update message for checking cast (#20145)

2022-09-28 13:59:27 +02:00

trepr.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

trtree.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tshared_ptr_crash.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tstrformat.nim

make megatest consistent with unjoined tests wrt newlines, honor newlines in output spec (#16151)

2020-11-28 09:09:31 +01:00

tstringliteral.nim

fix string literal assignment with different lengths on ARC (#24083)

2024-09-08 20:17:26 +02:00

tthread.nim

scoped memory management (#14790)

2020-07-04 07:37:24 +02:00

tunref_cycle.nim

fixes #18579 (#18600)

2021-07-27 14:32:56 +02:00

tvalgrind.nim

implements quirky for functions (#24700)

2025-02-18 17:24:41 +01:00

tweave.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

tweavecopy.nim

fixes strictdefs warnings continue (#24520)

2024-12-13 15:04:49 +01:00

twrong_sinkinference.nim

'lock levels' are deprecated, now a noop (#20539)

2022-10-11 09:17:09 +02:00