mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-04-20 05:20:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6046 from laytan/use-readfile-for-console-too

Browse Source 
os/os2: use ReadFile for Console reads too, at least for now
This commit is contained in:
Laytan
2025-12-20 21:18:44 +01:00
committed by GitHub
parent 40267e3a7a 67177db0a8
commit 00ede472e3
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
core/os/os2/file_windows.odin
View File

@@ -372,7 +372,10 @@ _read_internal :: proc(f: ^File_Impl, p: []byte) -> (n: i64, err: Error) {
to_read := min(win32.DWORD(length), MAX_RW)
switch f.kind {
case .Console:
total_read, err = read_console(handle, p[total_read:][:to_read])
// NOTE(laytan): at least for now, just use ReadFile, it seems to work fine,
// but, there may be issues with certain situations that we need to get reproductions for.
// total_read, err = read_console(handle, p[total_read:][:to_read])
fallthrough
case .Pipe, .File:
single_read_length: win32.DWORD
ok := win32.ReadFile(handle, &p[total_read], to_read, &single_read_length, nil)