mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-08-27 23:41:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve error message for which status flags were not set but expected.

Browse Source
This commit is contained in:
gingerBill
2026-08-25 11:21:57 +01:00
parent 173443cdd1
commit 160a5ffe5c
1 changed files with 25 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/check_asm_cfg.cpp
View File

@@ -578,11 +578,32 @@ gb_internal void check_asm_cfg_analyse(AsmCtx *asm_ctx, AsmCfg *cfg, CheckerCont
u16 undef_flags = f->read_flags & ~run_flags & ~reported_flags;
if (undef_flags != 0) {
error(instr->name,
"'%.*s' reads a status flag that is not set on all paths reaching here; "
"a flag-setting instruction (e.g. 'cmp', 'test') must precede it on every path",
LIT(f->name));
reported_flags |= undef_flags;
gbString flag_strs = gb_string_make(heap_allocator(), "");
defer (gb_string_free(flag_strs));
isize count = 0;
for (u16 bit = 1; bit != 0; bit <<= 1) {
if (bit & undef_flags) {
if (count++ > 0) {
flag_strs = gb_string_appendc(flag_strs, ", ");
}
char const *f = asm_ctx->clobber_flag_bit_name(bit);
flag_strs = gb_string_appendc(flag_strs, "%flags.");
flag_strs = gb_string_appendc(flag_strs, f);
}
}
char const *plural = "a status flag";
if (count > 0) {
plural = "status flags";
}
error(instr->name,
"'%.*s' reads %s (%s) that is not set on all paths reaching here; "
"a flag-setting instruction (e.g. 'cmp', 'test') must precede it on every path",
LIT(f->name), plural, flag_strs);
}
for (Entity *pe : f->read_params) {