mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-05-02 11:04:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix duplicate code emission in type assertions.

Browse Source
This commit is contained in:
miere43
2025-12-03 21:16:18 +03:00
parent 09e516ef68
commit 29019d7138
4 changed files with 40 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/llvm_backend_expr.cpp
View File

@@ -5785,11 +5785,11 @@ gb_internal lbAddr lb_build_addr_internal(lbProcedure *p, Ast *expr) {
if (is_type_union(t)) {
Type *type = type_of_expr(expr);
lbAddr v = lb_add_local_generated(p, type, false);
lb_addr_store(p, v, lb_emit_union_cast(p, lb_build_expr(p, ta->expr), type, pos));
lb_addr_store(p, v, lb_emit_union_cast(p, e, type, pos));
return v;
} else if (is_type_any(t)) {
Type *type = type_of_expr(expr);
return lb_emit_any_cast_addr(p, lb_build_expr(p, ta->expr), type, pos);
return lb_emit_any_cast_addr(p, e, type, pos);
} else {
GB_PANIC("TODO(bill): type assertion %s", type_to_string(e.type));
}

1
tests/issues/run.bat
View File

@@ -25,6 +25,7 @@ set COMMON=-define:ODIN_TEST_FANCY=false -file -vet -strict-style
..\..\..\odin build ..\test_issue_5097.odin %COMMON% || exit /b
..\..\..\odin build ..\test_issue_5097-2.odin %COMMON% || exit /b
..\..\..\odin build ..\test_issue_5265.odin %COMMON% || exit /b
..\..\..\odin test ..\test_issue_5699.odin %COMMON% || exit /b
@echo off

1
tests/issues/run.sh
View File

@@ -32,6 +32,7 @@ $ODIN build ../test_issue_5043.odin $COMMON
$ODIN build ../test_issue_5097.odin $COMMON
$ODIN build ../test_issue_5097-2.odin $COMMON
$ODIN build ../test_issue_5265.odin $COMMON
$ODIN test ../test_issue_5699.odin $COMMON
set +x

36
tests/issues/test_issue_5699.odin Normal file
View File

@@ -0,0 +1,36 @@
// Tests issue #5699 https://github.com/odin-lang/Odin/issues/5699
package test_issues
import "core:testing"
Issue5699_Value :: struct {
value: i32,
}
Issue5699_Result :: union {
Issue5699_Value,
}
test_issue_5699_increment_union :: proc(counter: ^i32) -> Issue5699_Result {
counter^ += 1
return Issue5699_Value{0}
}
@test
test_issue_5699_union :: proc(t: ^testing.T) {
counter: i32 = 0
_ = test_issue_5699_increment_union(&counter).(Issue5699_Value).value
testing.expectf(t, counter == 1, "\n\texpected: 1\n\tgot: %d", counter)
}
test_issue_5699_increment_any :: proc(counter: ^i32) -> any {
counter^ += 1
return Issue5699_Value{0}
}
@test
test_issue_5699_any :: proc(t: ^testing.T) {
counter: i32 = 0
_ = test_issue_5699_increment_any(&counter).(Issue5699_Value).value
testing.expectf(t, counter == 1, "\n\texpected: 1\n\tgot: %d", counter)
}