mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-01-02 03:02:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure NaN != any_float_value evaluates to true for constant NaN values

Browse Source
This commit is contained in:
mtarik34b
2025-04-15 05:00:36 +02:00
parent 11da543f26
commit 313d7d84bc
2 changed files with 36 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/exact_value.cpp
View File

@@ -955,7 +955,7 @@ gb_internal bool compare_exact_values(TokenKind op, ExactValue x, ExactValue y)
f64 a = x.value_float;
f64 b = y.value_float;
if (isnan(a) || isnan(b)) {
return false; // Fixes #5004
return op == Token_NotEq; // Fixes #5004
}
switch (op) {

56
tests/internal/test_5004_nan_constant_comparison.odin
View File

@@ -4,30 +4,44 @@ import "core:testing"
@(test)
compare_constant_nans_f32 :: proc(t: ^testing.T) {
NaN :: f32(0h7fc0_0000)
NaN2 :: f32(0h7fc0_0001)
NaN :: f32(0h7fc0_0000)
NaN2 :: f32(0h7fc0_0001)
Inf :: f32(0h7F80_0000)
Neg_Inf :: f32(0hFF80_0000)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != NaN, false)
testing.expect_value(t, NaN != NaN2, false)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != 0, true)
testing.expect_value(t, NaN != 5, true)
testing.expect_value(t, NaN != -5, true)
testing.expect_value(t, NaN != NaN, true)
testing.expect_value(t, NaN != NaN2, true)
testing.expect_value(t, NaN != Inf, true)
testing.expect_value(t, NaN != Neg_Inf, true)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}
@(test)
compare_constant_nans_f64 :: proc(t: ^testing.T) {
NaN :: f64(0h7fff_0000_0000_0000)
NaN2 :: f64(0h7fff_0000_0000_0001)
NaN :: f64(0h7fff_0000_0000_0000)
NaN2 :: f64(0h7fff_0000_0000_0001)
Inf :: f64(0h7FF0_0000_0000_0000)
Neg_Inf :: f64(0hFFF0_0000_0000_0000)
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != NaN, false)
testing.expect_value(t, NaN != NaN2, false)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}
testing.expect_value(t, NaN == NaN, false)
testing.expect_value(t, NaN == NaN2, false)
testing.expect_value(t, NaN != 0, true)
testing.expect_value(t, NaN != 5, true)
testing.expect_value(t, NaN != -5, true)
testing.expect_value(t, NaN != NaN, true)
testing.expect_value(t, NaN != NaN2, true)
testing.expect_value(t, NaN != Inf, true)
testing.expect_value(t, NaN != Neg_Inf, true)
testing.expect_value(t, NaN < NaN, false)
testing.expect_value(t, NaN <= NaN, false)
testing.expect_value(t, NaN > NaN, false)
testing.expect_value(t, NaN >= NaN, false)
}