mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-06-03 17:24:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: flysand7 <yyakut.ac@gmail.com>
This commit is contained in:
Simon Cruanes
2024-09-21 21:08:35 -04:00
committed by GitHub
parent d08b3d3b82
commit 32e13f17ae
2 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
core/time/rfc3339.odin
View File

@@ -204,8 +204,8 @@ time_to_rfc3339 :: proc(time: Time, utc_offset : int = 0, include_nanos := true,
if datetime.year < 0 || datetime.year >= 10_000 { return "", false }
temp_string := [30]u8{}
offset : uint = 0 // offset in temp_string
temp_string := [36]u8{}
offset : uint = 0
print_as_fixed_int :: proc(dst: []u8, offset: ^uint, width: i8, i: i64) {
i := i
@@ -275,7 +275,7 @@ time_to_rfc3339 :: proc(time: Time, utc_offset : int = 0, include_nanos := true,
offset += 1
} else {
temp_string[offset] = utc_offset > 0 ? '+' : '-'
offset += 1;
offset += 1
utc_offset := abs(utc_offset)
print_as_fixed_int(temp_string[:], &offset, 2, i64(utc_offset / 60))
temp_string[offset] = ':'

5
tests/core/time/test_core_time.odin
View File

@@ -201,7 +201,7 @@ test_print_rfc3339 :: proc(t: ^testing.T) {
TestCase :: struct {
printed: string,
time: i64,
utc_offset: int
utc_offset: int,
};
tests :: [?]TestCase {
@@ -221,7 +221,8 @@ test_print_rfc3339 :: proc(t: ^testing.T) {
testing.expectf(
t, printed_timestamp == test.printed,
"expected is %w, printed is %w", test.printed, printed_timestamp)
"expected is %w, printed is %w", test.printed, printed_timestamp,
)
}
}