mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-08-14 01:34:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #7214 from corleypc/no-alias-indirect-return-fix

Browse Source 
Fixes compile error due to #no_alias shifting position in procs with indirect return
This commit is contained in:
Jeroen van Rijn
2026-08-04 16:39:59 +02:00
committed by GitHub
parent b1e2eefafe 9630660f53
commit 7e84194853
1 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/llvm_backend_proc.cpp
View File

@@ -278,13 +278,17 @@ gb_internal lbProcedure *lb_create_procedure(lbModule *m, Entity *entity, bool i
// NOTE(bill): offset==0 is the return value
isize offset = 1;
if (pt->Proc.return_by_pointer) {
lbFunctionType *ft = p->abi_function_type;
GB_ASSERT(ft != nullptr);
if (ft->ret.kind == lbArg_Indirect) {
// return by pointer prepends an sret param
offset = 2;
}
isize parameter_index = 0;
if (pt->Proc.param_count) {
TypeTuple *params = &pt->Proc.params->Tuple;
isize parameter_index = 0; // 0-based position among the Odin proc params in the LLVM function signature
isize ft_args_index = 0; // index into ft->args
for (isize i = 0; i < pt->Proc.param_count; i++) {
Entity *e = params->variables[i];
if (e->kind != Entity_Variable) {
@@ -295,6 +299,13 @@ gb_internal lbProcedure *lb_create_procedure(lbModule *m, Entity *entity, bool i
continue;
}
GB_ASSERT(ft_args_index < ft->args.count);
lbArgType *arg = &ft->args[ft_args_index++];
if (arg->kind == lbArg_Ignore) {
// these are not present in the LLVM function signature, don't advance parameter_index
continue;
}
if (e->flags&EntityFlag_NoAlias) {
lb_add_proc_attribute_at_index(p, offset+parameter_index, "noalias");
}