mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-04-19 21:10:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5408 from slowhei/master

Browse Source 
Fix bug where compiler treats uint enums as ints
This commit is contained in:
Jeroen van Rijn
2025-06-26 14:54:20 +02:00
committed by GitHub
parent 62e797b9d1 1fbc5641c0
commit 88c208d1fb
2 changed files with 37 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/types.cpp
View File

@@ -1248,6 +1248,9 @@ gb_internal bool is_type_unsigned(Type *t) {
if (t->kind == Type_Basic) {
return (t->Basic.flags & BasicFlag_Unsigned) != 0;
}
if (t->kind == Type_Enum) {
return (t->Enum.base_type->Basic.flags & BasicFlag_Unsigned) != 0;
}
return false;
}
gb_internal bool is_type_integer_128bit(Type *t) {

34
tests/internal/test_signedness_comparisons.odin Normal file
View File

@@ -0,0 +1,34 @@
package test_internal
import "core:testing"
@test
test_comparisons_5408 :: proc(t: ^testing.T) {
// See: https://github.com/odin-lang/Odin/pull/5408
test_proc :: proc(lhs: $T, rhs: T) -> bool {
return lhs > rhs
}
Test_Enum :: enum u32 {
SMALL_VALUE = 0xFF,
BIG_VALUE = 0xFF00_0000, // negative if interpreted as i32
}
testing.expect_value(t, test_proc(Test_Enum.SMALL_VALUE, Test_Enum.BIG_VALUE), false)
testing.expect_value(t, test_proc(Test_Enum(0xF), Test_Enum.BIG_VALUE), false)
testing.expect_value(t, test_proc(Test_Enum(0xF), Test_Enum(0xF000_0000)), false)
testing.expect_value(t, test_proc(Test_Enum.SMALL_VALUE, max(Test_Enum)), false)
testing.expect_value(t, test_proc(Test_Enum(0xF), max(Test_Enum)), false)
}
test_signedness :: proc(t: ^testing.T) {
{
a, b := i16(32767), i16(0)
testing.expect_value(t, a > b, true)
}
{
a, b := u16(65535), u16(0)
testing.expect_value(t, a > b, true)
}
}