mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-08-14 09:44:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

make value poly score top

Browse Source
This commit is contained in:
kalsprite
2026-08-06 21:05:54 -07:00
parent ab220ecee7
commit 8b56b15ee2
1 changed files with 18 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/check_expr.cpp
View File

@@ -7607,10 +7607,24 @@ gb_internal CallArgumentData check_call_arguments_proc_group(CheckerContext *c,
array_add(&proc_entities, data.gen_entity);
index = proc_entities.count-1;
// Prefer non-polymorphic procedures over polymorphic. This must be a
// small tie-break: assign_score_function(1) is ~a full perfect-match
// unit, so adding it made a generic beat an exact concrete overload.
item.score -= 1;
// Order candidates: value-polymorphic > concrete > type-polymorphic
//
// `proc($S: string)` specialises on a compile-time *value*
// `proc(x: $T)` specialises on a *type* and is a fallback, so it should
// lose to an exact concrete overload
//
// Both are small tie-breaks on purpose: assign_score_function(1) is
// ~a full perfect-match unit and would swamp argument match quality.
bool has_polymorphic_constant = false;
if (pt->Proc.params != nullptr) {
for (Entity *param : pt->Proc.params->Tuple.variables) {
if (param != nullptr && param->kind == Entity_Constant) {
has_polymorphic_constant = true;
break;
}
}
}
item.score += has_polymorphic_constant ? +1 : -1;
}
max_matched_features = gb_max(max_matched_features, matched_target_features(&pt->Proc));