mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-02-16 08:04:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix race condition when adding a dependency

Browse Source
This commit is contained in:
gingerBill
2021-08-16 15:33:26 +01:00
parent 5f072591ba
commit 94d298755a
3 changed files with 14 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/checker.cpp
View File

@@ -629,14 +629,16 @@ void check_scope_usage(Checker *c, Scope *scope) {
}
void add_dependency(DeclInfo *d, Entity *e) {
void add_dependency(CheckerInfo *info, DeclInfo *d, Entity *e) {
mutex_lock(&info->deps_mutex);
ptr_set_add(&d->deps, e);
mutex_unlock(&info->deps_mutex);
}
void add_type_info_dependency(DeclInfo *d, Type *type) {
if (d == nullptr) {
// GB_ASSERT(type == t_invalid);
return;
}
// NOTE(bill): no mutex is required here because the only procedure calling it is wrapped in a mutex already
ptr_set_add(&d->type_info_deps, type);
}
@@ -657,7 +659,7 @@ void add_package_dependency(CheckerContext *c, char const *package_name, char co
e->flags |= EntityFlag_Used;
GB_ASSERT_MSG(e != nullptr, "%s", name);
GB_ASSERT(c->decl != nullptr);
ptr_set_add(&c->decl->deps, e);
add_dependency(c->info, c->decl, e);
}
void add_declaration_dependency(CheckerContext *c, Entity *e) {
@@ -665,7 +667,7 @@ void add_declaration_dependency(CheckerContext *c, Entity *e) {
return;
}
if (c->decl != nullptr) {
add_dependency(c->decl, e);
add_dependency(c->info, c->decl, e);
}
}