mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-07-12 10:59:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #6916 from tf2spi/6911-check-c-varargs

Browse Source 
Only allow direct CVarArg usage in c_va_start
This commit is contained in:
gingerBill
2026-07-01 01:12:19 +01:00
committed by GitHub
parent e276ce552b c7cd4b9e95
commit 957789d85a
3 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/check_builtin.cpp
View File

@@ -765,8 +765,10 @@ gb_internal bool check_builtin_c_procedure(CheckerContext *c, Operand *operand,
return false;
}
c->allow_c_vararg_param = true;
Operand args = {};
check_expr(c, &args, ce->args[1]);
c->allow_c_vararg_param = false;
if (list.mode == Addressing_Invalid) {
return false;
}

8
src/check_expr.cpp
View File

@@ -1968,6 +1968,14 @@ gb_internal Entity *check_ident(CheckerContext *c, Operand *o, Ast *n, Type *nam
break;
case Entity_Variable:
if ((e->flags & EntityFlag_CVarArg) && !c->allow_c_vararg_param) {
ERROR_BLOCK();
error(o->expr, "'#c_vararg' parameter '%.*s' cannot be used directly", LIT(name));
error_line("\tSuggestion: use c_va_start to convert C varargs to c_va_list\n");
o->mode = Addressing_Invalid;
o->type = t_invalid;
return e;
}
e->flags |= EntityFlag_Used;
if (type == t_invalid) {
o->type = t_invalid;

1
src/checker.hpp
View File

@@ -834,6 +834,7 @@ struct CheckerContext {
bool hide_polymorphic_errors;
bool in_polymorphic_specialization;
bool allow_arrow_right_selector_expr;
bool allow_c_vararg_param;
u8 bit_field_bit_size;
Scope * polymorphic_scope;