mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-04-17 20:12:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add warning when using bit_field when a bit_set would be a much better idea.

Browse Source
This commit is contained in:
gingerBill
2024-02-22 20:10:56 +00:00
parent a8909f06ae
commit 9ea11da00f
1 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/check_type.cpp
View File

@@ -1016,6 +1016,11 @@ gb_internal void check_bit_field_type(CheckerContext *ctx, Type *bit_field_type,
if (o.value.kind == ExactValue_Float) {
o.value = exact_value_to_integer(o.value);
}
if (f->bit_size->kind == Ast_BinaryExpr && f->bit_size->BinaryExpr.op.kind == Token_Or) {
gbString s = expr_to_string(f->bit_size);
error(f->bit_size, "Wrap the expression in parentheses, e.g. (%s)", s);
gb_string_free(s);
}
ExactValue bit_size = o.value;
@@ -1076,7 +1081,6 @@ gb_internal void check_bit_field_type(CheckerContext *ctx, Type *bit_field_type,
curr_offset += cast(i64)bit_sizes[i];
}
if (total_bit_size > maximum_bit_size) {
gbString s = type_to_string(backing_type);
error(node, "The numbers required %llu exceeds the backing type's (%s) bit size %llu",
@@ -1086,6 +1090,27 @@ gb_internal void check_bit_field_type(CheckerContext *ctx, Type *bit_field_type,
gb_string_free(s);
}
if (bit_sizes.count > 0 && is_type_integer(backing_type)) {
bool all_booleans = is_type_boolean(fields[0]->type);
bool all_ones = bit_sizes[0] == 1;
if (all_ones && all_booleans) {
for_array(i, bit_sizes) {
all_ones = bit_sizes[i] == 1;
if (!all_ones) {
break;
}
all_booleans = is_type_boolean(fields[i]->type);
if (!all_booleans) {
break;
}
}
if (all_ones && all_booleans) {
warning(node, "This 'bit_field' might be better expressed as a 'bit_set' since all of the fields are booleans, of 1-bit in size, and the backing type is an integer");
}
}
}
bit_field_type->BitField.fields = slice_from_array(fields);
bit_field_type->BitField.bit_sizes = slice_from_array(bit_sizes);
bit_field_type->BitField.bit_offsets = bit_offsets;