mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-04-18 20:40:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Support select fast path for or_else

Browse Source
This commit is contained in:
gingerBill
2026-03-15 20:02:48 +00:00
parent f70bceec84
commit a56c3da149
2 changed files with 51 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
src/llvm_backend_expr.cpp
View File

@@ -10,44 +10,6 @@ gb_internal LLVMValueRef lb_const_low_bits_mask(LLVMTypeRef type, u64 bit_count)
return LLVMConstInt(type, mask, false);
}
gb_internal bool lb_is_expr_trivial(Ast *e) {
Type *type = default_type(type_of_expr(e));
Type *bt = base_type(type);
if (is_type_integer(bt) || is_type_float(bt) || is_type_boolean(bt) ||
is_type_pointer(bt) || is_type_enum(bt) || is_type_rune(bt) || is_type_typeid((bt))) {
e = unparen_expr(e);
TypeAndValue tav = type_and_value_of_expr(e);
if (tav.mode == Addressing_Constant) {
return true;
}
if (e->kind == Ast_Ident) {
return true;
}
if (e->kind == Ast_SelectorExpr) {
Ast *operand = unparen_expr(e->SelectorExpr.expr);
if (operand && operand->kind == Ast_Ident) {
// If the operand is a pointer, thus deferences it, disallow it
Type *ot = type_of_expr(operand);
if (ot == nullptr || is_type_pointer(ot)) {
return false;
}
return true;
}
}
if (e->kind == Ast_UnaryExpr && e->UnaryExpr.op.kind != Token_And) {
Ast *operand = unparen_expr(e->UnaryExpr.expr);
TypeAndValue otav = type_and_value_of_expr(operand);
if (otav.mode == Addressing_Constant) {
return true;
}
if (operand->kind == Ast_Ident) {
return true;
}
}
}
return false;
}
gb_internal lbValue lb_emit_logical_binary_expr(lbProcedure *p, TokenKind op, Ast *left, Ast *right, Type *final_type) {
lbModule *m = p->module;

51
src/llvm_backend_utility.cpp
View File

@@ -438,6 +438,50 @@ gb_internal lbValue lb_emit_try_has_value(lbProcedure *p, lbValue rhs) {
return has_value;
}
gb_internal bool lb_is_type_trivial(Type *type) {
Type *bt = base_type(type);
if (is_type_integer(bt) || is_type_float(bt) || is_type_boolean(bt) ||
is_type_pointer(bt) || is_type_enum(bt) || is_type_rune(bt) || is_type_typeid((bt))) {
return true;
}
return false;
}
gb_internal bool lb_is_expr_trivial(Ast *e) {
Type *type = default_type(type_of_expr(e));
if (lb_is_type_trivial(type)) {
e = unparen_expr(e);
TypeAndValue tav = type_and_value_of_expr(e);
if (tav.mode == Addressing_Constant) {
return true;
}
if (e->kind == Ast_Ident) {
return true;
}
if (e->kind == Ast_SelectorExpr) {
Ast *operand = unparen_expr(e->SelectorExpr.expr);
if (operand && operand->kind == Ast_Ident) {
// If the operand is a pointer, thus deferences it, disallow it
Type *ot = type_of_expr(operand);
if (ot == nullptr || is_type_pointer(ot)) {
return false;
}
return true;
}
}
if (e->kind == Ast_UnaryExpr && e->UnaryExpr.op.kind != Token_And) {
Ast *operand = unparen_expr(e->UnaryExpr.expr);
TypeAndValue otav = type_and_value_of_expr(operand);
if (otav.mode == Addressing_Constant) {
return true;
}
if (operand->kind == Ast_Ident) {
return true;
}
}
}
return false;
}
gb_internal lbValue lb_emit_or_else(lbProcedure *p, Ast *arg, Ast *else_expr, TypeAndValue const &tv) {
if (arg->state_flags & StateFlag_DirectiveWasFalse) {
@@ -467,6 +511,13 @@ gb_internal lbValue lb_emit_or_else(lbProcedure *p, Ast *arg, Ast *else_expr, Ty
lb_start_block(p, then);
return lb_emit_conv(p, lhs, type);
} else {
if (lb_is_type_trivial(type) && lb_is_expr_trivial(else_expr)) {
lbValue has_value = lb_emit_try_has_value(p, rhs);
lbValue then_val = lb_emit_conv(p, lhs, type);
lbValue else_val = lb_emit_conv(p, lb_build_expr(p, else_expr), type);
return lb_emit_select(p, has_value, then_val, else_val);
}
LLVMValueRef incoming_values[2] = {};
LLVMBasicBlockRef incoming_blocks[2] = {};