mirrors/Odin
1
0
Fork 0
mirror of https://github.com/odin-lang/Odin.git synced 2026-04-19 13:00:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve atomic logic for sync.Wait_Group

Browse Source
This commit is contained in:
gingerBill
2025-07-30 23:11:18 +01:00
parent 939fed592d
commit aa6a749804
1 changed files with 6 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
core/sync/extended.odin
View File

@@ -47,12 +47,12 @@ wait_group_add :: proc "contextless" (wg: ^Wait_Group, delta: int) {
guard(&wg.mutex)
atomic_add(&wg.counter, delta)
if wg.counter < 0 {
switch counter := atomic_load(&wg.counter); counter {
case counter < 0:
panic_contextless("sync.Wait_Group negative counter")
}
if wg.counter == 0 {
case if wg.counter == 0:
cond_broadcast(&wg.cond)
if wg.counter != 0 {
if atomic_load(&wg.counter) != 0 {
panic_contextless("sync.Wait_Group misuse: sync.wait_group_add called concurrently with sync.wait_group_wait")
}
}
@@ -78,11 +78,8 @@ wait group's internal counter reaches zero.
wait_group_wait :: proc "contextless" (wg: ^Wait_Group) {
guard(&wg.mutex)
if wg.counter != 0 {
for atomic_load(&wg.counter) != 0 {
cond_wait(&wg.cond, &wg.mutex)
if wg.counter != 0 {
panic_contextless("sync.Wait_Group misuse: sync.wait_group_add called concurrently with sync.wait_group_wait")
}
}
}
@@ -100,13 +97,10 @@ wait_group_wait_with_timeout :: proc "contextless" (wg: ^Wait_Group, duration: t
}
guard(&wg.mutex)
if wg.counter != 0 {
for atomic_load(&wg.counter) != 0 {
if !cond_wait_with_timeout(&wg.cond, &wg.mutex, duration) {
return false
}
if wg.counter != 0 {
panic_contextless("sync.Wait_Group misuse: sync.wait_group_add called concurrently with sync.wait_group_wait")
}
}
return true
}